From patchwork Tue Mar 29 07:31:06 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 8683161 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 93419C0553 for ; Tue, 29 Mar 2016 07:31:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AF2B92017D for ; Tue, 29 Mar 2016 07:31:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9C1442015A for ; Tue, 29 Mar 2016 07:31:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751949AbcC2HbY (ORCPT ); Tue, 29 Mar 2016 03:31:24 -0400 Received: from mail-lb0-f176.google.com ([209.85.217.176]:35869 "EHLO mail-lb0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751876AbcC2HbY (ORCPT ); Tue, 29 Mar 2016 03:31:24 -0400 Received: by mail-lb0-f176.google.com with SMTP id qe11so4637396lbc.3 for ; Tue, 29 Mar 2016 00:31:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=Uy9MzAknfBW/Zx4ZEZfPItV8S3y+eur8q60Ts2xVq4E=; b=ZlrT9CWaCc6GFWubyAmpNtDYfXjC1PDdQYkoaBaLi5ty1XdMl4JL2mw+Zzs3XLMlRH sW4mothony0CNcKFj+EmwjG6dd75WGOUyO5bHOHYiSs75DX6hYkObCuWLIp97dlcgJZg VWoi61YmIuBYkXmfaCswK7pqBsK8LFp2meCBY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Uy9MzAknfBW/Zx4ZEZfPItV8S3y+eur8q60Ts2xVq4E=; b=gV8xT2ejN6jfGaRtjuMVOzrL6N2lR0FMUZHPi8ihlGRgcqeLt2NEcBGHnq8qFLlUU4 O/OgeccdBH0bPSv+Qg+hokatPj8kKXc3/38yMJGrnqIm2eCNZXI9u1FWGdG9SwUcfMj6 IcXvO5dRLHETg7pK8OCfwHsgA9d6oGdBKO9y9znGshNN+BXaJP8MLJRUvu/f9voxZjIZ 6I5kc3HKhZElGIVkgbh7uEQY0pJk+9zJh+OosbY+NUIi+tkdvLRVVUoTQbh1UR6FACOb qwONlSmIA/xMD8Vrgpvngylpl5+ORgg4lacwTz+81XdXvEWRT7OnPCvc4bDyZ+Z9DQCt N1Cw== X-Gm-Message-State: AD7BkJLzwJ71fHnlWidlU5qfKvRdqGz0KIyoyygNwCZn0+o3dCzLJPhsD6JceRNKANcNKr53 X-Received: by 10.112.161.198 with SMTP id xu6mr361790lbb.131.1459236682436; Tue, 29 Mar 2016 00:31:22 -0700 (PDT) Received: from localhost.localdomain (c-83-233-167-104.cust.bredband2.com. [83.233.167.104]) by smtp.gmail.com with ESMTPSA id qh4sm5033100lbb.43.2016.03.29.00.31.20 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 29 Mar 2016 00:31:21 -0700 (PDT) From: Ulf Hansson To: linux-mmc@vger.kernel.org, Ulf Hansson Cc: Ludovic Desroches Subject: [PATCH 1/8] mmc: atmel-mci: Remove redundant runtime PM calls Date: Tue, 29 Mar 2016 09:31:06 +0200 Message-Id: <1459236673-5639-1-git-send-email-ulf.hansson@linaro.org> X-Mailer: git-send-email 1.9.1 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit 9250aea76bfc ("mmc: core: Enable runtime PM management of host devices"), made some calls to the runtime PM API from the driver redundant. Especially those which deals with runtime PM reference counting, so let's remove them. Cc: Ludovic Desroches Signed-off-by: Ulf Hansson Acked-by: Ludovic Desroches Tested-by: Ludovic Desroches --- drivers/mmc/host/atmel-mci.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c index 9268c41..0ad8ef5 100644 --- a/drivers/mmc/host/atmel-mci.c +++ b/drivers/mmc/host/atmel-mci.c @@ -1410,8 +1410,6 @@ static void atmci_request(struct mmc_host *mmc, struct mmc_request *mrq) WARN_ON(slot->mrq); dev_dbg(&host->pdev->dev, "MRQ: cmd %u\n", mrq->cmd->opcode); - pm_runtime_get_sync(&host->pdev->dev); - /* * We may "know" the card is gone even though there's still an * electrical connection. If so, we really need to communicate @@ -1442,8 +1440,6 @@ static void atmci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) struct atmel_mci *host = slot->host; unsigned int i; - pm_runtime_get_sync(&host->pdev->dev); - slot->sdc_reg &= ~ATMCI_SDCBUS_MASK; switch (ios->bus_width) { case MMC_BUS_WIDTH_1: @@ -1576,8 +1572,6 @@ static void atmci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) break; } - pm_runtime_mark_last_busy(&host->pdev->dev); - pm_runtime_put_autosuspend(&host->pdev->dev); } static int atmci_get_ro(struct mmc_host *mmc) @@ -1669,9 +1663,6 @@ static void atmci_request_end(struct atmel_mci *host, struct mmc_request *mrq) spin_unlock(&host->lock); mmc_request_done(prev_mmc, mrq); spin_lock(&host->lock); - - pm_runtime_mark_last_busy(&host->pdev->dev); - pm_runtime_put_autosuspend(&host->pdev->dev); } static void atmci_command_complete(struct atmel_mci *host,