From patchwork Tue Mar 29 07:31:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 8683231 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 204C3C0553 for ; Tue, 29 Mar 2016 07:31:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2211B201F5 for ; Tue, 29 Mar 2016 07:31:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D16C020212 for ; Tue, 29 Mar 2016 07:31:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756042AbcC2Hbm (ORCPT ); Tue, 29 Mar 2016 03:31:42 -0400 Received: from mail-lb0-f177.google.com ([209.85.217.177]:35153 "EHLO mail-lb0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755977AbcC2Hbk (ORCPT ); Tue, 29 Mar 2016 03:31:40 -0400 Received: by mail-lb0-f177.google.com with SMTP id bc4so4678739lbc.2 for ; Tue, 29 Mar 2016 00:31:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=3nfN5ruRHwzOCXbrl+uETrOAapdZV3SxCh9/UUTrJN0=; b=bbi/TmXAoPa1/yp+GrFXoEcdGdm1C3a0NX+mou6dtOM6KkiRCT+N2bm7hqtPFP2VTz Z5Ltgxm1H8gp6WrfNYwM5WVKw/Az4rxVa/lZ5VgQrz5ALr8se7JRMCyMSq9wIhm3ExHa sUqylEwZhtIqNtFtWPnbdozP/5dbn5IJQooCg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=3nfN5ruRHwzOCXbrl+uETrOAapdZV3SxCh9/UUTrJN0=; b=Q9UbvSaDMXC9OXKEFXLCQ6N6ZSXjzhezywa1crBCeHnV+WpmWs6w/E1RoJYzUJj9aV zKRpeLJIL2uQkX+zTsLCx0IRZpH3aiT+RvSsdR71Rzn6qpGF02ClfEenJVjvixIGnvxu qfFQUEwQwq8qwexF7S3hFjUkQHT2rbOcAhGppyYUUWFIBZuZO/umOBAZakNeZPXaMTpQ CAxVGuX/ajqCasRClUtXYzWOAF8CM51wVYhFnNA7+LI08kOYj2mAoL3hJotZNUrBe6/w gC7tQ2xL/VpcEHw4U839PLPO0Z7FtZ9WhbHte/H9MRMd+wRPC3HcvhLl5GuJHYPtOixR 6N9Q== X-Gm-Message-State: AD7BkJKXLlQzUqH4nicqn0CmBQrsd1HmTd9/EuXgk8lhnmzjTSawZnn7KI5BBKzBWpnxSr2w X-Received: by 10.112.170.68 with SMTP id ak4mr330344lbc.94.1459236693527; Tue, 29 Mar 2016 00:31:33 -0700 (PDT) Received: from localhost.localdomain (c-83-233-167-104.cust.bredband2.com. [83.233.167.104]) by smtp.gmail.com with ESMTPSA id qh4sm5033100lbb.43.2016.03.29.00.31.31 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 29 Mar 2016 00:31:32 -0700 (PDT) From: Ulf Hansson To: linux-mmc@vger.kernel.org, Ulf Hansson Cc: Ian Molton Subject: [PATCH 8/8] mmc: tmio: Remove redundant runtime PM calls Date: Tue, 29 Mar 2016 09:31:13 +0200 Message-Id: <1459236673-5639-8-git-send-email-ulf.hansson@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1459236673-5639-1-git-send-email-ulf.hansson@linaro.org> References: <1459236673-5639-1-git-send-email-ulf.hansson@linaro.org> Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit 9250aea76bfc ("mmc: core: Enable runtime PM management of host devices"), made some calls to the runtime PM API from the driver redundant. Especially those which deals with runtime PM reference counting, so let's remove them. Cc: Ian Molton Signed-off-by: Ulf Hansson --- drivers/mmc/host/tmio_mmc_pio.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/drivers/mmc/host/tmio_mmc_pio.c b/drivers/mmc/host/tmio_mmc_pio.c index 03f6e74..d822299 100644 --- a/drivers/mmc/host/tmio_mmc_pio.c +++ b/drivers/mmc/host/tmio_mmc_pio.c @@ -264,9 +264,6 @@ static void tmio_mmc_reset_work(struct work_struct *work) tmio_mmc_abort_dma(host); mmc_request_done(host->mmc, mrq); - - pm_runtime_mark_last_busy(mmc_dev(host->mmc)); - pm_runtime_put_autosuspend(mmc_dev(host->mmc)); } /* called with host->lock held, interrupts disabled */ @@ -296,9 +293,6 @@ static void tmio_mmc_finish_request(struct tmio_mmc_host *host) tmio_mmc_abort_dma(host); mmc_request_done(host->mmc, mrq); - - pm_runtime_mark_last_busy(mmc_dev(host->mmc)); - pm_runtime_put_autosuspend(mmc_dev(host->mmc)); } static void tmio_mmc_done_work(struct work_struct *work) @@ -812,8 +806,6 @@ static void tmio_mmc_request(struct mmc_host *mmc, struct mmc_request *mrq) spin_unlock_irqrestore(&host->lock, flags); - pm_runtime_get_sync(mmc_dev(mmc)); - if (mrq->data) { ret = tmio_mmc_start_data(host, mrq->data); if (ret) @@ -832,9 +824,6 @@ fail: host->mrq = NULL; mrq->cmd->error = ret; mmc_request_done(mmc, mrq); - - pm_runtime_mark_last_busy(mmc_dev(mmc)); - pm_runtime_put_autosuspend(mmc_dev(mmc)); } static int tmio_mmc_clk_update(struct tmio_mmc_host *host) @@ -925,8 +914,6 @@ static void tmio_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) struct device *dev = &host->pdev->dev; unsigned long flags; - pm_runtime_get_sync(mmc_dev(mmc)); - mutex_lock(&host->ios_lock); spin_lock_irqsave(&host->lock, flags); @@ -983,9 +970,6 @@ static void tmio_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) host->clk_cache = ios->clock; mutex_unlock(&host->ios_lock); - - pm_runtime_mark_last_busy(mmc_dev(mmc)); - pm_runtime_put_autosuspend(mmc_dev(mmc)); } static int tmio_mmc_get_ro(struct mmc_host *mmc) @@ -996,11 +980,8 @@ static int tmio_mmc_get_ro(struct mmc_host *mmc) if (ret >= 0) return ret; - pm_runtime_get_sync(mmc_dev(mmc)); ret = !((pdata->flags & TMIO_MMC_WRPROTECT_DISABLE) || (sd_ctrl_read32(host, CTL_STATUS) & TMIO_STAT_WRPROTECT)); - pm_runtime_mark_last_busy(mmc_dev(mmc)); - pm_runtime_put_autosuspend(mmc_dev(mmc)); return ret; }