From patchwork Thu Apr 14 02:29:45 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 8830611 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E4857C0554 for ; Thu, 14 Apr 2016 02:31:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 190462017E for ; Thu, 14 Apr 2016 02:31:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3017320295 for ; Thu, 14 Apr 2016 02:31:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752474AbcDNCbO (ORCPT ); Wed, 13 Apr 2016 22:31:14 -0400 Received: from conuserg-07.nifty.com ([210.131.2.74]:40573 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753567AbcDNC3b (ORCPT ); Wed, 13 Apr 2016 22:29:31 -0400 Received: from beagle.diag.org (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id u3E2Sr3d010961; Thu, 14 Apr 2016 11:28:55 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com u3E2Sr3d010961 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1460600935; bh=Eh+JwophUTq2zRYQm/M+pMn9zEluQHAjPoNZBnOc55k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=avaROZCfRskCeDUHVL9agxcTeTptbo/+uKU55XakRxWLzOk3a2PFIhQGJ0XNiPVQr k7PDiI3zdnapjQ0rvMmFu1BTRv9txxXAqMiJ1Ak6uyC1u4uhkN5yKK0KHGF3g9C/Tq BaxfPb54YKyU4K4XLViT9rcM5VgOZUyaWxgW0ZcSZTruF7gpZuqZcP1a0kJyhsCm7g JVZEeLc5XIBu91utcPr3Xvu2+QipyDC09kcUS7Z/yX2pyyEePsW/8dlJdS3DI+vg8e LzsvAnGK7e5S6M2BTPTCljrxjbV775c55GZWP4qJdHfYw8Kp4s8BEqN6u5PBTkafvQ cs/yVIz0YBBfg== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-mmc@vger.kernel.org Cc: Masahiro Yamada , linux-kernel@vger.kernel.org, Adrian Hunter , Ulf Hansson Subject: [PATCH 2/7] mmc: sdhci-pltfm: check return value of platform_get_irq() Date: Thu, 14 Apr 2016 11:29:45 +0900 Message-Id: <1460600990-10993-3-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1460600990-10993-1-git-send-email-yamada.masahiro@socionext.com> References: <1460600990-10993-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The function platform_get_irq() can fail; it returns a negative error code on error. A negative IRQ number will make sdhci_add_host() fail to request IRQ anyway, but it makes sense to let it fail earlier here. Signed-off-by: Masahiro Yamada --- drivers/mmc/host/sdhci-pltfm.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c index 7d12203..3354a53 100644 --- a/drivers/mmc/host/sdhci-pltfm.c +++ b/drivers/mmc/host/sdhci-pltfm.c @@ -152,6 +152,11 @@ struct sdhci_host *sdhci_pltfm_init(struct platform_device *pdev, } host->irq = platform_get_irq(pdev, 0); + if (host->irq < 0) { + dev_err(&pdev->dev, "failed to get IRQ number"); + ret = host->irq; + goto err_request; + } if (!request_mem_region(iomem->start, resource_size(iomem), mmc_hostname(host->mmc))) {