From patchwork Fri Apr 15 17:29:38 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 8854361 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 7E0E59F3A0 for ; Fri, 15 Apr 2016 17:53:18 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 864AA2026F for ; Fri, 15 Apr 2016 17:53:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A15CE20379 for ; Fri, 15 Apr 2016 17:53:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751116AbcDORxP (ORCPT ); Fri, 15 Apr 2016 13:53:15 -0400 Received: from mail-bl2on0093.outbound.protection.outlook.com ([65.55.169.93]:26016 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751100AbcDORxO (ORCPT ); Fri, 15 Apr 2016 13:53:14 -0400 Received: from CH1PR03CA004.namprd03.prod.outlook.com (10.255.156.149) by BY1PR0301MB1221.namprd03.prod.outlook.com (10.161.203.17) with Microsoft SMTP Server (TLS) id 15.1.453.26; Fri, 15 Apr 2016 17:37:52 +0000 Received: from BN1BFFO11FD034.protection.gbl (10.255.156.132) by CH1PR03CA004.outlook.office365.com (10.255.156.149) with Microsoft SMTP Server (TLS) id 15.1.466.19 via Frontend Transport; Fri, 15 Apr 2016 17:37:51 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; gmail.com; dkim=none (message not signed) header.d=none; gmail.com; dmarc=none action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1BFFO11FD034.mail.protection.outlook.com (10.58.144.97) with Microsoft SMTP Server (TLS) id 15.1.453.6 via Frontend Transport; Fri, 15 Apr 2016 17:37:48 +0000 Received: from shlinux2.ap.freescale.net (shlinux2.ap.freescale.net [10.192.224.44]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id u3FHb2HP019919; Fri, 15 Apr 2016 10:37:44 -0700 From: Dong Aisheng To: CC: , , , , , , , Subject: [PATCH 14/23] mmc: sdhci-esdhci-imx: disable DLL delay line settings explicitly Date: Sat, 16 Apr 2016 01:29:38 +0800 Message-ID: <1460741387-23815-15-git-send-email-aisheng.dong@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1460741387-23815-1-git-send-email-aisheng.dong@nxp.com> References: <1460741387-23815-1-git-send-email-aisheng.dong@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131052154718947819; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(48376002)(5008740100001)(19580395003)(4326007)(19580405001)(33646002)(85426001)(87936001)(189998001)(2950100001)(1096002)(110136002)(50986999)(76176999)(1220700001)(50466002)(86362001)(105606002)(586003)(5003940100001)(106466001)(6806005)(104016004)(47776003)(2351001)(77096005)(92566002)(2906002)(50226001)(36756003)(229853001)(230783001)(81166005)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:BY1PR0301MB1221; H:az84smr01.freescale.net; FPR:; SPF:Fail; MLV:sfv; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD034; 1:HdhE8YrbPtgK716YCY9oj64IjH0YNoYLUnlZ+fW8AUPgwkhQS8wgXVtmJpiZGaq2fDBrQ8JE9ry7cJmtHurLijeDwBfKszI4gRYHgKxO/0STr3aOB9dxej8x454QzKNPQAWBEahycWJTizoZywJyzzr5nI1PmNZKcl18dTwPrCd8II92dVsUYl/v9OGNytSv8gyQ7TOMMfSEwu3SmEFhP6JDWHMyd5RzvyMAVWLh4aEYWbx9OqTxVIT1YccwOCiCx120SqFI4WDoHNg/oB68wfOnYjZYZIuTw1VOXOO9Jpj2D5JgEjM2qr58BVxzsiLKlEREFwpzjJZap6/losGRib++9KL69xQmucg47pdrYTANjcOltuG2EumBbbnuEOkcBYQK4QpkyimjIWwS9Z4/VXQeqy6Kn1xj8om9TnVeSjpoY4CbGdBQhCVV9uFZ+2FfhNp+jMgx3T1ii/GIn1fibLJju28Jxav+WW2v3ov/BJdAOcdFovh3IPyySuFXOtpHoaYUsCVnHKyu/mBRH2zcer9sqLqQO1LW4RedNDzVk9ZvgiR+ns9+yqkkI3rQQ7FudACzksScoxAVBI7Rbcu/31yBRwUptp2QygQoRzR87HRc+UacDoH3ddLU7G6DJDbE MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: e6ea8f65-f43f-48bc-7edb-08d36554ab76 X-Microsoft-Exchange-Diagnostics: 1; BY1PR0301MB1221; 2:buJi6djiSJh0shl3pLZJmYd97XAXtcsaU+CsnY8Jqd/kXqtdmFhcPq/6uG+lThyCcU9pRoz40jM8HCECs5hEYbbRFhWRnM16XXs/Nf0Xdoy+GNG9lpOGKnkLtNzdiqFz63MSwfV0ijijrzcS7CLOfKuuRaE0KddNjSOdiv4RQ6E8HRZ9cMfh0A2+3XQlKmlc; 3:DimVTB5x635MLb8N1SgicyltLGpJnE04Cu4rAXR0BrIhPcyLiNJspIapy/0pgkoTHTPj5rB391thZLyzmjONJ+k0+Vh4+bZNnysi8IlkJVmwA29w4eNiNJ5c1h22+oC161MLblS7fJWovECbhR2yEjV50t+QKfAaTWH4/sTvxC/mGd+G7zI1/TGI8Fzp9zDFGCQe3MkQhW9ACwuidppaY6fe79fcykm3wZtl1MfME34= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0301MB1221; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0301MB1221; 25:SFiFJjh93KpQot7usbmyR/fAuaezUN5D0xD4K7KgfiAAjXHjLnv9yMY7fvFoU1eDG4yL3W2ZM8cYlMnSKysFRnHf1q74rPkMYpSLhAUqNUDUy/3i1j7I+rleX2wqkjnrCFSTu3yFt0Q7HWbmEpiwMghmNSUAMlhkpd64NFHFowmt620k6TG+dCGign+1Ke7SmCfCmuEVoIU38xG+qzf+C3lVlwri6zZ9hZrNifzIbNIspJ0nwSkWrxFINLNPtVGqgNZC3eZAJNOS32jjxkhcDiSpHYQ3psWFeaqZ7bbMGPBIbcsJLAw3MVBOA+hG4fCkF556qW3GDbgF96MdlWACq3KNNKp9uhKA3FxMmJDwKVWHN45TQoXJEyYDJQBSBIShsgtmt/MjKLfT9xn0OC4Mu9JliSj1SmuEc8keFEuoKQmD/WVz7hH/cPnU5kAVTWbsRy9oK7yODjfYQkbzCOdBiWhRIMfOeVSbRC32JqosDqiBqjO3Z/3WwLDkiCV9iutcnVDTeSFg2Ktv/G7agSRQMrmKZcVTCRIhK50Fw+UHav3ZSiNZIarjhkME0oUUSTCnoedF71KXthIMajjyF+d4Zfil9d40Dxjb5QjLLj+iW+dl6L6mch5bebOYfpfc2FS65RxbOVpZO57iHl7PXx3Vbg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(13024025)(13017025)(13023025)(13015025)(13018025)(8121501046)(10201501046)(3002001)(6055026); SRVR:BY1PR0301MB1221; BCL:0; PCL:0; RULEID:(400006); SRVR:BY1PR0301MB1221; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0301MB1221; 4:sV1v7CrmAJjijnilfGd6BPjVA0/43H0KkfLvp47073mRUhk0HFyvysM4ztwKDHX7K2O6A2RLxoI/RpT/fkk08ARXy2iPdr+QEH8YIVmFJsUTUP3o4MgVCxRnnzlvAsLcgq7EvRzA+Un/K4kY/S3YllyaZdJGCtyLlWp7MxrD3IuEnQ6JvMTcIRIcjAbgWl6y7VZMN3hXIc6SBzP6T8xrI0sqdfdBOJoJSukOBeGWOi1LATRu5b43lYdxPU3bCPh0oJzDa5gJiUsnZPj5899mdn65S77HMRVpSJivRiMBPMflGWDAXpXGY/RHd63S0JdkIsNql22w9wKI0FBopByiFy89G8IsXZ2ghvrylnJ3SFe8RyY95yJv6IpJXQ89SallvXGsiUTwoo3P+7NNWKKN81YnqIbhLGLhb1q6xSJNEGZqQPTGmdeVHIJ3DId5XgJ0kcmFbZEITgb6nFo5m2/S/KbtVFQOwYuhqvnh6lXt8fw= X-Forefront-PRVS: 0913EA1D60 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY1PR0301MB1221; 23:44I3fKU9nUxVSTrcXAGn1vwY0fmTLf9gz5Xkska?= =?us-ascii?Q?BYgv1TcNbRpggNpguymBNaPAwaTNETxMC3SNFuoFXnKNpf2BXGZGVdSwqcyv?= =?us-ascii?Q?rkMKs4JvgOc1bi0gf1LqIBOlmikXYndnG1qV5igBjMNZpSy51AGcHuN8T7Oj?= =?us-ascii?Q?T9gjMXXeYpookZHHap+u9OKGaxLPFWnl1xTiyRZZ3w8xLYXtX+aPONDWdvXS?= =?us-ascii?Q?drzkB2fQpReEoriv1oNMqajmBel+lqZ+eh5tJS5tzLIisJSMJ3V1ctS15YW5?= =?us-ascii?Q?i/1HCKhOpjTlp2d6rSsAiGoa8AQxepsiKVBnndEBXEM6r2LfL5AuTwGNJGQt?= =?us-ascii?Q?mYj9SjK+QjdXEiE4APLe7+bh9FsSj3cm5s+EUkFDBKo4dVNY2kAwlnrgwYVR?= =?us-ascii?Q?5qt3eA1cEKItjajLoo1bcNMP2EPSBdAy4kjiypfbvcMqsZOIB3UsKK+5PPD6?= =?us-ascii?Q?8UWI420Zs6lbAOHtLKSXofVswOSvn1rwffuDi8hTlUF2JAFlOAbsKoWNNgtB?= =?us-ascii?Q?A+Z93cXNBhmmaLAIDLkuHcSvggTE58HB3PLBw73a/7KBwI5vqDJV7GKgll+Q?= =?us-ascii?Q?1xvDnh2dCo4U+koU0JVRMIz6HMDKeRSMiHM9VtIrvdJEh9qHh/DL2h42Wtr9?= =?us-ascii?Q?2dhw1yqrcYyndq8hAuiGlKA6O7/qfhfLNLTXtkLKNy2G/ZInX37BCDOaXar2?= =?us-ascii?Q?OV1xnjJHODrv+4OZ0refd0TM+2MAfSu3hW7diBdpRargWko+a/3qerJgJE6N?= =?us-ascii?Q?8iK51SatZaOfNwtPPO586fvq0WK7Zor/f6A2gb+BetePNPIHaaUu2Bbzztao?= =?us-ascii?Q?3WA0UHyVlSFF0pdw6JCDlBSDk8ADX6r1b+3E3UBiUNrFdjxq/Z3Psn97gyYj?= =?us-ascii?Q?8BTGhEepEnhVvmaoIAI1RNqD38zqGJDGtwuIk8aglbS/0A/h7by5WZ7pjlhG?= =?us-ascii?Q?j4gJIMjFWlcamNelU3GgS4Iat4i8HRM0N2W94CkttyOiUOQOVljL+s2y5rpD?= =?us-ascii?Q?bRHnxwrWWCAZi1CFtFGj+MFe2TazNytKp5IVcnPmcghy0W6noYKhbQ1tlllx?= =?us-ascii?Q?Ir5LnjPc=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY1PR0301MB1221; 5:suQUAc3nz4diKH7rVgSdIkotCLu8//DaR4OTzDavzqq02htkDrQi3Kjs8Ti0lqvL2uRxxQ9+0pZZRhT116pk8RZyT3IpjdofDbdMU4euJLqUZAHPWhaN4YM5oU+Um9NzspJc9ZML9BS/+t0UICzSN6XkztTmkm0ptUfEDWmDVi0=; 24:+5RN3nWeU+u7+J/eXS6YJzXjcUfuQrpEZAk7VdqqAy+RNwSP7F5lQ3h+MNaBML1aWePXrj6pNZLqA7/cU8o857LJn8lzyELFN4aljOK8cM8= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2016 17:37:48.2911 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0301MB1221 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Dong Aisheng Disable DLL delay line settings explicitly during driver initialization in case ROM/uBoot had set an invalid delay. e.g. MX6DL ROM has set the default delay line(DLLCTRL) to 0x1000021, the uSDHC clock timing will become marginal when works on DDR mode due to default delay and will possibly see CRC errors in case the board is not perfectly designed on the eMMC chip layout. Signed-off-by: Dong Aisheng Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-esdhc-imx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c index 4c28fbb..d02db66 100644 --- a/drivers/mmc/host/sdhci-esdhc-imx.c +++ b/drivers/mmc/host/sdhci-esdhc-imx.c @@ -1186,6 +1186,9 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev) */ writel(readl(host->ioaddr + 0x6c) | BIT(7), host->ioaddr + 0x6c); + + /* disable DLL_CTRL delay line settings */ + writel(0x0, host->ioaddr + ESDHC_DLL_CTRL); } if (imx_data->socdata->flags & ESDHC_FLAG_MAN_TUNING)