From patchwork Tue Jun 7 22:44:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Douglas Anderson X-Patchwork-Id: 9162731 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2DB8F60832 for ; Tue, 7 Jun 2016 22:46:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2067E28360 for ; Tue, 7 Jun 2016 22:46:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1585C2836E; Tue, 7 Jun 2016 22:46:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 26FD628369 for ; Tue, 7 Jun 2016 22:46:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423523AbcFGWqR (ORCPT ); Tue, 7 Jun 2016 18:46:17 -0400 Received: from mail-pf0-f174.google.com ([209.85.192.174]:35179 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423514AbcFGWpT (ORCPT ); Tue, 7 Jun 2016 18:45:19 -0400 Received: by mail-pf0-f174.google.com with SMTP id c2so9269770pfa.2 for ; Tue, 07 Jun 2016 15:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vtgu6eWrQOXiH6NJEbpq3VesUlWdnxUB0viJRNtQRS8=; b=mwQPVOFoA8ho0+t72u3Kux49/pWJxBqyi6sFpSyZ1pPf6pASGHd9FE9GWO+VZfGStF BfDZ/5fAyUATwI/OUsoSmddjOhD6Ek18F5Tf/a2zN5YrCpnfr9FrkJ7EgsRd5KheA3zs zJkTrtZqHZogIT2A1QaFFfJ+8MfGIgEkNsYVY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vtgu6eWrQOXiH6NJEbpq3VesUlWdnxUB0viJRNtQRS8=; b=kqRizxKfyCEMZwZyGCQNwu3v7mSLS1jeAR0aPRJM/rp6EoOSQRcYlVa7uRE+DG/Lbu 8X0pljiqL9U29xvkYsRaVxPOXB7VEevIcCxRayTWaDRj2LmgnGyml1L7OjWw5ShNUNoY FG6DG9TmOPsD5iU4HKySlYIlZbN8X56ltxfbZwel4nMxg9JNg1lqzkz314cgARZp8jrv CT1qlb2k2TICdju1ijKg0B80AYU2e+AgKZxkPCxtHEYC1fEpt1u8IY5io/Mrn3qp57OD nO6Ylwr0uUKc85OacUPpRXP+Kh6d+AC4MF/F7JM8Pe+1ySrFGUSTjB+qxQe8RprKsjkV Firw== X-Gm-Message-State: ALyK8tLpOtgez3J/NWVv4sEZn5phlKvYPIq1KLLudQrXx2Xy2d7TyJr2Zvreu23vBtCQ0zVU X-Received: by 10.98.91.196 with SMTP id p187mr1941519pfb.58.1465339518016; Tue, 07 Jun 2016 15:45:18 -0700 (PDT) Received: from tictac.mtv.corp.google.com ([172.22.65.76]) by smtp.gmail.com with ESMTPSA id 4sm37641782pfm.15.2016.06.07.15.45.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 07 Jun 2016 15:45:17 -0700 (PDT) From: Douglas Anderson To: ulf.hansson@linaro.org, kishon@ti.com, Heiko Stuebner , robh+dt@kernel.org Cc: shawn.lin@rock-chips.com, xzy.xu@rock-chips.com, briannorris@chromium.org, adrian.hunter@intel.com, linux-rockchip@lists.infradead.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, Douglas Anderson , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 10/11] phy: rockchip-emmc: Minor code cleanup in rockchip_emmc_phy_power_off() Date: Tue, 7 Jun 2016 15:44:43 -0700 Message-Id: <1465339484-969-11-git-send-email-dianders@chromium.org> X-Mailer: git-send-email 2.8.0.rc3.226.g39d4020 In-Reply-To: <1465339484-969-1-git-send-email-dianders@chromium.org> References: <1465339484-969-1-git-send-email-dianders@chromium.org> Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There's no reason to store the return value of rockchip_emmc_phy_power() in a variable nor to check it. Just return it. Signed-off-by: Douglas Anderson --- drivers/phy/phy-rockchip-emmc.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/phy/phy-rockchip-emmc.c b/drivers/phy/phy-rockchip-emmc.c index 0fce7359d468..188e4c387ba8 100644 --- a/drivers/phy/phy-rockchip-emmc.c +++ b/drivers/phy/phy-rockchip-emmc.c @@ -227,8 +227,6 @@ static int rockchip_emmc_phy_power_off(struct phy *phy) static int rockchip_emmc_phy_power_on(struct phy *phy) { struct rockchip_emmc_phy *rk_phy = phy_get_drvdata(phy); - int ret = 0; - /* Drive impedance: 50 Ohm */ regmap_write(rk_phy->reg_base, @@ -252,11 +250,7 @@ static int rockchip_emmc_phy_power_on(struct phy *phy) PHYCTRL_OTAPDLYSEL_SHIFT)); /* Power up emmc phy analog blocks */ - ret = rockchip_emmc_phy_power(phy, PHYCTRL_PDB_PWR_ON); - if (ret) - return ret; - - return 0; + return rockchip_emmc_phy_power(phy, PHYCTRL_PDB_PWR_ON); } static const struct phy_ops ops = {