diff mbox

mmc: sdhci-pci: Add support for Intel KBP

Message ID 1466594353-13730-1-git-send-email-adrian.hunter@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Adrian Hunter June 22, 2016, 11:19 a.m. UTC 
Add PCI ID for Intel KBP SD host controller.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
 drivers/mmc/host/sdhci-pci-core.c | 8 ++++++++
 drivers/mmc/host/sdhci-pci.h      | 1 +
 2 files changed, 9 insertions(+)

Comments

Ulf Hansson June 22, 2016, 3:24 p.m. UTC | #1 
On 22 June 2016 at 13:19, Adrian Hunter <adrian.hunter@intel.com> wrote:
> Add PCI ID for Intel KBP SD host controller.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/host/sdhci-pci-core.c | 8 ++++++++
>  drivers/mmc/host/sdhci-pci.h      | 1 +
>  2 files changed, 9 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
> index a4dbf7421edc..5b03a7ecc6c9 100644
> --- a/drivers/mmc/host/sdhci-pci-core.c
> +++ b/drivers/mmc/host/sdhci-pci-core.c
> @@ -1215,6 +1215,14 @@ static const struct pci_device_id pci_ids[] = {
>         },
>
>         {
> +               .vendor         = PCI_VENDOR_ID_INTEL,
> +               .device         = PCI_DEVICE_ID_INTEL_KBP_SD,
> +               .subvendor      = PCI_ANY_ID,
> +               .subdevice      = PCI_ANY_ID,
> +               .driver_data    = (kernel_ulong_t)&sdhci_intel_byt_sd,
> +       },
> +
> +       {
>                 .vendor         = PCI_VENDOR_ID_O2,
>                 .device         = PCI_DEVICE_ID_O2_8120,
>                 .subvendor      = PCI_ANY_ID,
> diff --git a/drivers/mmc/host/sdhci-pci.h b/drivers/mmc/host/sdhci-pci.h
> index 89e7151684a1..968b81ed8e4d 100644
> --- a/drivers/mmc/host/sdhci-pci.h
> +++ b/drivers/mmc/host/sdhci-pci.h
> @@ -34,6 +34,7 @@
>  #define PCI_DEVICE_ID_INTEL_APL_SD     0x5aca
>  #define PCI_DEVICE_ID_INTEL_APL_EMMC   0x5acc
>  #define PCI_DEVICE_ID_INTEL_APL_SDIO   0x5ad0
> +#define PCI_DEVICE_ID_INTEL_KBP_SD     0xa2f5
>
>  /*
>   * PCI registers
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Adrian Hunter July 7, 2016, 9:04 a.m. UTC | #2 
On 22/06/16 18:24, Ulf Hansson wrote:
> On 22 June 2016 at 13:19, Adrian Hunter <adrian.hunter@intel.com> wrote:
>> Add PCI ID for Intel KBP SD host controller.
>>
>> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> 
> Thanks, applied for next!

It turns out this ID is wrong!  Can you please drop this patch from next?

> 
> Kind regards
> Uffe
> 
>> ---
>>  drivers/mmc/host/sdhci-pci-core.c | 8 ++++++++
>>  drivers/mmc/host/sdhci-pci.h      | 1 +
>>  2 files changed, 9 insertions(+)
>>
>> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
>> index a4dbf7421edc..5b03a7ecc6c9 100644
>> --- a/drivers/mmc/host/sdhci-pci-core.c
>> +++ b/drivers/mmc/host/sdhci-pci-core.c
>> @@ -1215,6 +1215,14 @@ static const struct pci_device_id pci_ids[] = {
>>         },
>>
>>         {
>> +               .vendor         = PCI_VENDOR_ID_INTEL,
>> +               .device         = PCI_DEVICE_ID_INTEL_KBP_SD,
>> +               .subvendor      = PCI_ANY_ID,
>> +               .subdevice      = PCI_ANY_ID,
>> +               .driver_data    = (kernel_ulong_t)&sdhci_intel_byt_sd,
>> +       },
>> +
>> +       {
>>                 .vendor         = PCI_VENDOR_ID_O2,
>>                 .device         = PCI_DEVICE_ID_O2_8120,
>>                 .subvendor      = PCI_ANY_ID,
>> diff --git a/drivers/mmc/host/sdhci-pci.h b/drivers/mmc/host/sdhci-pci.h
>> index 89e7151684a1..968b81ed8e4d 100644
>> --- a/drivers/mmc/host/sdhci-pci.h
>> +++ b/drivers/mmc/host/sdhci-pci.h
>> @@ -34,6 +34,7 @@
>>  #define PCI_DEVICE_ID_INTEL_APL_SD     0x5aca
>>  #define PCI_DEVICE_ID_INTEL_APL_EMMC   0x5acc
>>  #define PCI_DEVICE_ID_INTEL_APL_SDIO   0x5ad0
>> +#define PCI_DEVICE_ID_INTEL_KBP_SD     0xa2f5
>>
>>  /*
>>   * PCI registers
>> --
>> 1.9.1
>>
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ulf Hansson July 12, 2016, 10:08 a.m. UTC | #3 
On 7 July 2016 at 11:04, Adrian Hunter <adrian.hunter@intel.com> wrote:
> On 22/06/16 18:24, Ulf Hansson wrote:
>> On 22 June 2016 at 13:19, Adrian Hunter <adrian.hunter@intel.com> wrote:
>>> Add PCI ID for Intel KBP SD host controller.
>>>
>>> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
>>
>> Thanks, applied for next!
>
> It turns out this ID is wrong!  Can you please drop this patch from next?

I have dropped it from my next branch, sorry for the delay!

Kind regards
Uffe

>
>>
>> Kind regards
>> Uffe
>>
>>> ---
>>>  drivers/mmc/host/sdhci-pci-core.c | 8 ++++++++
>>>  drivers/mmc/host/sdhci-pci.h      | 1 +
>>>  2 files changed, 9 insertions(+)
>>>
>>> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
>>> index a4dbf7421edc..5b03a7ecc6c9 100644
>>> --- a/drivers/mmc/host/sdhci-pci-core.c
>>> +++ b/drivers/mmc/host/sdhci-pci-core.c
>>> @@ -1215,6 +1215,14 @@ static const struct pci_device_id pci_ids[] = {
>>>         },
>>>
>>>         {
>>> +               .vendor         = PCI_VENDOR_ID_INTEL,
>>> +               .device         = PCI_DEVICE_ID_INTEL_KBP_SD,
>>> +               .subvendor      = PCI_ANY_ID,
>>> +               .subdevice      = PCI_ANY_ID,
>>> +               .driver_data    = (kernel_ulong_t)&sdhci_intel_byt_sd,
>>> +       },
>>> +
>>> +       {
>>>                 .vendor         = PCI_VENDOR_ID_O2,
>>>                 .device         = PCI_DEVICE_ID_O2_8120,
>>>                 .subvendor      = PCI_ANY_ID,
>>> diff --git a/drivers/mmc/host/sdhci-pci.h b/drivers/mmc/host/sdhci-pci.h
>>> index 89e7151684a1..968b81ed8e4d 100644
>>> --- a/drivers/mmc/host/sdhci-pci.h
>>> +++ b/drivers/mmc/host/sdhci-pci.h
>>> @@ -34,6 +34,7 @@
>>>  #define PCI_DEVICE_ID_INTEL_APL_SD     0x5aca
>>>  #define PCI_DEVICE_ID_INTEL_APL_EMMC   0x5acc
>>>  #define PCI_DEVICE_ID_INTEL_APL_SDIO   0x5ad0
>>> +#define PCI_DEVICE_ID_INTEL_KBP_SD     0xa2f5
>>>
>>>  /*
>>>   * PCI registers
>>> --
>>> 1.9.1
>>>
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
index a4dbf7421edc..5b03a7ecc6c9 100644
--- a/drivers/mmc/host/sdhci-pci-core.c
+++ b/drivers/mmc/host/sdhci-pci-core.c
@@ -1215,6 +1215,14 @@  static const struct pci_device_id pci_ids[] = {
 	},
 
 	{
+		.vendor		= PCI_VENDOR_ID_INTEL,
+		.device		= PCI_DEVICE_ID_INTEL_KBP_SD,
+		.subvendor	= PCI_ANY_ID,
+		.subdevice	= PCI_ANY_ID,
+		.driver_data	= (kernel_ulong_t)&sdhci_intel_byt_sd,
+	},
+
+	{
 		.vendor		= PCI_VENDOR_ID_O2,
 		.device		= PCI_DEVICE_ID_O2_8120,
 		.subvendor	= PCI_ANY_ID,
diff --git a/drivers/mmc/host/sdhci-pci.h b/drivers/mmc/host/sdhci-pci.h
index 89e7151684a1..968b81ed8e4d 100644
--- a/drivers/mmc/host/sdhci-pci.h
+++ b/drivers/mmc/host/sdhci-pci.h
@@ -34,6 +34,7 @@ 
 #define PCI_DEVICE_ID_INTEL_APL_SD	0x5aca
 #define PCI_DEVICE_ID_INTEL_APL_EMMC	0x5acc
 #define PCI_DEVICE_ID_INTEL_APL_SDIO	0x5ad0
+#define PCI_DEVICE_ID_INTEL_KBP_SD	0xa2f5
 
 /*
  * PCI registers