Message ID | 1474038102-20937-1-git-send-email-zach.brown@ni.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On 16 September 2016 at 17:01, Zach Brown <zach.brown@ni.com> wrote: > The sdhci controller on xilinx zynq devices will not function unless > the CD bit is provided. http://www.xilinx.com/support/answers/61064.html > In cases where it is impossible to provide the CD bit in hardware, > setting the controller to test mode and then setting inserted to true > will get the controller to function without the CD bit. > > The device property "xlnx,fails-without-test-cd" will let the arasan > driver know the controller does not have the CD line wired and that the > controller does not function without it. > > Signed-off-by: Zach Brown <zach.brown@ni.com> Thanks, applied for next! I took the liberty to shrink the commit msg header bit and to add "dt: " prefix. Kind regards Uffe > --- > v2: > * improved commit messages > * removed fake-cd device property > * removed fake-cd quirk > * use broken-cd device property > * documented new usage of broken-cd > v3: > * removed new usage of broken-cd > * created fails-without-test-cd device property > * created arasan controller specific quirk > v4: > * changed fails-without-test-cd to xlnx-fails-without-test-cd > * removed extra blank line > v5: > * Fixed style mistake > * Changed (1 << 0 ) to BIT(0) > v6: > * Fixed style mistakes > * Condensed unnecessarily long variable names > * Removed line wraps that were no longer necessary. > * Rebased changes off Ulf's mmc tree's next branch. > v7: > * Removed erroneous re-creation of Optional Properties section > * Changed xlnx-fails-without-test-cd to xlnx,fails-without-test-cd > * Changed of_get_property to of_property_read_bool > > > Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > index 3404afa..49df630 100644 > --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > @@ -36,6 +36,9 @@ Optional Properties: > - #clock-cells: If specified this should be the value <0>. With this property > in place we will export a clock representing the Card Clock. This clock > is expected to be consumed by our PHY. You must also specify > + - xlnx,fails-without-test-cd: when present, the controller doesn't work when > + the CD line is not connected properly, and the line is not connected > + properly. Test mode can be used to force the controller to function. > > Example: > sdhci@e0100000 { > -- > 2.7.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt index 3404afa..49df630 100644 --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt @@ -36,6 +36,9 @@ Optional Properties: - #clock-cells: If specified this should be the value <0>. With this property in place we will export a clock representing the Card Clock. This clock is expected to be consumed by our PHY. You must also specify + - xlnx,fails-without-test-cd: when present, the controller doesn't work when + the CD line is not connected properly, and the line is not connected + properly. Test mode can be used to force the controller to function. Example: sdhci@e0100000 {
The sdhci controller on xilinx zynq devices will not function unless the CD bit is provided. http://www.xilinx.com/support/answers/61064.html In cases where it is impossible to provide the CD bit in hardware, setting the controller to test mode and then setting inserted to true will get the controller to function without the CD bit. The device property "xlnx,fails-without-test-cd" will let the arasan driver know the controller does not have the CD line wired and that the controller does not function without it. Signed-off-by: Zach Brown <zach.brown@ni.com> --- v2: * improved commit messages * removed fake-cd device property * removed fake-cd quirk * use broken-cd device property * documented new usage of broken-cd v3: * removed new usage of broken-cd * created fails-without-test-cd device property * created arasan controller specific quirk v4: * changed fails-without-test-cd to xlnx-fails-without-test-cd * removed extra blank line v5: * Fixed style mistake * Changed (1 << 0 ) to BIT(0) v6: * Fixed style mistakes * Condensed unnecessarily long variable names * Removed line wraps that were no longer necessary. * Rebased changes off Ulf's mmc tree's next branch. v7: * Removed erroneous re-creation of Optional Properties section * Changed xlnx-fails-without-test-cd to xlnx,fails-without-test-cd * Changed of_get_property to of_property_read_bool Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 3 +++ 1 file changed, 3 insertions(+)