From patchwork Thu Oct 13 11:37:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 9374867 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 93E7F60487 for ; Thu, 13 Oct 2016 11:39:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8340E29F29 for ; Thu, 13 Oct 2016 11:39:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7547829FF9; Thu, 13 Oct 2016 11:39:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A6E6929F29 for ; Thu, 13 Oct 2016 11:39:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755119AbcJMLi7 (ORCPT ); Thu, 13 Oct 2016 07:38:59 -0400 Received: from mail-lf0-f41.google.com ([209.85.215.41]:33499 "EHLO mail-lf0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754421AbcJMLia (ORCPT ); Thu, 13 Oct 2016 07:38:30 -0400 Received: by mail-lf0-f41.google.com with SMTP id x79so135046669lff.0 for ; Thu, 13 Oct 2016 04:37:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=GtVKImNmQzthXsD+8ldvS8T+ckjJOV7JL6mbQsyvUcw=; b=C7AsbLlnP24/NKW+Z69UCWJlPj1Qh+zAJGN4VVfTPQkgd9NjI6vzJt53sq4yo1e4wi B2WlIKyNUNaBgECyQplpXJdejtIHK6WduuEx+kIT8XafevjfrrIdaS9GoBEyKYG3v9r6 cIHR28p2ODotrsEtDsiZySoKQu5uUcSRK0LYs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=GtVKImNmQzthXsD+8ldvS8T+ckjJOV7JL6mbQsyvUcw=; b=KkH6YRO9J7+yN04ObmZTRmX//qNe7P+llaIadyC2Opgev3igYORu7M21n796T+npgB 57IEqsb/vn/3Shw7Q/yrd3Sk27YZ/HNXkWI+VG3BSK2CUwQY8KAZ+zOkpOpa+p/nX0f6 NGS1yBue5uAVp2DSLrIRYE+5sHOZQPlBsqTT2kHgpbwucBslTvfD4nnCVycnwEE21tWQ GvIvW+YyxZ92NdX5N3BTuw+0xnLEt+xg4GrkMYDXVMB9zQZ1T+KZsjt/FTTIOoZ7r3Zx Ai3cLyOMYfMIW4vVe1J1T9sQwLMcOoXvnRDLwA5NaemcK7ABhDH2UyB0Nqp36A1MwV3G 1Gwg== X-Gm-Message-State: AA6/9Rn9gUoldaOC1YBsjwjeXBw3R7pr6OuVCCIH72R1mwm4kz2+7sOg4BHmFqrJwd70Y1/7 X-Received: by 10.25.160.21 with SMTP id j21mr9247082lfe.149.1476358677663; Thu, 13 Oct 2016 04:37:57 -0700 (PDT) Received: from localhost.localdomain (h-155-4-221-67.na.cust.bahnhof.se. [155.4.221.67]) by smtp.gmail.com with ESMTPSA id p76sm3648114lfd.11.2016.10.13.04.37.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 13 Oct 2016 04:37:56 -0700 (PDT) From: Ulf Hansson To: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Ulf Hansson Cc: Ritesh Raj Sarraf , Alan Stern , Oliver Neukum , USB list , Roger Tseng , Wei WANG , Subject: [PATCH 3/6] memstick: rtsx_usb_ms: Runtime resume the device when polling for cards Date: Thu, 13 Oct 2016 13:37:37 +0200 Message-Id: <1476358660-8338-4-git-send-email-ulf.hansson@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1476358660-8338-1-git-send-email-ulf.hansson@linaro.org> References: <1476358660-8338-1-git-send-email-ulf.hansson@linaro.org> Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Alan Stern Accesses to the rtsx usb device, which is the parent of the rtsx memstick device, must not be done unless it's runtime resumed. Therefore when the rtsx_usb_ms driver polls for inserted memstick cards, let's add pm_runtime_get|put*() to make sure accesses is done when the rtsx usb device is runtime resumed. Reported-by: Ritesh Raj Sarraf Tested-by: Ritesh Raj Sarraf Signed-off-by: Alan Stern Cc: Signed-off-by: Ulf Hansson --- drivers/memstick/host/rtsx_usb_ms.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/memstick/host/rtsx_usb_ms.c b/drivers/memstick/host/rtsx_usb_ms.c index d34bc35..1b99489 100644 --- a/drivers/memstick/host/rtsx_usb_ms.c +++ b/drivers/memstick/host/rtsx_usb_ms.c @@ -681,6 +681,7 @@ static int rtsx_usb_detect_ms_card(void *__host) int err; for (;;) { + pm_runtime_get_sync(ms_dev(host)); mutex_lock(&ucr->dev_mutex); /* Check pending MS card changes */ @@ -703,6 +704,7 @@ static int rtsx_usb_detect_ms_card(void *__host) } poll_again: + pm_runtime_put(ms_dev(host)); if (host->eject) break;