From patchwork Mon Jan 30 04:48:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: shailendra.v@samsung.com X-Patchwork-Id: 9544423 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7BDB7604A8 for ; Mon, 30 Jan 2017 04:48:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6D95E26E49 for ; Mon, 30 Jan 2017 04:48:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6138A2833A; Mon, 30 Jan 2017 04:48:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0EE7526E35 for ; Mon, 30 Jan 2017 04:48:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752058AbdA3Esl (ORCPT ); Sun, 29 Jan 2017 23:48:41 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:52244 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751921AbdA3Esk (ORCPT ); Sun, 29 Jan 2017 23:48:40 -0500 Received: from epcas1p4.samsung.com (unknown [182.195.41.48]) by mailout4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OKK0187YTD2ED60@mailout4.samsung.com>; Mon, 30 Jan 2017 13:48:38 +0900 (KST) Received: from epsmges1p5.samsung.com (unknown [182.195.42.57]) by epcas1p2.samsung.com (KnoxPortal) with ESMTP id 20170130044838epcas1p2e6425ea970032ec23259f8196e649075~ec1EBmDxR0524605246epcas1p2E; Mon, 30 Jan 2017 04:48:38 +0000 (GMT) Received: from epcas1p1.samsung.com ( [182.195.41.45]) by epsmges1p5.samsung.com (Symantec Messaging Gateway) with SMTP id A5.2A.06732.6A5CE885; Mon, 30 Jan 2017 13:48:38 +0900 (KST) Received: from epsmgmsp01.samsung.com (unknown [182.195.34.22]) by epcas1p4.samsung.com (KnoxPortal) with ESMTP id 20170130044838epcas1p43a1c58ae970b39909cfb67b2aa619a88~ec1DaEe6L1237012370epcas1p4S; Mon, 30 Jan 2017 04:48:38 +0000 (GMT) X-AuditID: b6c32a39-f79c86d000001a4c-d4-588ec5a69878 Received: from srin.p4 (Unknown_Domain [107.108.168.37]) by epsmgmsp01.samsung.com (EPCPMTA) with SMTP id 6B.54.04803.3A5CE885; Mon, 30 Jan 2017 13:48:38 +0900 (KST) From: Shailendra Verma To: Ulf Hansson , Fabio Estevam , Marek Vasut , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, p.shailesh@samsung.com, ashish.kalra@samsung.com, Shailendra Verma , Shailendra Verma Subject: [PATCH] Mmc: host - Fix possible NULL derefrence. Date: Mon, 30 Jan 2017 10:18:18 +0530 Message-id: <1485751698-29036-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrMIsWRmVeSWpSXmKPExsWy7bCmru6yo30RBoeuGFjcn/aN3WLj5tss Fpd3zWGzOPK/n9HiTVsjo8WOKa0sFrfmzWSzWPTtFbPF8bXhDpwe82adYPHYOesuu8eda3vY PDa+28Hk0bdlFaPH501yAWxRXDYpqTmZZalF+nYJXBknXjxmLHjIWvFr4XO2BsY7LF2MnBwS AiYSP55egLLFJC7cW8/WxcjFISSwg1Gi53AHlPOZUeLB4QXsMB2nfu5jgkisZJSYfXsFWDub gKHE676/YAkRgYNMErvX7ANq5+AQFrCSeLRVCKSGRUBVYuWTvcwgNq+Ah8TJoz9YQEokBBQk 5kyyAWmVELjNJrF8fg8jRFxWYtMBZgjTReLwwiCIE4QlXh3fAnWOlETzxw+sEK3HGCUeP1/M BOFcZpTYcnoZVJW9xLVbr8FsZgE+iXdfe1ghhvJKdLQJQZR4SDy/fIoRwnaU2HDoBtiZQgKx EnMWPmWawCi5gJFhFaNYakFxbnpqsWGBqV5xYm5xaV66XnJ+7iZGcFRqWe5gPHbO5xCjAAej Eg/vDeG+CCHWxLLiytxDjBIczEoivOU7gUK8KYmVValF+fFFpTmpxYcYpTlYlMR5FzdaRwgJ pCeWpGanphakFsFkmTg4pRoYmfgk3TnPTPlp22SirH7pltfWxfOLF7j7zz0TvGvpgR+T+oOU lFziw5MWR0vmadisyDTZYBo5eXZX9zwt5g3LEzWqj4c5PX4R2OIvt7r83bw5ndEXPp1h3O5k ZnOLd171AqlElR32hzgrj+w//onzfpxycdQCz4jpdmp8bfVlJmqzwnlXNUxSYinOSDTUYi4q TgQAcpzEH8YCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOLMWRmVeSWpSXmKPExsWSnbNCVXfZ0b4Ig4NnOCzuT/vGbrFx820W i8u75rBZHPnfz2jxpq2R0WLHlFYWi1vzZrJZLPr2itni+NpwB06PebNOsHjsnHWX3ePOtT1s Hhvf7WDy6NuyitHj8ya5ALYoN5uM1MSU1CKF1Lzk/JTMvHRbpdAQN10LJYW8xNxUW6UIXd+Q ICWFssScUiDPyAANODgHuAcr6dsluGWcePGYseAha8Wvhc/ZGhjvsHQxcnJICJhInPq5jwnC FpO4cG89WxcjF4eQwHJGiY3bDrCDJNgEDCVe9/1lAkmICBxnkli8qQcowcEhLGAl8WirEEgN i4CqxMone5lBbF4BD4mTR3+wgJRICChIzJlkM4GRcwEjwypGsdSC4tz03OICA0O94sTc4tK8 dL3k/NxNjMBA3HZYSWwHY9sKr0OMAhyMSjy8Bmv6IoRYE8uKK3MPMUpwMCuJ8JbvBArxpiRW VqUW5ccXleakFh9iNAXaPpFZSjQ5HxgleSXxhiamFhYWJpbGxsYWJkrivLHTn4ULCaQnlqRm p6YWpBbB9DFxcEo1MLa+ffRCVnjKl5PV9le+Z7I3VYip7frMcJGrc7P+o886m+6deLRswvYD L5g+rtyv/7Z/TthNfoVzHc6tK73KihMzXxuH1S1cv+5upseD+uhzYVkZ3Nwzig9trpHbvFHu +GQzweiAY22f1ZeLsizyO8SZ5x6XqsAd3b/nVoKi6XSf/B/KGy/uO67EUpyRaKjFXFScCAAx 56cfWgIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170130044838epcas1p43a1c58ae970b39909cfb67b2aa619a88 X-Msg-Generator: CA X-Sender-IP: 182.195.34.22 X-Local-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAb7IK87ISx7KCE7J6QG0xlYWQgRW5n?= =?UTF-8?B?aW5lZXIvQ29ycG9yYXRlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAbU2Ftc3VuZyBFbGVjdHJvbmljcxtM?= =?UTF-8?B?ZWFkIEVuZ2luZWVyL0NvcnBvcmF0ZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElaMDFJWjAxODEyMA==?= CMS-TYPE: 101P X-HopCount: 7 X-CMS-RootMailID: 20170130044838epcas1p43a1c58ae970b39909cfb67b2aa619a88 X-RootMTR: 20170130044838epcas1p43a1c58ae970b39909cfb67b2aa619a88 References: Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP of_match_device could return NULL, and so can cause a NULL pointer dereference later. Signed-off-by: Shailendra Verma --- drivers/mmc/host/mxs-mmc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c index 44ecebd..d12a5b7 100644 --- a/drivers/mmc/host/mxs-mmc.c +++ b/drivers/mmc/host/mxs-mmc.c @@ -581,6 +581,11 @@ static int mxs_mmc_probe(struct platform_device *pdev) struct regulator *reg_vmmc; struct mxs_ssp *ssp; + if (!of_id) { + dev_err(&pdev->dev, "Error: No device match found\n"); + return -ENODEV; + } + irq_err = platform_get_irq(pdev, 0); if (irq_err < 0) return irq_err;