From patchwork Sat Sep 9 23:44:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Fritz X-Patchwork-Id: 9946125 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A0919600CB for ; Sat, 9 Sep 2017 23:45:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 91A6728A45 for ; Sat, 9 Sep 2017 23:45:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 84EBD28A4A; Sat, 9 Sep 2017 23:45:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 21AC728A45 for ; Sat, 9 Sep 2017 23:45:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751196AbdIIXox (ORCPT ); Sat, 9 Sep 2017 19:44:53 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:37609 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751667AbdIIXot (ORCPT ); Sat, 9 Sep 2017 19:44:49 -0400 Received: by mail-wr0-f195.google.com with SMTP id u48so2769797wrf.4 for ; Sat, 09 Sep 2017 16:44:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=message-id:subject:from:reply-to:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=MRjHNJhOzjW37k/bYo3R7y0md7425qkcnqr17hkM8aY=; b=Szxx8GRpRag8YxrPErYmGmSgZKOZMbnNZeaL35qUMDaBNQIArFP7OIFfiFxElzQlmJ NXie1OomzbWF2t7TqqHOz7sMmz/MMk5mXYO6dT88kI0IT7G9kyaZWhQ+avjOuURS+9Ff BjOJGgFLMmOqdna39qzTzqSl8oAgkxvL+eOsiJpzZSiSrkDSeNi+q22nj5vZiszei95E izW3QC4IYNXlO/n18EZDxY8E+IpXEazglrnTO/1nCLCqIV+J6RhWKwCBd23wyX2XvcPQ t/I+IGbuWJruV3pahmuyNU+JqfUanMdROqWJ8wtThySjRKt8EMDTTocLaNFfps3at2qf 3dbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:reply-to:to:cc:date :in-reply-to:references:mime-version:content-transfer-encoding; bh=MRjHNJhOzjW37k/bYo3R7y0md7425qkcnqr17hkM8aY=; b=b7L3Ob9+8yq4YbyQrVhQyKIIO2rp8f+exzd5bbIcNNNJiwoQ1Qx/q1LXbA/yUVOA+z iCAwdIxswYIThKUypI2IZqUfEh3bpkZtELROiukcfQd3ud+No2CAmeAbNCJCqVq8Ilx9 9/Amjw7C5NjhDcVTuXdOglMl4dNFoCMCNcGdoE9eYwE/6Dy+B+3FmWyA5ripEboVqM0J rxI6MAWcW4yq2RvQ5/UV4e/1QZDSGniyC1IqqtTMmiI8eNO7JgDzuq4t4qYwNHMnXEcr m5QqKbuDlgycd/iUUnXus84v2co5lRhPwgsjvZkIHAOmpxiTB85KSKdN87zR7fwCX81n y1EQ== X-Gm-Message-State: AHPjjUhxspZ1FIkBeaEr0YhzPh2qTTJor3QJfg2NVKi3MDudpnege4BZ 7KUeeoPXfyx1jg== X-Google-Smtp-Source: ADKCNb7zQSo2ShBzSGygbbL96nyshukA77jac0+ln5anrMn3xGkFx4QjZZjERWu/2HeYGJ3NiKhXRA== X-Received: by 10.223.174.194 with SMTP id y60mr5405746wrc.105.1505000688389; Sat, 09 Sep 2017 16:44:48 -0700 (PDT) Received: from mars.fritz.box (HSI-KBW-109-193-021-110.hsi7.kabel-badenwuerttemberg.de. [109.193.21.110]) by smtp.gmail.com with ESMTPSA id a19sm8944049wra.64.2017.09.09.16.44.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 09 Sep 2017 16:44:47 -0700 (PDT) Message-ID: <1505000687.23171.20.camel@googlemail.com> Subject: [PATCH v2] mmc: core: apply NO_CMD23 quirk to an ATP card From: Christoph Fritz Reply-To: chf.fritz@googlemail.com To: Ulf Hansson Cc: linux-mmc Date: Sun, 10 Sep 2017 01:44:47 +0200 In-Reply-To: <1504998772.4004.2.camel@googlemail.com> References: <1504998772.4004.2.camel@googlemail.com> X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP To get an ATP card work reliable on a high speed bus, CMD23 needs to be disabled. Without this patch: $ dd if=/dev/urandom of=/mnt/test bs=1M count=10 mmc0: starting CMD25 arg 00a71f00 flags 000000b5 mmc0: blksz 512 blocks 1024 flags 00000100 tsac 3000 ms nsac 0 mmc0: CMD12 arg 00000000 flags 0000049d sdhci [sdhci_irq()]: *** mmc0 got interrupt: 0x00000001 mmc0: Timeout waiting for hardware interrupt. Signed-off-by: Christoph Fritz --- Changes since v1: - s/CMD32/CMD23 drivers/mmc/core/card.h | 1 + drivers/mmc/core/quirks.h | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/drivers/mmc/core/card.h b/drivers/mmc/core/card.h index f06cd91..af9c48c 100644 --- a/drivers/mmc/core/card.h +++ b/drivers/mmc/core/card.h @@ -75,6 +75,7 @@ struct mmc_fixup { #define EXT_CSD_REV_ANY (-1u) #define CID_MANFID_SANDISK 0x2 +#define CID_MANFID_ATP 0x9 #define CID_MANFID_TOSHIBA 0x11 #define CID_MANFID_MICRON 0x13 #define CID_MANFID_SAMSUNG 0x15 diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h index fb72593..3205f0e 100644 --- a/drivers/mmc/core/quirks.h +++ b/drivers/mmc/core/quirks.h @@ -52,6 +52,12 @@ static const struct mmc_fixup mmc_blk_fixups[] = { MMC_QUIRK_BLK_NO_CMD23), /* + * Some SD cards lockup while using CMD23 multiblock transfers. + */ + MMC_FIXUP("AF SD", CID_MANFID_ATP, CID_OEMID_ANY, add_quirk_sd, + MMC_QUIRK_BLK_NO_CMD23), + + /* * Some MMC cards need longer data read timeout than indicated in CSD. */ MMC_FIXUP(CID_NAME_ANY, CID_MANFID_MICRON, 0x200, add_quirk_mmc,