From patchwork Thu Jan 4 15:30:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Nazzareno Trimarchi X-Patchwork-Id: 10144977 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 85103601A1 for ; Thu, 4 Jan 2018 15:31:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7749728569 for ; Thu, 4 Jan 2018 15:31:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7628C287C2; Thu, 4 Jan 2018 15:31:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_WEB, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DF4E5287AB for ; Thu, 4 Jan 2018 15:31:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753256AbeADPbE (ORCPT ); Thu, 4 Jan 2018 10:31:04 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36655 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753251AbeADPbD (ORCPT ); Thu, 4 Jan 2018 10:31:03 -0500 Received: by mail-wm0-f65.google.com with SMTP id b76so4149502wmg.1 for ; Thu, 04 Jan 2018 07:31:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=2P7+zXU5BopwecZjXYlsqH01ILIawd/UgxE/o5b/gro=; b=JGQYVB6CQGH3/q+v5R7kCt5Iupqz8+uVoDgzm59DV+5P43MZsNSfUBIZVzqUE63qHa d4SOPcwKHVZk1mvZflUViYgd4RqwkOBAmFjIDZDu3kPs58ESwSoL+pzImkOPs0lt50PT Ge2wF/aNzKAEygY1i6pKIoOzYtCwfQUmjB7fCc8Hbo2dYneFFz/KHCZaVeLyF3LlWWzC f2TfwaEB+IBFFA/4YHb1wFkHMQwCYv1bvtpXeaduhXcDhYlTo3q0XnxDffRZ52Lh9Ql4 k95uCeM7URSG4ZsV4SJ0n780WgtG3FGCVYpmzs052KX2eplUaypZe6t3X1xkAt0sa881 nLIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=2P7+zXU5BopwecZjXYlsqH01ILIawd/UgxE/o5b/gro=; b=BtLgOW7dxkqvuwcIsGZpJ1k6DJ4+AIVsV20vJ155f64G4WrUaPUnsIqbB3EmVIs9AA d4mgjfqJThWhrUkdjox75pyCERKYK50gAz4USck2irTBVyWhD4M3LlDig8hZCdqDM398 Cr1ty7ZLlRhYTjagLqUdlPvkEb5LiII2y4gnYF53JqNQCIUamW67IVeJgMT44bSrH49k EYrBSELj4QpgQl5yT+GVe75AW7rJrHao5Kt7Ucaal3vdwRLDgdmwJ5lE9z3NYEpAWuEp 27/XyAeaSTDYdc8Wn1IFKFXH+CDRpn9Vl0bLKJCN7RXmLUQr9BlnaiwSlJnjqKCJ5HtP Ikig== X-Gm-Message-State: AKGB3mKqZuPG6g5pH0I65LObOBRknrqmMawfAQsNuZ7ttf+s8lnNNgcn 4HYCSsTSI5MJJVhmmooA39Md1Q== X-Google-Smtp-Source: ACJfBos14wGxjt8EpCtyEAbCcEoEobAiyiskLcZXs6FseOfCchUM0EVQ1CtFyUgOKjyqYTj4WSw6Fw== X-Received: by 10.28.68.65 with SMTP id r62mr4737099wma.42.1515079862300; Thu, 04 Jan 2018 07:31:02 -0800 (PST) Received: from localhost.localdomain ([5.170.79.192]) by smtp.gmail.com with ESMTPSA id b48sm9482358wrb.1.2018.01.04.07.31.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 04 Jan 2018 07:31:01 -0800 (PST) From: Michael Trimarchi To: Ulf Hansson Cc: Michael Trimarchi , linux-mmc@vger.kernel.org, Adrian Hunter Subject: [PATCH V2 1/3] mmc: sdhci-esdhc-imx: Manage sdhci_runtime_suspend_host error code Date: Thu, 4 Jan 2018 16:30:57 +0100 Message-Id: <1515079859-18401-1-git-send-email-michael@amarulasolutions.com> X-Mailer: git-send-email 2.7.4 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We need to return in case of error even if the actual implementation of sdhci_runtime_suspend_host always return 0. We don't want to power down the clock and the assuption is that the sdhci_runtime_suspend_host always let the system consistent in case of failure Signed-off-by: Michael Trimarchi --- Changes None --- drivers/mmc/host/sdhci-esdhc-imx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c index 85140c9..d08c21e 100644 --- a/drivers/mmc/host/sdhci-esdhc-imx.c +++ b/drivers/mmc/host/sdhci-esdhc-imx.c @@ -1389,6 +1389,8 @@ static int sdhci_esdhc_runtime_suspend(struct device *dev) int ret; ret = sdhci_runtime_suspend_host(host); + if (ret) + return ret; if (host->tuning_mode != SDHCI_TUNING_MODE_3) mmc_retune_needed(host->mmc);