| Message ID | 1522889541-35504-1-git-send-email-shawn.lin@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 5 April 2018 at 02:52, Shawn Lin <shawn.lin@rock-chips.com> wrote: > DDR52 with 8-bit mode should be handled in a different way when > requesting ciu_clk. However DDR50 is used for SDMMC/SDIO and > could never be possible with 8-bit mode. It's trival but misleading. > > Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> > --- > > drivers/mmc/host/dw_mmc-rockchip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c > index 40d7de2..3fe4b9d 100644 > --- a/drivers/mmc/host/dw_mmc-rockchip.c > +++ b/drivers/mmc/host/dw_mmc-rockchip.c > @@ -45,7 +45,7 @@ static void dw_mci_rk3288_set_ios(struct dw_mci *host, struct mmc_ios *ios) > * ios->clock = (div == 0) ? bus_hz : (bus_hz / (2 * div)) > * > * Note: div can only be 0 or 1 > - * if DDR50 8bit mode(only emmc work in 8bit mode), > + * if DDR52 8bit mode(only emmc work in 8bit mode), how about "eMMC DDR52 8-bit mode." > * div must be set 1 > */ > if (ios->bus_width == MMC_BUS_WIDTH_8 && > -- > 1.9.1 > Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2018/4/5 14:33, Ulf Hansson wrote:
> eMMC DDR52 8-bit mode
Sure, and just send v2 now, thanks. :)
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c index 40d7de2..3fe4b9d 100644 --- a/drivers/mmc/host/dw_mmc-rockchip.c +++ b/drivers/mmc/host/dw_mmc-rockchip.c @@ -45,7 +45,7 @@ static void dw_mci_rk3288_set_ios(struct dw_mci *host, struct mmc_ios *ios) * ios->clock = (div == 0) ? bus_hz : (bus_hz / (2 * div)) * * Note: div can only be 0 or 1 - * if DDR50 8bit mode(only emmc work in 8bit mode), + * if DDR52 8bit mode(only emmc work in 8bit mode), * div must be set 1 */ if (ios->bus_width == MMC_BUS_WIDTH_8 &&
DDR52 with 8-bit mode should be handled in a different way when requesting ciu_clk. However DDR50 is used for SDMMC/SDIO and could never be possible with 8-bit mode. It's trival but misleading. Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> --- drivers/mmc/host/dw_mmc-rockchip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)