diff mbox series

mmc: sdhci-pci: Make function amd_sdhci_reset static

Message ID 1570182260-135818-1-git-send-email-zhengbin13@huawei.com (mailing list archive)
State New, archived
Headers show
Series mmc: sdhci-pci: Make function amd_sdhci_reset static | expand

Commit Message

Zheng Bin Oct. 4, 2019, 9:44 a.m. UTC 
Fix sparse warnings:

drivers/mmc/host/sdhci-pci-core.c:1599:6: warning: symbol 'amd_sdhci_reset' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/mmc/host/sdhci-pci-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.7.4

Comments

Adrian Hunter Oct. 4, 2019, 10:02 a.m. UTC | #1 
On 4/10/19 12:44 PM, zhengbin wrote:
> Fix sparse warnings:
> 
> drivers/mmc/host/sdhci-pci-core.c:1599:6: warning: symbol 'amd_sdhci_reset' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
>  drivers/mmc/host/sdhci-pci-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
> index 659878a..de50e1d 100644
> --- a/drivers/mmc/host/sdhci-pci-core.c
> +++ b/drivers/mmc/host/sdhci-pci-core.c
> @@ -1596,7 +1596,7 @@ static u32 sdhci_read_present_state(struct sdhci_host *host)
>  	return sdhci_readl(host, SDHCI_PRESENT_STATE);
>  }
> 
> -void amd_sdhci_reset(struct sdhci_host *host, u8 mask)
> +static void amd_sdhci_reset(struct sdhci_host *host, u8 mask)
>  {
>  	struct sdhci_pci_slot *slot = sdhci_priv(host);
>  	struct pci_dev *pdev = slot->chip->pdev;
> --
> 2.7.4
> 
>
Ulf Hansson Oct. 9, 2019, 9:12 a.m. UTC | #2 
On Fri, 4 Oct 2019 at 11:37, zhengbin <zhengbin13@huawei.com> wrote:
>
> Fix sparse warnings:
>
> drivers/mmc/host/sdhci-pci-core.c:1599:6: warning: symbol 'amd_sdhci_reset' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci-pci-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
> index 659878a..de50e1d 100644
> --- a/drivers/mmc/host/sdhci-pci-core.c
> +++ b/drivers/mmc/host/sdhci-pci-core.c
> @@ -1596,7 +1596,7 @@ static u32 sdhci_read_present_state(struct sdhci_host *host)
>         return sdhci_readl(host, SDHCI_PRESENT_STATE);
>  }
>
> -void amd_sdhci_reset(struct sdhci_host *host, u8 mask)
> +static void amd_sdhci_reset(struct sdhci_host *host, u8 mask)
>  {
>         struct sdhci_pci_slot *slot = sdhci_priv(host);
>         struct pci_dev *pdev = slot->chip->pdev;
> --
> 2.7.4
>
diff mbox series

Patch

diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
index 659878a..de50e1d 100644
--- a/drivers/mmc/host/sdhci-pci-core.c
+++ b/drivers/mmc/host/sdhci-pci-core.c
@@ -1596,7 +1596,7 @@  static u32 sdhci_read_present_state(struct sdhci_host *host)
 	return sdhci_readl(host, SDHCI_PRESENT_STATE);
 }

-void amd_sdhci_reset(struct sdhci_host *host, u8 mask)
+static void amd_sdhci_reset(struct sdhci_host *host, u8 mask)
 {
 	struct sdhci_pci_slot *slot = sdhci_priv(host);
 	struct pci_dev *pdev = slot->chip->pdev;