| Message ID | 1598265914-23606-1-git-send-email-haibo.chen@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mmc: host: sdhci-esdhc-imx: remove unused code | expand |
On 24/08/20 1:45 pm, haibo.chen@nxp.com wrote: > From: Haibo Chen <haibo.chen@nxp.com> > > Value assigned to a variable(err) is never used, so remove it > > Signed-off-by: Haibo Chen <haibo.chen@nxp.com> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > --- > drivers/mmc/host/sdhci-esdhc-imx.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c > index 3d6eaf490d4a..3d2615eb7d56 100644 > --- a/drivers/mmc/host/sdhci-esdhc-imx.c > +++ b/drivers/mmc/host/sdhci-esdhc-imx.c > @@ -1673,10 +1673,8 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev) > goto disable_ipg_clk; > > imx_data->pinctrl = devm_pinctrl_get(&pdev->dev); > - if (IS_ERR(imx_data->pinctrl)) { > - err = PTR_ERR(imx_data->pinctrl); > + if (IS_ERR(imx_data->pinctrl)) > dev_warn(mmc_dev(host->mmc), "could not get pinctrl\n"); > - } > > if (esdhc_is_usdhc(imx_data)) { > host->quirks2 |= SDHCI_QUIRK2_PRESET_VALUE_BROKEN; >
On Mon, 24 Aug 2020 at 12:51, <haibo.chen@nxp.com> wrote: > > From: Haibo Chen <haibo.chen@nxp.com> > > Value assigned to a variable(err) is never used, so remove it > > Signed-off-by: Haibo Chen <haibo.chen@nxp.com> Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-esdhc-imx.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c > index 3d6eaf490d4a..3d2615eb7d56 100644 > --- a/drivers/mmc/host/sdhci-esdhc-imx.c > +++ b/drivers/mmc/host/sdhci-esdhc-imx.c > @@ -1673,10 +1673,8 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev) > goto disable_ipg_clk; > > imx_data->pinctrl = devm_pinctrl_get(&pdev->dev); > - if (IS_ERR(imx_data->pinctrl)) { > - err = PTR_ERR(imx_data->pinctrl); > + if (IS_ERR(imx_data->pinctrl)) > dev_warn(mmc_dev(host->mmc), "could not get pinctrl\n"); > - } > > if (esdhc_is_usdhc(imx_data)) { > host->quirks2 |= SDHCI_QUIRK2_PRESET_VALUE_BROKEN; > -- > 2.17.1 >
diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c index 3d6eaf490d4a..3d2615eb7d56 100644 --- a/drivers/mmc/host/sdhci-esdhc-imx.c +++ b/drivers/mmc/host/sdhci-esdhc-imx.c @@ -1673,10 +1673,8 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev) goto disable_ipg_clk; imx_data->pinctrl = devm_pinctrl_get(&pdev->dev); - if (IS_ERR(imx_data->pinctrl)) { - err = PTR_ERR(imx_data->pinctrl); + if (IS_ERR(imx_data->pinctrl)) dev_warn(mmc_dev(host->mmc), "could not get pinctrl\n"); - } if (esdhc_is_usdhc(imx_data)) { host->quirks2 |= SDHCI_QUIRK2_PRESET_VALUE_BROKEN;