| Message ID | 1604654730-29914-1-git-send-email-yoshihiro.shimoda.uh@renesas.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mmc: host: renesas_sdhi_core: Missing tmio_mmc_host_free() in renesas_sdhi_remove() | expand |
On Fri, Nov 06, 2020 at 06:25:30PM +0900, Yoshihiro Shimoda wrote: > The commit 94b110aff867 ("mmc: tmio: add tmio_mmc_host_alloc/free()") > added tmio_mmc_host_free(), but missed the function calling in > the sh_mobile_sdhi_remove() at that time. So, fix it. Otherwise, > we cannot rebind the sdhi/mmc devices when we use aliases of mmc. > > Fixes: 94b110aff867 ("mmc: tmio: add tmio_mmc_host_alloc/free()") > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Tested on my Salvator-XS (R-Car M3-N): Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Hi Shimoda-san, Thanks for your patch. On 2020-11-06 18:25:30 +0900, Yoshihiro Shimoda wrote: > The commit 94b110aff867 ("mmc: tmio: add tmio_mmc_host_alloc/free()") > added tmio_mmc_host_free(), but missed the function calling in > the sh_mobile_sdhi_remove() at that time. So, fix it. Otherwise, > we cannot rebind the sdhi/mmc devices when we use aliases of mmc. > > Fixes: 94b110aff867 ("mmc: tmio: add tmio_mmc_host_alloc/free()") > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > drivers/mmc/host/renesas_sdhi_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c > index 4143141..03c905a 100644 > --- a/drivers/mmc/host/renesas_sdhi_core.c > +++ b/drivers/mmc/host/renesas_sdhi_core.c > @@ -1160,6 +1160,7 @@ int renesas_sdhi_remove(struct platform_device *pdev) > > tmio_mmc_host_remove(host); > renesas_sdhi_clk_disable(host); > + tmio_mmc_host_free(host); > > return 0; > } > -- > 2.7.4 >
On Fri, 6 Nov 2020 at 10:25, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: > > The commit 94b110aff867 ("mmc: tmio: add tmio_mmc_host_alloc/free()") > added tmio_mmc_host_free(), but missed the function calling in > the sh_mobile_sdhi_remove() at that time. So, fix it. Otherwise, > we cannot rebind the sdhi/mmc devices when we use aliases of mmc. > > Fixes: 94b110aff867 ("mmc: tmio: add tmio_mmc_host_alloc/free()") > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Applied for fixes and by adding a stable tag, thanks! Kind regards Uffe > --- > drivers/mmc/host/renesas_sdhi_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c > index 4143141..03c905a 100644 > --- a/drivers/mmc/host/renesas_sdhi_core.c > +++ b/drivers/mmc/host/renesas_sdhi_core.c > @@ -1160,6 +1160,7 @@ int renesas_sdhi_remove(struct platform_device *pdev) > > tmio_mmc_host_remove(host); > renesas_sdhi_clk_disable(host); > + tmio_mmc_host_free(host); > > return 0; > } > -- > 2.7.4 >
diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c index 4143141..03c905a 100644 --- a/drivers/mmc/host/renesas_sdhi_core.c +++ b/drivers/mmc/host/renesas_sdhi_core.c @@ -1160,6 +1160,7 @@ int renesas_sdhi_remove(struct platform_device *pdev) tmio_mmc_host_remove(host); renesas_sdhi_clk_disable(host); + tmio_mmc_host_free(host); return 0; }
The commit 94b110aff867 ("mmc: tmio: add tmio_mmc_host_alloc/free()") added tmio_mmc_host_free(), but missed the function calling in the sh_mobile_sdhi_remove() at that time. So, fix it. Otherwise, we cannot rebind the sdhi/mmc devices when we use aliases of mmc. Fixes: 94b110aff867 ("mmc: tmio: add tmio_mmc_host_alloc/free()") Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- drivers/mmc/host/renesas_sdhi_core.c | 1 + 1 file changed, 1 insertion(+)