| Message ID | 1A230AD7863570458C6CF2BE7CD6618B102BE5CB@SHSMSX102.ccr.corp.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
May be it is worth to change all this struct comments to be: u8 raw_exception_status; /* EXT_CSD_EXP_EVENTS_STATUS */ This will reference actual offset value from "include/linux/mmc/mmc.h" Thanks, On 01/08/2013 08:07 AM, Zhang, YiX X wrote: > From aaea3405944d844f53679b295d4082584f33d9a3 Mon Sep 17 00:00:00 2001 > From: ZhangYi <yix.x.zhang@intel.com> > Date: Tue, 8 Jan 2013 13:50:09 +0800 > Subject: [PATCH] mmc: correct the EXCEPTION_EVENTS_STATUS vaule comment > > The right value is 54 according to eMMC 4.5 specification. > > Signed-off-by: ZhangYi <yix.x.zhang@intel.com> > --- > include/linux/mmc/card.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h > index 5c69315..ffde1d3 100644 > --- a/include/linux/mmc/card.h > +++ b/include/linux/mmc/card.h > @@ -83,7 +83,7 @@ struct mmc_ext_csd { > unsigned int data_tag_unit_size; /* DATA TAG UNIT size */ > unsigned int boot_ro_lock; /* ro lock support */ > bool boot_ro_lockable; > - u8 raw_exception_status; /* 53 */ > + u8 raw_exception_status; /* 54 */ > u8 raw_partition_support; /* 160 */ > u8 raw_rpmb_size_mult; /* 168 */ > u8 raw_erased_mem_count; /* 181 */ >
yes, you are right, I will change them later, thanks. Regards Zhang,Yi. -----Original Message----- From: linux-mmc-owner@vger.kernel.org [mailto:linux-mmc-owner@vger.kernel.org] On Behalf Of Konstantin Dorfman Sent: Tuesday, January 08, 2013 4:23 PM To: Zhang, YiX X Cc: cjb@laptop.org; linux-mmc@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] mmc: correct the EXCEPTION_EVENTS_STATUS vaule comment May be it is worth to change all this struct comments to be: u8 raw_exception_status; /* EXT_CSD_EXP_EVENTS_STATUS */ This will reference actual offset value from "include/linux/mmc/mmc.h" Thanks, On 01/08/2013 08:07 AM, Zhang, YiX X wrote: > From aaea3405944d844f53679b295d4082584f33d9a3 Mon Sep 17 00:00:00 > 2001 > From: ZhangYi <yix.x.zhang@intel.com> > Date: Tue, 8 Jan 2013 13:50:09 +0800 > Subject: [PATCH] mmc: correct the EXCEPTION_EVENTS_STATUS vaule > comment > > The right value is 54 according to eMMC 4.5 specification. > > Signed-off-by: ZhangYi <yix.x.zhang@intel.com> > --- > include/linux/mmc/card.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h index > 5c69315..ffde1d3 100644 > --- a/include/linux/mmc/card.h > +++ b/include/linux/mmc/card.h > @@ -83,7 +83,7 @@ struct mmc_ext_csd { > unsigned int data_tag_unit_size; /* DATA TAG UNIT size */ > unsigned int boot_ro_lock; /* ro lock support */ > bool boot_ro_lockable; > - u8 raw_exception_status; /* 53 */ > + u8 raw_exception_status; /* 54 */ > u8 raw_partition_support; /* 160 */ > u8 raw_rpmb_size_mult; /* 168 */ > u8 raw_erased_mem_count; /* 181 */ > -- Konstantin Dorfman, QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Tue, Jan 08 2013, Konstantin Dorfman wrote: > May be it is worth to change all this struct comments to be: > > u8 raw_exception_status; /* EXT_CSD_EXP_EVENTS_STATUS */ > > This will reference actual offset value from "include/linux/mmc/mmc.h" I think I prefer having the literal numbers accessible, even though it duplicates data, so I've taken Zhang's original patch for now. Thanks, - Chris.
diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h index 5c69315..ffde1d3 100644 --- a/include/linux/mmc/card.h +++ b/include/linux/mmc/card.h @@ -83,7 +83,7 @@ struct mmc_ext_csd { unsigned int data_tag_unit_size; /* DATA TAG UNIT size */ unsigned int boot_ro_lock; /* ro lock support */ bool boot_ro_lockable; - u8 raw_exception_status; /* 53 */ + u8 raw_exception_status; /* 54 */ u8 raw_partition_support; /* 160 */ u8 raw_rpmb_size_mult; /* 168 */ u8 raw_erased_mem_count; /* 181 */