From patchwork Fri Sep 3 23:25:04 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 177912 Return-path: X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on void.printf.net X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.9 tests=RCVD_IN_DNSWL_LOW autolearn=disabled version=3.2.5 Envelope-to: chris@printf.net Delivery-date: Sat, 04 Sep 2010 00:26:23 +0100 Received: from lists.laptop.org ([18.85.2.145] helo=mail.laptop.org) by void.printf.net with esmtp (Exim 4.69) (envelope-from ) id 1OrfeJ-0001Bf-M7 for chris@printf.net; Sat, 04 Sep 2010 00:26:23 +0100 Received: by mail.laptop.org (Postfix) id 988BD23CC5; Fri, 3 Sep 2010 19:26:03 -0400 (EDT) Delivered-To: cjb@laptop.org Received: from spam.laptop.org (spam.laptop.org [18.85.46.23]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.laptop.org (Postfix) with ESMTPS id 440CC23CC2 for ; Fri, 3 Sep 2010 19:26:02 -0400 (EDT) X-ASG-Debug-ID: 1283556376-0b740b6c0002-zHW3sV Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by spam.laptop.org with ESMTP id PAeAfyxOU07Dst1J for ; Fri, 03 Sep 2010 19:26:16 -0400 (EDT) X-Barracuda-Envelope-From: linux-mmc-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754252Ab0ICXZu (ORCPT ); Fri, 3 Sep 2010 19:25:50 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:53566 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754245Ab0ICXZt (ORCPT ); Fri, 3 Sep 2010 19:25:49 -0400 Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id o83NP4kh003974 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 3 Sep 2010 16:25:04 -0700 Received: from akpm.mtv.corp.google.com (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with SMTP id o83NP487018707; Fri, 3 Sep 2010 16:25:04 -0700 Date: Fri, 3 Sep 2010 16:25:04 -0700 From: Andrew Morton To: Chris Ball Cc: Hein_Tibosch , Pierre Ossman , Ben Nizette , Sascha Hauer , Adrian Hunter , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Matt Fleming X-ASG-Orig-Subj: Re: [PATCH v4] mmc: Make ID freq configurable Subject: Re: [PATCH v4] mmc: Make ID freq configurable Message-Id: <20100903162504.e72f91c6.akpm@linux-foundation.org> In-Reply-To: <20100903014757.GA23012@void.printf.net> References: <4C80187D.9000304@yahoo.es> <20100903014757.GA23012@void.printf.net> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.9; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Barracuda-Connect: vger.kernel.org[209.132.180.67] X-Barracuda-Start-Time: 1283556376 X-Barracuda-URL: http://18.85.46.23:8000/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at laptop.org X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=3.5 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=5.5 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.39844 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- --- a/drivers/mmc/core/core.c~mmc-make-id-freq-configurable-checkpatch-fixes +++ a/drivers/mmc/core/core.c @@ -1450,7 +1450,9 @@ void mmc_rescan(struct work_struct *work else host->f_init = host->f_min; - printk ("mmc_rescan: trying %u Hz\n", host->f_init); + pr_info("%s: %s: trying to init card at %u Hz\n", + mmc_hostname(host), __func__, host->f_init); + mmc_power_up(host); sdio_reset(host); mmc_go_idle(host); @@ -1464,7 +1466,10 @@ void mmc_rescan(struct work_struct *work if (!err) { if (mmc_attach_sdio(host, ocr)) { mmc_claim_host(host); - /* try SDMEM (but not MMC) even if SDIO is broken */ + /* + * Try SDMEM (but not MMC) even if SDIO is + * broken. + */ if (mmc_send_app_op_cond(host, 0, &ocr)) goto out_fail;