From patchwork Fri Apr 25 12:49:45 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Russell King - ARM Linux X-Patchwork-Id: 4061801 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 6E8619F271 for ; Fri, 25 Apr 2014 12:50:41 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8B31120268 for ; Fri, 25 Apr 2014 12:50:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A353E20125 for ; Fri, 25 Apr 2014 12:50:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750888AbaDYMuh (ORCPT ); Fri, 25 Apr 2014 08:50:37 -0400 Received: from gw-1.arm.linux.org.uk ([78.32.30.217]:50525 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751196AbaDYMuh (ORCPT ); Fri, 25 Apr 2014 08:50:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=arm.linux.org.uk; s=pandora; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=enicfXsliAqK5JxXA+qAxnBOz2htcbC5Z2lAiXr4u60=; b=JGo+Dxjra4CI5EayIG169RnRCeoY8WqgRxHk+ZK+qbryySsqHjqX/Qu21e+DoTmjH/Ogk5Y4nVQ7EPINhSewqDpz1qsH/VgH8jEHh/aMcmNS3FsnQ1xVLFxX2hnpy+WUrr1IAcC3Yev7jpuJLTnVZRdacjzbLa/J5eWAoYy3gAA=; Received: from n2100.arm.linux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:4f86]:58664) by pandora.arm.linux.org.uk with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.76) (envelope-from ) id 1WdfaK-0002L9-PN; Fri, 25 Apr 2014 13:50:32 +0100 Received: from linux by n2100.arm.linux.org.uk with local (Exim 4.76) (envelope-from ) id 1WdfZZ-0003lR-MX; Fri, 25 Apr 2014 13:49:45 +0100 Date: Fri, 25 Apr 2014 13:49:45 +0100 From: Russell King - ARM Linux To: Markus Pargmann Cc: Chris Ball , linux-mmc@vger.kernel.org, Ulf Hansson , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 21/38] mmc: sdhci: hack up driver to make it more compliant with UHS-1 Message-ID: <20140425124945.GM26756@n2100.arm.linux.org.uk> References: <20140423185534.GA26756@n2100.arm.linux.org.uk> <20140425123820.GA15179@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140425123820.GA15179@pengutronix.de> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, Apr 25, 2014 at 02:38:20PM +0200, Markus Pargmann wrote: > Hi, > > On Wed, Apr 23, 2014 at 08:07:57PM +0100, Russell King wrote: > > Patch suggested by Dong Aisheng , this avoids > > additional clock start/stop cycles during the transition to 1.8V > > signalling mode. > > > > Signed-off-by: Russell King > > I tested the series on imx6s with a RIoT board. With this patch applied > the RIoT board emmc does not work. Here is the output of the board: Unfortunately, I don't have any emmc sdhci using devices, so this is a combination I can't test myself. What would be useful is to find out which of the two changes in there is the cause - can you try with just the change to sdhci_do_start_signal_voltage_switch applied, iow just this change: Thanks. diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 748333ba6e96..0bcef2d42da4 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -1757,9 +1748,6 @@ static int sdhci_do_start_signal_voltage_switch(struct sdhci_host *host, ctrl |= SDHCI_CTRL_VDD_180; sdhci_writew(host, ctrl, SDHCI_HOST_CONTROL2); - /* Wait for 5ms */ - usleep_range(5000, 5500); - /* 1.8V regulator output should be stable within 5 ms */ ctrl = sdhci_readw(host, SDHCI_HOST_CONTROL2); if (ctrl & SDHCI_CTRL_VDD_180)