| Message ID | 20150121111944.GA229257@athens (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 21 January 2015 at 12:19, kbuild test robot <fengguang.wu@intel.com> wrote: > drivers/mmc/host/sdhci_f_sdh30.c:143:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 144 > > PTR_ERR should access the value just tested by IS_ERR > > Semantic patch information: > There can be false positives in the patch case, where it is the call > IS_ERR that is wrong. > > Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci Cool script. :-) > > CC: Vincent Yang <vincent.yang.fujitsu@gmail.com> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> Thanks! Applied for next. Kind regards Uffe > --- > > sdhci_f_sdh30.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/mmc/host/sdhci_f_sdh30.c > +++ b/drivers/mmc/host/sdhci_f_sdh30.c > @@ -141,7 +141,7 @@ static int sdhci_f_sdh30_probe(struct pl > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > host->ioaddr = devm_ioremap_resource(&pdev->dev, res); > if (IS_ERR(host->ioaddr)) { > - ret = PTR_ERR(host); > + ret = PTR_ERR(host->ioaddr); > goto err; > } > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
2015-01-21 19:37 GMT+08:00 Ulf Hansson <ulf.hansson@linaro.org>: > On 21 January 2015 at 12:19, kbuild test robot <fengguang.wu@intel.com> wrote: >> drivers/mmc/host/sdhci_f_sdh30.c:143:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 144 >> >> PTR_ERR should access the value just tested by IS_ERR >> >> Semantic patch information: >> There can be false positives in the patch case, where it is the call >> IS_ERR that is wrong. >> >> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci > > Cool script. :-) > >> >> CC: Vincent Yang <vincent.yang.fujitsu@gmail.com> >> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > > Thanks! Applied for next. > > Kind regards > Uffe Thanks a lot! Kind regards Vincent > >> --- >> >> sdhci_f_sdh30.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> --- a/drivers/mmc/host/sdhci_f_sdh30.c >> +++ b/drivers/mmc/host/sdhci_f_sdh30.c >> @@ -141,7 +141,7 @@ static int sdhci_f_sdh30_probe(struct pl >> res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> host->ioaddr = devm_ioremap_resource(&pdev->dev, res); >> if (IS_ERR(host->ioaddr)) { >> - ret = PTR_ERR(host); >> + ret = PTR_ERR(host->ioaddr); >> goto err; >> } >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- a/drivers/mmc/host/sdhci_f_sdh30.c +++ b/drivers/mmc/host/sdhci_f_sdh30.c @@ -141,7 +141,7 @@ static int sdhci_f_sdh30_probe(struct pl res = platform_get_resource(pdev, IORESOURCE_MEM, 0); host->ioaddr = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(host->ioaddr)) { - ret = PTR_ERR(host); + ret = PTR_ERR(host->ioaddr); goto err; }
drivers/mmc/host/sdhci_f_sdh30.c:143:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 144 PTR_ERR should access the value just tested by IS_ERR Semantic patch information: There can be false positives in the patch case, where it is the call IS_ERR that is wrong. Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci CC: Vincent Yang <vincent.yang.fujitsu@gmail.com> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- sdhci_f_sdh30.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html