From patchwork Mon Sep 19 08:00:45 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 9338745 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F2839607D0 for ; Mon, 19 Sep 2016 08:00:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E5BC628C5B for ; Mon, 19 Sep 2016 08:00:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DA7C62905F; Mon, 19 Sep 2016 08:00:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_TVD_MIME_EPI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D389828CB1 for ; Mon, 19 Sep 2016 08:00:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760256AbcISIAz (ORCPT ); Mon, 19 Sep 2016 04:00:55 -0400 Received: from sauhun.de ([89.238.76.85]:35819 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751914AbcISIAz (ORCPT ); Mon, 19 Sep 2016 04:00:55 -0400 Received: from p5b385f2f.dip0.t-ipconnect.de ([91.56.95.47]:53742 helo=katana) by pokefinder.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1bltVR-0001fH-Fu; Mon, 19 Sep 2016 10:00:49 +0200 Date: Mon, 19 Sep 2016 10:00:45 +0200 From: Wolfram Sang To: Geert Uytterhoeven , Ulf Hansson Cc: Wolfram Sang , Linux MMC List , Linux-Renesas , Simon Horman , Dirk Behme Subject: Re: [PATCH 0/4] tmio: add support for eMMC with 8 bit bus width Message-ID: <20160919080045.GA1409@katana> References: <20160914170558.1561-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Sep 15, 2016 at 01:52:26PM +0200, Geert Uytterhoeven wrote: > Hi Wolfram, > > On Wed, Sep 14, 2016 at 7:05 PM, Wolfram Sang > wrote: > > The DTS changes for R-Car Gen3 will come via a seperate series. Note that > > 'non-removable' is not supported yet because of Runtime PM issues. It seems we > > need to overhaul Runtime PM handling for other reasons as well, so I suggest > > the basic support goes in like this and DTS do not use 'non-removable' for now. > > DT describes the hardware, not current limitations of the software. > Hence IMHO you should add the "non-removable" property to the DTS, and > work around its non-functioning in software. @Ulf: Would you accept such a workaround for a while? diff --git a/drivers/mmc/host/tmio_mmc_pio.c b/drivers/mmc/host/tmio_mmc_pio.c index f21c92ec7121cc..5ab8af294f7c40 100644 --- a/drivers/mmc/host/tmio_mmc_pio.c +++ b/drivers/mmc/host/tmio_mmc_pio.c @@ -1154,6 +1154,10 @@ int tmio_mmc_host_probe(struct tmio_mmc_host *_host, !mmc_card_is_removable(mmc) || mmc->slot.cd_irq >= 0); + /* Workaround for NONREMOVABLE until we fix RuntimePM handling */ + if (pdata->flags & TMIO_MMC_MIN_RCAR2) + _host->native_hotplug = true; + if (tmio_mmc_clk_enable(_host) < 0) { mmc->f_max = pdata->hclk; mmc->f_min = mmc->f_max / 512;