From patchwork Tue Nov 15 10:12:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaehoon Chung X-Patchwork-Id: 9429283 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 959826047D for ; Tue, 15 Nov 2016 10:12:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 803B9286AB for ; Tue, 15 Nov 2016 10:12:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7511F286B7; Tue, 15 Nov 2016 10:12:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 164E0286EF for ; Tue, 15 Nov 2016 10:12:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941609AbcKOKMr (ORCPT ); Tue, 15 Nov 2016 05:12:47 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:51235 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941425AbcKOKMn (ORCPT ); Tue, 15 Nov 2016 05:12:43 -0500 Received: from epcpsbgm1new.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OGO00AFZHOSER70@mailout1.samsung.com>; Tue, 15 Nov 2016 19:12:34 +0900 (KST) X-AuditID: cbfee61a-f79916d0000062de-b2-582adf923c30 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1new.samsung.com (EPCPMTA) with SMTP id 14.CF.25310.29FDA285; Tue, 15 Nov 2016 19:12:34 +0900 (KST) Received: from localhost.localdomain ([10.113.62.216]) by mmp1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OGO004CZHOYWN60@mmp1.samsung.com>; Tue, 15 Nov 2016 19:12:34 +0900 (KST) From: Jaehoon Chung To: linux-mmc@vger.kernel.org Cc: devicetree@vger.kernel.org, ulf.hansson@linaro.org, heiko@sntech.de, shawn.lin@rock-chips.com, robh+dt@kernel.org, Jaehoon Chung Subject: [PATCHv2 02/10] mmc: dw_mmc: fix the debug message for checking card's present Date: Tue, 15 Nov 2016 19:12:24 +0900 Message-id: <20161115101232.3854-3-jh80.chung@samsung.com> X-Mailer: git-send-email 2.10.1 In-reply-to: <20161115101232.3854-1-jh80.chung@samsung.com> References: <20161115101232.3854-1-jh80.chung@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrALMWRmVeSWpSXmKPExsVy+t9jAd1J97UiDPZN1LaYf+Qcq8X/R69Z LW78amO1OPK/n9Gide8Rdos7T9azWhxfG+7A7rFpVSebx51re9g8/s7az+LRt2UVo8f2a/OY PT5vkgtgi3KzyUhNTEktUkjNS85PycxLt1UKDXHTtVBSyEvMTbVVitD1DQlSUihLzCkF8owM 0ICDc4B7sJK+XYJbxuqbq9kLtnNUzJ22naWBsYe9i5GDQ0LARKL3jn0XIyeQKSZx4d56ti5G Lg4hgaWMEuuv32CGcH4wSsz5+IANpIpNQEdi+7fjTCC2iICsxM8/F8DizAILGSVevkgEsYUF IiWaG26B1bAIqEr8uXWBHcTmFbCSePHyDRvENnmJC1dPsYDYnALWEsefHWQEsYWAan4962Gc wMi7gJFhFaNEakFyQXFSeq5hXmq5XnFibnFpXrpecn7uJkZwaD+T2sF4cJf7IUYBDkYlHt5A b60IIdbEsuLK3EOMEhzMSiK85teAQrwpiZVVqUX58UWlOanFhxhNgQ6byCwlmpwPjLu8knhD E3MTc2MDC3NLSxMjJXHextnPwoUE0hNLUrNTUwtSi2D6mDg4pRoYjxm8zI4TCjM9LKmx39TJ y/p3TV1fYFSFueatRNls7+v/1t2s3Rb6d861Nr+Lj57k2PxU+sp2T/659/zVX8tuG05wuL+M 6alY0+mjOXel1sUmhast+/+/8bH3sxtS1yRbfhb0aGXOPit/fEHI6v/Jm3uZz5ssz+5z3xZz zfPEx6iGT8eMvxtcUmIpzkg01GIuKk4EAGEGPKuDAgAA X-MTR: 20000000000000000@CPGS Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If display the debug message, this message should be spamming. If flags is maintained the previous value, didn't display the debug message. Signed-off-by: Jaehoon Chung Tested-by: Heiko Stuebner Reviewed-by: Shawn Lin --- drivers/mmc/host/dw_mmc.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index e53899e..6c0c4c5 100644 --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_mmc.c @@ -1537,13 +1537,10 @@ static int dw_mci_get_cd(struct mmc_host *mmc) == 0 ? 1 : 0; spin_lock_bh(&host->lock); - if (present) { - set_bit(DW_MMC_CARD_PRESENT, &slot->flags); + if (present && !test_and_set_bit(DW_MMC_CARD_PRESENT, &slot->flags)) dev_dbg(&mmc->class_dev, "card is present\n"); - } else { - clear_bit(DW_MMC_CARD_PRESENT, &slot->flags); + else if (!test_and_clear_bit(DW_MMC_CARD_PRESENT, &slot->flags)) dev_dbg(&mmc->class_dev, "card is not present\n"); - } spin_unlock_bh(&host->lock); return present;