Message ID | 20170509154504.31901-1-colin.king@canonical.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On 9 May 2017 at 17:45, Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > At the end of either of the read or write loops len is always zero > and hence the non-zero check on len and return of -EIO is redundant > and can be removed. > > Detected by CoverityScan, CID#114293 ("Logically dead code") > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Thanks, applied for next! Kind regards Uffe > --- > drivers/mmc/host/sdricoh_cs.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/mmc/host/sdricoh_cs.c b/drivers/mmc/host/sdricoh_cs.c > index 5ff26ab81eb1..70cb00aa79a0 100644 > --- a/drivers/mmc/host/sdricoh_cs.c > +++ b/drivers/mmc/host/sdricoh_cs.c > @@ -256,9 +256,6 @@ static int sdricoh_blockio(struct sdricoh_host *host, int read, > } > } > > - if (len) > - return -EIO; > - > return 0; > } > > -- > 2.11.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/host/sdricoh_cs.c b/drivers/mmc/host/sdricoh_cs.c index 5ff26ab81eb1..70cb00aa79a0 100644 --- a/drivers/mmc/host/sdricoh_cs.c +++ b/drivers/mmc/host/sdricoh_cs.c @@ -256,9 +256,6 @@ static int sdricoh_blockio(struct sdricoh_host *host, int read, } } - if (len) - return -EIO; - return 0; }