| Message ID | 20170808052057.24433-1-kishon@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* Kishon Vijay Abraham I <kishon@ti.com> [170807 22:22]: > The GPIO polarity for MMC1 card detect is set to '0' which means > active-high. However the polarity should be active-low. Fix it > here. Can these wait for v4.14 merge window or do these fix known issues? Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Tony, On Thursday 10 August 2017 03:38 AM, Tony Lindgren wrote: > * Kishon Vijay Abraham I <kishon@ti.com> [170807 22:22]: >> The GPIO polarity for MMC1 card detect is set to '0' which means >> active-high. However the polarity should be active-low. Fix it >> here. > > Can these wait for v4.14 merge window or do these fix known > issues? These can go in the next merge window. I didn't observe any issue without this in omap_hsmmc driver. Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* Kishon Vijay Abraham I <kishon@ti.com> [170810 00:46]: > Tony, > > On Thursday 10 August 2017 03:38 AM, Tony Lindgren wrote: > > * Kishon Vijay Abraham I <kishon@ti.com> [170807 22:22]: > >> The GPIO polarity for MMC1 card detect is set to '0' which means > >> active-high. However the polarity should be active-low. Fix it > >> here. > > > > Can these wait for v4.14 merge window or do these fix known > > issues? > > These can go in the next merge window. I didn't observe any issue without this > in omap_hsmmc driver. OK applying both into omap-for-v4.14/dt thanks. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/am571x-idk.dts b/arch/arm/boot/dts/am571x-idk.dts index 7b207835b2d1..adc70fb091a2 100644 --- a/arch/arm/boot/dts/am571x-idk.dts +++ b/arch/arm/boot/dts/am571x-idk.dts @@ -68,7 +68,7 @@ status = "okay"; vmmc-supply = <&ldo1_reg>; bus-width = <4>; - cd-gpios = <&gpio6 27 0>; /* gpio 219 */ + cd-gpios = <&gpio6 27 GPIO_ACTIVE_LOW>; /* gpio 219 */ }; &omap_dwc3_2 {
The GPIO polarity for MMC1 card detect is set to '0' which means active-high. However the polarity should be active-low. Fix it here. Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> --- arch/arm/boot/dts/am571x-idk.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)