From patchwork Tue Oct 10 09:14:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9995381 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1C2E560216 for ; Tue, 10 Oct 2017 09:15:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 15F9B28421 for ; Tue, 10 Oct 2017 09:15:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 08CB42842B; Tue, 10 Oct 2017 09:15:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7F88C28421 for ; Tue, 10 Oct 2017 09:15:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756001AbdJJJOk (ORCPT ); Tue, 10 Oct 2017 05:14:40 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:65523 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755844AbdJJJOh (ORCPT ); Tue, 10 Oct 2017 05:14:37 -0400 Received: from wuerfel.lan ([95.208.190.237]) by mrelayeu.kundenserver.de (mreue102 [212.227.15.145]) with ESMTPA (Nemesis) id 0MGiBd-1e6ZZF1Rz7-00DV0m; Tue, 10 Oct 2017 11:14:28 +0200 From: Arnd Bergmann To: Adrian Hunter , Ulf Hansson Cc: Arnd Bergmann , Ritesh Harjani , Sahitya Tummala , Venkat Gopalakrishnan , Subhash Jadavani , Bjorn Andersson , Vijay Viswanath , Pramod Gurav , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] mmc: sdhci-msm: fix x86 build error Date: Tue, 10 Oct 2017 11:14:16 +0200 Message-Id: <20171010091427.2244260-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:d3FZTzIgjlU/E7I4kIANUGaWMCslWUEjzyL0DHbTQeQmQAy4fpU GRsQcxZ+U4X4ZYxR92SyR/eDfBWX8euY2LjCkfiklUlFaaiFM1vONQrrNwm5WWGszd1s8e+ KZ0Z96p50w4sWVaI/qlydqZ4iicc95q2eOktuBXr1trlQ8RkG7Q8VVTpdIbi6hxgQyNhDbj MNzb20ArQ7WfSa3+C0mpA== X-UI-Out-Filterresults: notjunk:1; V01:K0:Xl7YEsd8DbA=:Yy67bJPbnZaM4IUvL/dNoZ hwo3LjkF8If9iK4UttPwRuV5ZrTOfwO1K33W0qW9+ek5HjbLahSwgR2G7U91KbrKuA2xcspZe 2SrRzdUOSrxlsxqPMghDrtEM0uzBzXE5pIGBOPj7jN9byZk48h0UwfuGlReYyIdilXBuuS0ze 8spSjwsT/YRxVs8hioua0+4oamwpwkjblNW+/RJR5AtbTCkzPkQJhzXJVYwjCchZSqtu8f+v3 NFdFN7rz6ccjps0bLREFvsewejQnojc+REIuiL7E73QAEWoPq6mJT8RMjJOM98tqHLcWfKaUt AJwBTwg3Z6r1u9tXb3mvcD/4/lgLx7aaALuEKFEtSKiYamrcQcUKAhqVt1ZKC5GrjMYu0+vYs 55oqsOTKM7X085/mGz7iFYMwZO0HT0SWwl4SAIjCOW0GZti1gZky2rfVEDV24owgXM0EhSRNq aK1JQFMocB++akM0f7qqOWjzEih9ipOZGb5M499qrVJk0RGjxf/R9wZO7vvAVYKdTXcvbAG69 TkPxekyTW/CHPr4VPWN6yTiZdp5pAW2am4xcgGLrY2wtEbRgtqO70n4jOxhwl5rIEgiMfgUOv DCI4cq2K/jCYAHUuhvVXyi47iIhsbVuUA2/bfxLFj0HLnbKl78gkVCOgRE0iDZh87ONvMrC9/ K8Aubta06/MAyFV+r7mOSTtIAdYr0WoYaEYHC7AFLvDzGwo23Il/Vs0MzggNIHDbnvB0m+g2v 9JxP9UDaVPfsEsHy3BUPTizZTbBJQvPUZ1dbEA== Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The __WARN_printf() function is not portable across architectures and causes a compile-time error on x86 and others that don't use the asm-generic version of asm/bug.h: drivers/mmc/host/sdhci-msm.c: In function 'sdhci_msm_check_power_status': drivers/mmc/host/sdhci-msm.c:1066:4: error: implicit declaration of function '__WARN_printf'; did you mean '__dev_printk'? [-Werror=implicit-function-declaration] __WARN_printf("%s: pwr_irq for req: (%d) timed out\n", ^~~~~~~~~~~~~ I assume that dev_warn() is the function that was meant to be used here, so I'm changing it over to that. Fixes: 6cdf3287f490 ("mmc: sdhci-msm: Add sdhci msm register write APIs which wait for pwr irq") Signed-off-by: Arnd Bergmann --- drivers/mmc/host/sdhci-msm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index 85a882b4c541..3fb7d2eec93f 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc/host/sdhci-msm.c @@ -1063,8 +1063,9 @@ static void sdhci_msm_check_power_status(struct sdhci_host *host, u32 req_type) if (!wait_event_timeout(msm_host->pwr_irq_wait, msm_host->pwr_irq_flag, msecs_to_jiffies(MSM_PWR_IRQ_TIMEOUT_MS))) - __WARN_printf("%s: pwr_irq for req: (%d) timed out\n", - mmc_hostname(host->mmc), req_type); + dev_warn(&msm_host->pdev->dev, + "%s: pwr_irq for req: (%d) timed out\n", + mmc_hostname(host->mmc), req_type); } pr_debug("%s: %s: request %d done\n", mmc_hostname(host->mmc), __func__, req_type);