| Message ID | 20171130113738.3851-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 30/11/17 13:37, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The function mmc_cqe_issue_type is local to the source and does > not need to be in global scope, so make it static. > > Cleans up sparse warning: > drivers/mmc/core/queue.c:62:21: warning: symbol 'mmc_cqe_issue_type' > was not declared. Should it be static? > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > --- > drivers/mmc/core/queue.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c > index d8394007bc99..5db388081789 100644 > --- a/drivers/mmc/core/queue.c > +++ b/drivers/mmc/core/queue.c > @@ -59,8 +59,8 @@ static inline bool mmc_cqe_can_dcmd(struct mmc_host *host) > return host->caps2 & MMC_CAP2_CQE_DCMD; > } > > -enum mmc_issue_type mmc_cqe_issue_type(struct mmc_host *host, > - struct request *req) > +static enum mmc_issue_type mmc_cqe_issue_type(struct mmc_host *host, > + struct request *req) > { > switch (req_op(req)) { > case REQ_OP_DRV_IN: > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 30 November 2017 at 12:37, Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > The function mmc_cqe_issue_type is local to the source and does > not need to be in global scope, so make it static. > > Cleans up sparse warning: > drivers/mmc/core/queue.c:62:21: warning: symbol 'mmc_cqe_issue_type' > was not declared. Should it be static? > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Thanks, applied for next! Kind regards Uffe > --- > drivers/mmc/core/queue.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c > index d8394007bc99..5db388081789 100644 > --- a/drivers/mmc/core/queue.c > +++ b/drivers/mmc/core/queue.c > @@ -59,8 +59,8 @@ static inline bool mmc_cqe_can_dcmd(struct mmc_host *host) > return host->caps2 & MMC_CAP2_CQE_DCMD; > } > > -enum mmc_issue_type mmc_cqe_issue_type(struct mmc_host *host, > - struct request *req) > +static enum mmc_issue_type mmc_cqe_issue_type(struct mmc_host *host, > + struct request *req) > { > switch (req_op(req)) { > case REQ_OP_DRV_IN: > -- > 2.14.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c index d8394007bc99..5db388081789 100644 --- a/drivers/mmc/core/queue.c +++ b/drivers/mmc/core/queue.c @@ -59,8 +59,8 @@ static inline bool mmc_cqe_can_dcmd(struct mmc_host *host) return host->caps2 & MMC_CAP2_CQE_DCMD; } -enum mmc_issue_type mmc_cqe_issue_type(struct mmc_host *host, - struct request *req) +static enum mmc_issue_type mmc_cqe_issue_type(struct mmc_host *host, + struct request *req) { switch (req_op(req)) { case REQ_OP_DRV_IN: