diff mbox

[v3] mmc: sd: Define name for default speed dtr

Message ID 20180524033825.23385-1-yinbo.zhu@nxp.com (mailing list archive)
State New, archived
Headers show

Commit Message

Yinbo Zhu May 24, 2018, 3:38 a.m. UTC
Add a new define for the sd default speed 25MHz case

Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
---
Change in v3:
		Modify the commit information that replace macro with define
		and remove cleanup string and change the full speed as default speed 

 include/linux/mmc/card.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Adrian Hunter May 24, 2018, 8:49 a.m. UTC | #1
On 24/05/18 06:38, Yinbo Zhu wrote:
> Add a new define for the sd default speed 25MHz case

Is this for "[PATCH v2] mmc: sdhci-of-esdhc: modify the sd clock in
soc_device_match way"?  Then it should be in the same patch series, so
people can see what it is for.

> 
> Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
> ---
> Change in v3:
> 		Modify the commit information that replace macro with define
> 		and remove cleanup string and change the full speed as default speed 
> 
>  include/linux/mmc/card.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h
> index 279b390..f5be8c7 100644
> --- a/include/linux/mmc/card.h
> +++ b/include/linux/mmc/card.h
> @@ -156,6 +156,7 @@ struct sd_switch_caps {
>  #define UHS_DDR50_MAX_DTR	50000000
>  #define UHS_SDR25_MAX_DTR	UHS_DDR50_MAX_DTR
>  #define UHS_SDR12_MAX_DTR	25000000
> +#define DEFAULT_SPEED_MAX_DTR	UHS_SDR12_MAX_DTR
>  	unsigned int		sd3_bus_mode;
>  #define UHS_SDR12_BUS_SPEED	0
>  #define HIGH_SPEED_BUS_SPEED	1
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Yinbo Zhu May 24, 2018, 8:57 a.m. UTC | #2
-----Original Message-----
From: Adrian Hunter [mailto:adrian.hunter@intel.com] 

Sent: 2018年5月24日 16:50
To: Yinbo Zhu <yinbo.zhu@nxp.com>; Y.b. Lu <yangbo.lu@nxp.com>; linux-mmc@vger.kernel.org
Cc: Xiaobo Xie <xiaobo.xie@nxp.com>
Subject: Re: [PATCH v3] mmc: sd: Define name for default speed dtr

On 24/05/18 06:38, Yinbo Zhu wrote:
> Add a new define for the sd default speed 25MHz case


>Is this for "[PATCH v2] mmc: sdhci-of-esdhc: modify the sd clock in soc_device_match way"?  Then it should be in the same patch series, so people can see what it is 

>for.

Yes, it is for "[PATCH v2] mmc: sdhci-of-esdhc: modify the sd clock in soc_device_match way"
Then I will send they to upstream as same patch series.

Thanks
Regards
Yinbo
> 

> Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>

> ---

> Change in v3:

> 		Modify the commit information that replace macro with define

> 		and remove cleanup string and change the full speed as default speed

> 

>  include/linux/mmc/card.h |    1 +

>  1 files changed, 1 insertions(+), 0 deletions(-)

> 

> diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h index 

> 279b390..f5be8c7 100644

> --- a/include/linux/mmc/card.h

> +++ b/include/linux/mmc/card.h

> @@ -156,6 +156,7 @@ struct sd_switch_caps {

>  #define UHS_DDR50_MAX_DTR	50000000

>  #define UHS_SDR25_MAX_DTR	UHS_DDR50_MAX_DTR

>  #define UHS_SDR12_MAX_DTR	25000000

> +#define DEFAULT_SPEED_MAX_DTR	UHS_SDR12_MAX_DTR

>  	unsigned int		sd3_bus_mode;

>  #define UHS_SDR12_BUS_SPEED	0

>  #define HIGH_SPEED_BUS_SPEED	1

>
Ulf Hansson May 28, 2018, 11:27 a.m. UTC | #3
On 24 May 2018 at 05:38, Yinbo Zhu <yinbo.zhu@nxp.com> wrote:
> Add a new define for the sd default speed 25MHz case
>
> Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>

As Adrian pointed out, this should have been a part of a series with
"mmc: sdhci-of-esdhc: modify the sd clock in soc_device_match way".

However, this time I decided to apply $subject patch as is, for next,
and trust you to proceed with the patch mentioned above.

Thanks and kind regards
Uffe

> ---
> Change in v3:
>                 Modify the commit information that replace macro with define
>                 and remove cleanup string and change the full speed as default speed
>
>  include/linux/mmc/card.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h
> index 279b390..f5be8c7 100644
> --- a/include/linux/mmc/card.h
> +++ b/include/linux/mmc/card.h
> @@ -156,6 +156,7 @@ struct sd_switch_caps {
>  #define UHS_DDR50_MAX_DTR      50000000
>  #define UHS_SDR25_MAX_DTR      UHS_DDR50_MAX_DTR
>  #define UHS_SDR12_MAX_DTR      25000000
> +#define DEFAULT_SPEED_MAX_DTR  UHS_SDR12_MAX_DTR
>         unsigned int            sd3_bus_mode;
>  #define UHS_SDR12_BUS_SPEED    0
>  #define HIGH_SPEED_BUS_SPEED   1
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h
index 279b390..f5be8c7 100644
--- a/include/linux/mmc/card.h
+++ b/include/linux/mmc/card.h
@@ -156,6 +156,7 @@  struct sd_switch_caps {
 #define UHS_DDR50_MAX_DTR	50000000
 #define UHS_SDR25_MAX_DTR	UHS_DDR50_MAX_DTR
 #define UHS_SDR12_MAX_DTR	25000000
+#define DEFAULT_SPEED_MAX_DTR	UHS_SDR12_MAX_DTR
 	unsigned int		sd3_bus_mode;
 #define UHS_SDR12_BUS_SPEED	0
 #define HIGH_SPEED_BUS_SPEED	1