From patchwork Wed May 30 14:43:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Georgi Djakov X-Patchwork-Id: 10439159 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E0F6D601D3 for ; Wed, 30 May 2018 14:43:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0A8B326E4A for ; Wed, 30 May 2018 14:43:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F2E6328A5C; Wed, 30 May 2018 14:43:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9946226E4A for ; Wed, 30 May 2018 14:43:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751544AbeE3Onl (ORCPT ); Wed, 30 May 2018 10:43:41 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33381 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751554AbeE3Onk (ORCPT ); Wed, 30 May 2018 10:43:40 -0400 Received: by mail-wm0-f65.google.com with SMTP id x12-v6so2005810wmc.0 for ; Wed, 30 May 2018 07:43:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=EC2jvyZwPw/4PClLRf6t9Rxj97MApWljn0D/7xGa6/o=; b=O3xcfDGpiUQNn28/dJcGaG7GbeeWTzeUeSumvFkKpLtzUecxu0vntrvsFMzpg8QJ5w zKSajfvNOgZdPTvZ/UNQWbIdWlGaTLnfySYYUXzBdRUK0YQ2lMKDvwICRZ7BjuIwqiun maAY6cvRJZ4FpMOKGccG+5yT4yVaRVdrq+WIM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=EC2jvyZwPw/4PClLRf6t9Rxj97MApWljn0D/7xGa6/o=; b=h8R2Zxl6eHTcXjUEM45PfTrmdv1n+iTKnCjLbl7w/5HRYUoMrOT3GQJUT2fwbFOA0c 2HRutvuvcyBc8WcAe9kKAMICmEKrbS7wORyx8rxV4NnjPymsaq+k9hokkDvZD3q3o6mX cnMe4nq42iQ3fsUbcoVYxPYH5T8tlGai2IurQvsoFnZ2ZP7nO0Gt8t3mRyu5Au5EWmXR o+x8nOnouqOx4HKa9KNPAXolxiQkhtuqpO97PYDXmu7YUrP/LiOFH28kIR7iu0bY9JGz ZHxw0GGzOmQF71zkhsRPMS2TZ6AiF1mZJ1K7+4F/ahxQzcXFvc3VVS6htD4adKUmA6yJ 0bWw== X-Gm-Message-State: ALKqPwdSOBllCEFYav8ImKfQTd32ym1e30lO4KRXx617FhczU97BWBzp WNreeTGxDkObsc+ZY5DEc0meWg== X-Google-Smtp-Source: ADUXVKIqbeNdxUccYvOrMQWw4wABTjCSQDp4wU9F92O30ZAIMa6tyx9BYgz5FYj3HpRIeinJ21Dqjg== X-Received: by 2002:a1c:8795:: with SMTP id j143-v6mr1808642wmd.149.1527691418851; Wed, 30 May 2018 07:43:38 -0700 (PDT) Received: from localhost.localdomain ([212.45.67.2]) by smtp.googlemail.com with ESMTPSA id u3-v6sm13223823wrm.60.2018.05.30.07.43.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 30 May 2018 07:43:37 -0700 (PDT) From: Georgi Djakov To: ulf.hansson@linaro.org, adrian.hunter@intel.com Cc: vviswana@codeaurora.org, riteshh@codeaurora.org, subhashj@codeaurora.org, stummala@codeaurora.org, asutoshd@codeaurora.org, bjorn.andersson@linaro.org, linux-mmc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Georgi Djakov Subject: [PATCH] mmc: sdhci-msm: Remove NO_CARD_NO_RESET quirk Date: Wed, 30 May 2018 17:43:35 +0300 Message-Id: <20180530144335.7888-1-georgi.djakov@linaro.org> X-Mailer: git-send-email 2.16.2 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Now we have a proper implementation for the power irq handling and this quirk is not needed anymore. In fact, it is causing card detection delays on apq8096 platforms and the following error is displayed: sdhci_msm 74a4900.sdhci: mmc0: pwr_irq for req: (4) timed out The quirk is forcing the controller to retain 1.8V signalling on the slot even when a new card is inserted, which is not correct. The proper behavior would be to reset the controller in order to start with 3.3V signaling. Fixes: c0309b3803fe ("mmc: sdhci-msm: Add sdhci msm register write APIs which wait for pwr irq") Suggested-by: Vijay Viswanath Signed-off-by: Georgi Djakov Acked-by: Adrian Hunter --- This can go for v4.18, as it's not a critical fix. Tested on db410c and db820c. --- drivers/mmc/host/sdhci-msm.c | 1 - 1 file changed, 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index c283291db705..791779173332 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc/host/sdhci-msm.c @@ -1333,7 +1333,6 @@ static const struct sdhci_ops sdhci_msm_ops = { static const struct sdhci_pltfm_data sdhci_msm_pdata = { .quirks = SDHCI_QUIRK_BROKEN_CARD_DETECTION | - SDHCI_QUIRK_NO_CARD_NO_RESET | SDHCI_QUIRK_SINGLE_POWER_WRITE | SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN, .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN,