| Message ID | 20180705141841.11121-5-niklas.soderlund+renesas@ragnatech.se (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jul 05, 2018 at 04:18:41PM +0200, Niklas Söderlund wrote: > From: Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com> > > Checking for SCC error during retuning is unnecessary. > > Signed-off-by: Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com> > [Niklas: fix small style issue] > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > drivers/mmc/host/renesas_sdhi_core.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c > index 589da18bd636c2f4..ef711c532a26babe 100644 > --- a/drivers/mmc/host/renesas_sdhi_core.c > +++ b/drivers/mmc/host/renesas_sdhi_core.c > @@ -445,6 +445,13 @@ static bool renesas_sdhi_check_scc_error(struct tmio_mmc_host *host) > { > struct renesas_sdhi *priv = host_to_priv(host); > > + if (!(host->mmc->ios.timing == MMC_TIMING_UHS_SDR104) && > + !(host->mmc->ios.timing == MMC_TIMING_MMC_HS200)) > + return false; > + > + if (host->mmc->doing_retune) > + return false; > + I believe this patch needs to be updaed now that HS400 support has been merged. > /* Check SCC error */ > if (sd_scc_read32(host, priv, SH_MOBILE_SDHI_SCC_RVSCNTL) & > SH_MOBILE_SDHI_SCC_RVSCNTL_RVSEN && > -- > 2.17.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jul 05, 2018 at 04:18:41PM +0200, Niklas Söderlund wrote: > From: Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com> > > Checking for SCC error during retuning is unnecessary. > > Signed-off-by: Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com> > [Niklas: fix small style issue] > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Simon, Thanks for your feedback. On 2018-07-12 14:57:22 +0200, Simon Horman wrote: > On Thu, Jul 05, 2018 at 04:18:41PM +0200, Niklas Söderlund wrote: > > From: Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com> > > > > Checking for SCC error during retuning is unnecessary. > > > > Signed-off-by: Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com> > > [Niklas: fix small style issue] > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > --- > > drivers/mmc/host/renesas_sdhi_core.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c > > index 589da18bd636c2f4..ef711c532a26babe 100644 > > --- a/drivers/mmc/host/renesas_sdhi_core.c > > +++ b/drivers/mmc/host/renesas_sdhi_core.c > > @@ -445,6 +445,13 @@ static bool renesas_sdhi_check_scc_error(struct tmio_mmc_host *host) > > { > > struct renesas_sdhi *priv = host_to_priv(host); > > > > + if (!(host->mmc->ios.timing == MMC_TIMING_UHS_SDR104) && > > + !(host->mmc->ios.timing == MMC_TIMING_MMC_HS200)) > > + return false; > > + > > + if (host->mmc->doing_retune) > > + return false; > > + > > I believe this patch needs to be updaed now that HS400 support has > been merged. Thanks I missed that HS400 had been merged, will update for next version. > > > /* Check SCC error */ > > if (sd_scc_read32(host, priv, SH_MOBILE_SDHI_SCC_RVSCNTL) & > > SH_MOBILE_SDHI_SCC_RVSCNTL_RVSEN && > > -- > > 2.17.0 > >
diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c index 589da18bd636c2f4..ef711c532a26babe 100644 --- a/drivers/mmc/host/renesas_sdhi_core.c +++ b/drivers/mmc/host/renesas_sdhi_core.c @@ -445,6 +445,13 @@ static bool renesas_sdhi_check_scc_error(struct tmio_mmc_host *host) { struct renesas_sdhi *priv = host_to_priv(host); + if (!(host->mmc->ios.timing == MMC_TIMING_UHS_SDR104) && + !(host->mmc->ios.timing == MMC_TIMING_MMC_HS200)) + return false; + + if (host->mmc->doing_retune) + return false; + /* Check SCC error */ if (sd_scc_read32(host, priv, SH_MOBILE_SDHI_SCC_RVSCNTL) & SH_MOBILE_SDHI_SCC_RVSCNTL_RVSEN &&