From patchwork Sat Oct 20 17:23:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?Q2zDqW1lbnQgUMOpcm9u?= X-Patchwork-Id: 10650567 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6E6A61508 for ; Sat, 20 Oct 2018 17:23:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 45C7527E5A for ; Sat, 20 Oct 2018 17:23:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 222ED2862D; Sat, 20 Oct 2018 17:23:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BDE1927E5A for ; Sat, 20 Oct 2018 17:23:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727417AbeJUBeo (ORCPT ); Sat, 20 Oct 2018 21:34:44 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:51032 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727401AbeJUBen (ORCPT ); Sat, 20 Oct 2018 21:34:43 -0400 Received: by mail-wm1-f68.google.com with SMTP id i8-v6so6365416wmg.0 for ; Sat, 20 Oct 2018 10:23:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kq1LDiwRknAfGqP5NAY9MbuAuniS5GQUa7BEQIWCM6w=; b=P5bKEte/futjjxlv7qJBB2i23DyKx5mYeu6ojUFkZFkuaCM70V4vAmmeE9H8IXqyU7 KPW//nIZDuCdu0/A1kTgdvRQDid4WPhlak50uwHTrsgJh1LXTImnJOI6MhH711tNnqtq eSIs9rpkiZlhR8kSIe5ryKSKGLTpJa21RPQNn+R9PEbWJDDJo0+U5L9dtu9yzepDdOQe 7j2et2kqobcSjJgpBaD/jtavUeDnOvAH0mIforSifTO4wPbNTGnV35rDudYWWF54GsYf gGQnpx4plgPmaDaVzAW3ZQ9i6TZ00SZimZxXfsroIxj/XqnRrA8w/zRojGQcjiXxKlS1 bgMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kq1LDiwRknAfGqP5NAY9MbuAuniS5GQUa7BEQIWCM6w=; b=SwEbU4rxCRXPkCTajPPGlez1aNNfVM0nwr+tULBBUytaMbGB6oR4IWWInlX/Va05kA ZiJlpvhYbnkJwwXit9wGhfIrnhSRBv3AvyfxgejD+kt13m/43iSOeSZvkmqzkReeDI0C EGnbKO2ia3bGlh9U8aJusZQ/DJQzhGMNWxiVkPrafuO57xq84IeB8dgMjnmFvs6OJzsS bgoU4tJvXBVreTTo9JEDmKBTu2rkH+auYSV3ioou6H8jsKgipGmMcfTgkkcPU/zy2+he 3UMH5lfz7mjEYaOeIYOqrkfwX/giHoDmFfjthinwE94evIH1DYunfJIvrFOGGAmyXj1u /vMw== X-Gm-Message-State: ABuFfohYu/fySWEKzsDth2hmRDpagvGD9tsDTumGt1IQnVsvy/TSOP8D aTGObcA82pDGG4N3WUO9jJE= X-Google-Smtp-Source: ACcGV63po1UK2PQpyGvmNwoU2Q7Ul8Xz34gmcpPd9l7gXbAoEkLxr8kr2XPhtyDMNguhEnYmLFTAOw== X-Received: by 2002:a1c:2746:: with SMTP id n67-v6mr9391572wmn.116.1540056213867; Sat, 20 Oct 2018 10:23:33 -0700 (PDT) Received: from cperon-Latitude-7490.home (2a01cb00048dc9004c4357618d5f3e30.ipv6.abo.wanadoo.fr. [2a01:cb00:48d:c900:4c43:5761:8d5f:3e30]) by smtp.gmail.com with ESMTPSA id e21-v6sm6102051wma.8.2018.10.20.10.23.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 20 Oct 2018 10:23:33 -0700 (PDT) From: =?utf-8?b?Q2zDqW1lbnQgUMOpcm9u?= To: Ulf Hansson , Avri Altman , linux-mmc@vger.kernel.org Cc: =?utf-8?b?Q2zDqW1lbnQgUMOpcm9u?= Subject: [PATCH] mmc-utils: fix overlapping with strncpy Date: Sat, 20 Oct 2018 19:23:25 +0200 Message-Id: <20181020172325.7450-1-peron.clem@gmail.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP GCC 8.2 warns about an overlapping using strncpy. Replace strncpy with a memmove to avoid this issue. In file included from /usr/include/string.h:494, from lsmmc.c:46: In function ‘strncpy’, inlined from ‘read_file’ at lsmmc.c:356:3: /usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ accessing 4096 bytes at offsets 0 and 1 overlaps 4095 bytes at offset 1 [-Werror=restrict] return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make: *** [Makefile:36: lsmmc.o] Error 1 Signed-off-by: Clément Péron --- lsmmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lsmmc.c b/lsmmc.c index c4faa00..bcb854d 100644 --- a/lsmmc.c +++ b/lsmmc.c @@ -353,7 +353,7 @@ char *read_file(char *name) line[strlen(line) - 1] = '\0'; while (isspace(line[0])) - strncpy(&line[0], &line[1], sizeof(line)); + memmove(&line[0], &line[1], sizeof(line)-1); return strdup(line); }