From patchwork Wed Oct 24 10:58:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?Q2zDqW1lbnQgUMOpcm9u?= X-Patchwork-Id: 10654529 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E922313BF for ; Wed, 24 Oct 2018 10:59:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D7D382A459 for ; Wed, 24 Oct 2018 10:59:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CBF352A467; Wed, 24 Oct 2018 10:59:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 47A0A2A459 for ; Wed, 24 Oct 2018 10:59:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727580AbeJXT0q (ORCPT ); Wed, 24 Oct 2018 15:26:46 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:38141 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726964AbeJXT0q (ORCPT ); Wed, 24 Oct 2018 15:26:46 -0400 Received: by mail-wr1-f67.google.com with SMTP id d10-v6so5095863wrs.5 for ; Wed, 24 Oct 2018 03:59:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=GEQ126jtK1cqQtWhlfI3i6fBF+72359LhEvu1x9v8C8=; b=HFIASzDx5jCBJtlhvWGu5MdRZKM2bIk9wAcHwCEncG0l73jhOIRxCjTsjvNWQQdQvy p99bIqFJp9Dnj/1Ss3+Ku1Cs0RCINbfVOb7gWYs3cRcl6YvslC+AaQojxOTLqaTeKCgT 5RLJt2JDc/pzLmsQcAvoIy+lTZd2WuKMwm7yri+MjzrHEjp+1D26HnVBFaZLAz590zp+ HFVdm/du5VB+WgajK1R6jKOkPiCzmcWeqjRUbFkME7XiWIeb+IB3iHa/q4roLTCOwAzG HbG1l9CgWrvS6XTK0dskoC9I5qfScsJON8RBke5Pb29HhpLjV7oASOMlgYPnt/wwTung dt6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=GEQ126jtK1cqQtWhlfI3i6fBF+72359LhEvu1x9v8C8=; b=ubyndzNUtiIgJYV2xrsinYGJSlNInL9x6CDa8lIv9iuXBVqolDCvs868e8uABDeVMR 4o4sMQkJykJgSkJJRu8ao4KSGvZpHTMCk0comS32Mq1hR16vT4Vgiue/qQSOGzyjluyK +Yzox2C/mYiROdr7SgrGeXhmuMwR/K30UruMNOrLA5gBYN/lTY7YHtnrIF6iwxxab0F8 u4XWHoCsgkrg05teEpaprFbZpGsQ/C8ImOU452BNiHB1ystsORFLuHLCxxns7ma7pbE+ DOIp+bQzz3j1TJd74Gg2wCiU7nDyiirzIw0CyrN1SRLFZxdJO1yJdZGcrcm3i2tGN2Xm i0qw== X-Gm-Message-State: AGRZ1gItBiOdEc7nyfJc5iClUCJdNDi+OeW1zYozub3Ti029DB8sn87C S1E7DHZSv4FUiV6sfhbMHsg= X-Google-Smtp-Source: AJdET5fA4ASM752DJQQhCvbQb5SjMbqRz4zdOFXc+UjLmGu0xPe12b+YXTqRqNBYxQ8ynlTKaAvV3w== X-Received: by 2002:adf:ae09:: with SMTP id x9-v6mr2289914wrc.102.1540378745899; Wed, 24 Oct 2018 03:59:05 -0700 (PDT) Received: from cperon-Latitude-7490.event.pylonone.net ([185.7.230.213]) by smtp.gmail.com with ESMTPSA id 191-v6sm5572831wmk.30.2018.10.24.03.59.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Oct 2018 03:59:04 -0700 (PDT) From: =?utf-8?b?Q2zDqW1lbnQgUMOpcm9u?= To: Chris Ball , Ulf Hansson , Avri Altman , linux-mmc@vger.kernel.org Cc: Nikita Maslov , =?utf-8?b?Q2zDqW1lbnQgUMOpcm9u?= Subject: [PATCH v5] mmc-utils: use MMC_IOC_MULTI_CMD for RPMB access Date: Wed, 24 Oct 2018 12:58:59 +0200 Message-Id: <20181024105859.17055-1-peron.clem@gmail.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Nikita Maslov On some systems which use MMC as a main storage device it is possible that RPMB commands are mixed with generic MMC access commands which invalidates RPMB. This patch uses MMC_IOC_MULTI_CMD. Signed-off-by: Clément Péron Reviewed-by: Avri Altman --- v5: repost with Chris Ball add Avri review tag v4: change title of the commit pass blocks as param of set_single_cmd use temp rpmb_frame to carry the response v3: move set_single_cmd in mmc_cmds.c add MMC_IOC_MULTI_CMD check set blocks in set_single_cmd fix frame_ptr used mmc_cmds.c | 101 ++++++++++++++++++++++++++++------------------------- 1 file changed, 54 insertions(+), 47 deletions(-) diff --git a/mmc_cmds.c b/mmc_cmds.c index 44623fe..886eaf4 100644 --- a/mmc_cmds.c +++ b/mmc_cmds.c @@ -1825,6 +1825,8 @@ int do_sanitize(int nargs, char **argv) ret; \ }) +#define RMPB_MULTI_CMD_MAX_CMDS 3 + enum rpmb_op_type { MMC_RPMB_WRITE_KEY = 0x01, MMC_RPMB_READ_CNT = 0x02, @@ -1847,6 +1849,17 @@ struct rpmb_frame { u_int16_t req_resp; }; +static inline void set_single_cmd(struct mmc_ioc_cmd *ioc, __u32 opcode, + int write_flag, unsigned int blocks) +{ + ioc->opcode = opcode; + ioc->write_flag = write_flag; + ioc->arg = 0x0; + ioc->blksz = 512; + ioc->blocks = blocks; + ioc->flags = MMC_RSP_SPI_R1 | MMC_RSP_R1 | MMC_CMD_ADTC; +} + /* Performs RPMB operation. * * @fd: RPMB device on which we should perform ioctl command @@ -1861,22 +1874,28 @@ static int do_rpmb_op(int fd, struct rpmb_frame *frame_out, unsigned int out_cnt) { +#ifndef MMC_IOC_MULTI_CMD + fprintf(stderr, "mmc-utils has been compiled without MMC_IOC_MULTI_CMD" + " support, needed by RPMB operation.\n"); + exit(1); +#else int err; u_int16_t rpmb_type; - - struct mmc_ioc_cmd ioc = { - .arg = 0x0, - .blksz = 512, - .blocks = 1, - .write_flag = 1, - .opcode = MMC_WRITE_MULTIPLE_BLOCK, - .flags = MMC_RSP_SPI_R1 | MMC_RSP_R1 | MMC_CMD_ADTC, - .data_ptr = (uintptr_t)frame_in - }; + struct mmc_ioc_multi_cmd *mioc; + struct mmc_ioc_cmd *ioc; + struct rpmb_frame frame_status = {0}; if (!frame_in || !frame_out || !out_cnt) return -EINVAL; + /* prepare arguments for MMC_IOC_MUTLI_CMD ioctl */ + mioc = (struct mmc_ioc_multi_cmd *) + malloc(sizeof (struct mmc_ioc_multi_cmd) + + RMPB_MULTI_CMD_MAX_CMDS * sizeof (struct mmc_ioc_cmd)); + if (!mioc) { + return -ENOMEM; + } + rpmb_type = be16toh(frame_in->req_resp); switch(rpmb_type) { @@ -1887,33 +1906,23 @@ static int do_rpmb_op(int fd, goto out; } + mioc->num_of_cmds = 3; + /* Write request */ - ioc.write_flag |= (1<<31); - err = ioctl(fd, MMC_IOC_CMD, &ioc); - if (err < 0) { - err = -errno; - goto out; - } + ioc = &mioc->cmds[0]; + set_single_cmd(ioc, MMC_WRITE_MULTIPLE_BLOCK, (1 << 31) | 1, 1); + mmc_ioc_cmd_set_data((*ioc), frame_in); /* Result request */ - memset(frame_out, 0, sizeof(*frame_out)); - frame_out->req_resp = htobe16(MMC_RPMB_READ_RESP); - ioc.write_flag = 1; - ioc.data_ptr = (uintptr_t)frame_out; - err = ioctl(fd, MMC_IOC_CMD, &ioc); - if (err < 0) { - err = -errno; - goto out; - } + ioc = &mioc->cmds[1]; + frame_status.req_resp = htobe16(MMC_RPMB_READ_RESP); + set_single_cmd(ioc, MMC_WRITE_MULTIPLE_BLOCK, 1, 1); + mmc_ioc_cmd_set_data((*ioc), &frame_status); /* Get response */ - ioc.write_flag = 0; - ioc.opcode = MMC_READ_MULTIPLE_BLOCK; - err = ioctl(fd, MMC_IOC_CMD, &ioc); - if (err < 0) { - err = -errno; - goto out; - } + ioc = &mioc->cmds[2]; + set_single_cmd(ioc, MMC_READ_MULTIPLE_BLOCK, 0, 1); + mmc_ioc_cmd_set_data((*ioc), frame_out); break; case MMC_RPMB_READ_CNT: @@ -1924,23 +1933,17 @@ static int do_rpmb_op(int fd, /* fall through */ case MMC_RPMB_READ: - /* Request */ - err = ioctl(fd, MMC_IOC_CMD, &ioc); - if (err < 0) { - err = -errno; - goto out; - } + mioc->num_of_cmds = 2; + + /* Read request */ + ioc = &mioc->cmds[0]; + set_single_cmd(ioc, MMC_WRITE_MULTIPLE_BLOCK, 1, 1); + mmc_ioc_cmd_set_data((*ioc), frame_in); /* Get response */ - ioc.write_flag = 0; - ioc.opcode = MMC_READ_MULTIPLE_BLOCK; - ioc.blocks = out_cnt; - ioc.data_ptr = (uintptr_t)frame_out; - err = ioctl(fd, MMC_IOC_CMD, &ioc); - if (err < 0) { - err = -errno; - goto out; - } + ioc = &mioc->cmds[1]; + set_single_cmd(ioc, MMC_READ_MULTIPLE_BLOCK, 0, out_cnt); + mmc_ioc_cmd_set_data((*ioc), frame_out); break; default: @@ -1948,8 +1951,12 @@ static int do_rpmb_op(int fd, goto out; } + err = ioctl(fd, MMC_IOC_MULTI_CMD, mioc); + out: + free(mioc); return err; +#endif /* !MMC_IOC_MULTI_CMD */ } int do_rpmb_write_key(int nargs, char **argv)