| Message ID | 20181031230554.1660-2-niklas.soderlund@ragnatech.se (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mmc: tmio: fix reset operation | expand |
On Thu, Nov 01, 2018 at 12:05:52AM +0100, Niklas Söderlund wrote: > From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > On runtime power management resume, the host clock needs to be > enabled before calling tmio_mmc_reset. If the mmc device has a power > domain entry, the host clock is enabled via genpd_runtime_resume, > running before tmio_mmc_host_runtime_resume. If the mmc device has no > power domain entry, however, genpd_runtime_resume is not called. This > patch changes tmio_mmc_host_runtime_resume to enable the host clock > before calling tmio_mmc_reset. > > Based on work from Masaharu Hayakawa. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
On Thu, Nov 1, 2018 at 8:52 AM Niklas Söderlund <niklas.soderlund@ragnatech.se> wrote: > > From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > On runtime power management resume, the host clock needs to be > enabled before calling tmio_mmc_reset. If the mmc device has a power > domain entry, the host clock is enabled via genpd_runtime_resume, > running before tmio_mmc_host_runtime_resume. If the mmc device has no > power domain entry, however, genpd_runtime_resume is not called. This > patch changes tmio_mmc_host_runtime_resume to enable the host clock > before calling tmio_mmc_reset. > > Based on work from Masaharu Hayakawa. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > drivers/mmc/host/tmio_mmc_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc/host/tmio_mmc_core.c > index 8d64f6196f33e882..953562a12a0d6ebc 100644 > --- a/drivers/mmc/host/tmio_mmc_core.c > +++ b/drivers/mmc/host/tmio_mmc_core.c > @@ -1328,8 +1328,8 @@ int tmio_mmc_host_runtime_resume(struct device *dev) > { > struct tmio_mmc_host *host = dev_get_drvdata(dev); > > - host->reset(host); > tmio_mmc_clk_enable(host); > + host->reset(host); > > if (host->clk_cache) > host->set_clock(host, host->clk_cache); > -- > 2.19.1 > -- Best Regards Masahiro Yamada
On Thu, Nov 01, 2018 at 12:05:52AM +0100, Niklas Söderlund wrote: > From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > On runtime power management resume, the host clock needs to be > enabled before calling tmio_mmc_reset. If the mmc device has a power > domain entry, the host clock is enabled via genpd_runtime_resume, > running before tmio_mmc_host_runtime_resume. If the mmc device has no > power domain entry, however, genpd_runtime_resume is not called. This > patch changes tmio_mmc_host_runtime_resume to enable the host clock > before calling tmio_mmc_reset. > > Based on work from Masaharu Hayakawa. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc/host/tmio_mmc_core.c index 8d64f6196f33e882..953562a12a0d6ebc 100644 --- a/drivers/mmc/host/tmio_mmc_core.c +++ b/drivers/mmc/host/tmio_mmc_core.c @@ -1328,8 +1328,8 @@ int tmio_mmc_host_runtime_resume(struct device *dev) { struct tmio_mmc_host *host = dev_get_drvdata(dev); - host->reset(host); tmio_mmc_clk_enable(host); + host->reset(host); if (host->clk_cache) host->set_clock(host, host->clk_cache);