From patchwork Mon Dec 10 20:45:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10722421 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 104AD6C5 for ; Mon, 10 Dec 2018 20:46:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 015792A531 for ; Mon, 10 Dec 2018 20:46:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E958C2A797; Mon, 10 Dec 2018 20:46:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C06D32A531 for ; Mon, 10 Dec 2018 20:46:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726912AbeLJUqD (ORCPT ); Mon, 10 Dec 2018 15:46:03 -0500 Received: from mout.kundenserver.de ([212.227.126.134]:60849 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726720AbeLJUqD (ORCPT ); Mon, 10 Dec 2018 15:46:03 -0500 Received: from wuerfel.lan ([109.192.41.194]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.129]) with ESMTPA (Nemesis) id 1N4yqC-1hUmoZ2uKy-010uIx; Mon, 10 Dec 2018 21:45:47 +0100 From: Arnd Bergmann To: Adrian Hunter , Ulf Hansson Cc: Arnd Bergmann , Vijay Viswanath , Evan Green , Sayali Lokhande , Veerabhadrarao Badiganti , "weiyongjun (A)" , Loic Poulain , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] mmc: sdhci-msm: avoid unused function warning Date: Mon, 10 Dec 2018 21:45:36 +0100 Message-Id: <20181210204546.2384299-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:zEJx0bDd6tl+VoEOfulBPFWryW46KUhq3qSGXgTOahAORc4HTlf YLDsReyLbx+mR/9gIMY9qjVGc00Sr+sNWGVjNfBuSDmafvfJ1YFTjtvlBNlIOh/ulCTKwA3 ow+7Mj8ufRLG/BjY6UnUwgzKVUADgI3OiGZWWGFoAYIUb0qT3PHpxXGELN8CliDHSPghEGF OwsBMw2mk1ADQWr9ZTaJQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:NqfvuMT9nos=:0j0QZvm8nWNgw80sNJn5Jc vvGI7FcycBG+pH1P+Z9N/ij4PVAWFUirvy/bRPGhBstQBRbf2iGCRJ0SUxlpkFXjQZeg0q00n ndPA8lK3UmHFDj0eBTOBUTAwYPCDR7ELwOJisKm2zt12T1e61OLPs3Qz6AgA5cBGh5gEkPwdP Dolf/zkRChAqEAZYmw+3T8tMIFPhUfqJrCcCdjnTK9K32EgjwdItUaGDu9dUTBxFJtcVFVXA2 fVuMSADh5YCKYjvanibpCLCdPB9xGy32/TvprhdyChF3u7XVzQ+dBgGvMx8vNHMDs9icYWDU/ nKRZ9igYLHMqwzdkGMAd9iFHymEg31sq9xeH3HkTQuEeOZKqh+QAi4oU8z4qJz9rDjejL7wiO 1OEgxqV3Qvwos9egtWeZTiOXbLRGwYlK+hvmF9EuMqt9cWPeq+g52NPe40y7N216M6JAvSv2+ 7iNNmYds88SvS/4Mxxe57q3BIev8oGKIkoiuu/ePyMq7dO7wNY12k2DWs3mVybQe+fpbHUD86 DmH3RiVwmXRsoMPFz/LzUqyZd/vdgnGdzL6AhbT+UjAzHXIf5ds4Ev+TGRs6RhJsc8H/zX+Da 5PXwL7JGu/z5uLJlyPh7pa2vlqnWHosrlxyn+akT3vxI413BSUjkgOLWsv89PWb9D1oJOHLYS 3Qn03gfMWKof4npNZI58yUGxAdlm+uwuKGOjQLfVfTI0hBVieyr1But4okThF7BaI9eTYIVoC TLeDE4REQBFw6AeYBKSy+5P0eK4lgWLLfRYiZg== Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The newly added sdhci_msm_restore_sdr_dll_config() function is only called if CONFIG_PM is enabled: drivers/mmc/host/sdhci-msm.c:1050:12: error: 'sdhci_msm_restore_sdr_dll_config' defined but not used [-Werror=unused-function] Better remove the incorrect #ifdef altogether and just use __maybe_unused, which is harder to get wrong. Fixes: ec3349733550 ("mmc: sdhci-msm: Re-initialize DLL if MCLK is gated dynamically") Signed-off-by: Arnd Bergmann Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-msm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index 5497a71abe07..d6c9ebd8d263 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc/host/sdhci-msm.c @@ -1997,8 +1997,7 @@ static int sdhci_msm_remove(struct platform_device *pdev) return 0; } -#ifdef CONFIG_PM -static int sdhci_msm_runtime_suspend(struct device *dev) +static __maybe_unused int sdhci_msm_runtime_suspend(struct device *dev) { struct sdhci_host *host = dev_get_drvdata(dev); struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); @@ -2010,7 +2009,7 @@ static int sdhci_msm_runtime_suspend(struct device *dev) return 0; } -static int sdhci_msm_runtime_resume(struct device *dev) +static __maybe_unused int sdhci_msm_runtime_resume(struct device *dev) { struct sdhci_host *host = dev_get_drvdata(dev); struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); @@ -2030,7 +2029,6 @@ static int sdhci_msm_runtime_resume(struct device *dev) return 0; } -#endif static const struct dev_pm_ops sdhci_msm_pm_ops = { SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,