| Message ID | 20191003040032.37696-3-vadivel.muruganx.ramuthevar@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mmc: sdhci-of-arasan: Add Support for Intel LGM SDXC | expand |
On 3/10/19 7:00 AM, Ramuthevar,Vadivel MuruganX wrote: > From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> > > The current arasan sdhci PHY configuration isn't compatible > with the PHY on Intel's LGM(Lightning Mountain) SoC devices. > > Therefore, add a new compatible, to adapt the Intel's LGM > SDXC PHY with arasan-sdhc controller to configure the PHY. > > Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> Aren't these patches already in v5.4-rc1
Hi Adrian, Thank you for the comments. On 3/10/2019 3:02 PM, Adrian Hunter wrote: > On 3/10/19 7:00 AM, Ramuthevar,Vadivel MuruganX wrote: >> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> >> >> The current arasan sdhci PHY configuration isn't compatible >> with the PHY on Intel's LGM(Lightning Mountain) SoC devices. >> >> Therefore, add a new compatible, to adapt the Intel's LGM >> SDXC PHY with arasan-sdhc controller to configure the PHY. >> >> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> > Aren't these patches already in v5.4-rc1 No, these patches are not there in v5.4-rc1. The one which is in v5.4-rc1 supports only eMMC, does not SD/SDIO, so these patches are required. --- With Best Regards Vadivel Murugan
Hi Adrian, On 3/10/2019 3:46 PM, Ramuthevar, Vadivel MuruganX wrote: > Hi Adrian, > > Thank you for the comments. > > On 3/10/2019 3:02 PM, Adrian Hunter wrote: >> On 3/10/19 7:00 AM, Ramuthevar,Vadivel MuruganX wrote: >>> From: Ramuthevar Vadivel Murugan >>> <vadivel.muruganx.ramuthevar@linux.intel.com> >>> >>> The current arasan sdhci PHY configuration isn't compatible >>> with the PHY on Intel's LGM(Lightning Mountain) SoC devices. >>> >>> Therefore, add a new compatible, to adapt the Intel's LGM >>> SDXC PHY with arasan-sdhc controller to configure the PHY. >>> >>> Signed-off-by: Ramuthevar Vadivel Murugan >>> <vadivel.muruganx.ramuthevar@linux.intel.com> >> Aren't these patches already in v5.4-rc1 > > No, these patches are not there in v5.4-rc1. > > The one which is in v5.4-rc1 supports only eMMC, does not SD/SDIO, so > these patches are required. > can you please provide your suggestions and opinions further on the above reply, to proceed, Thanks! > --- > With Best Regards > Vadivel Murugan
On 3/10/19 7:00 AM, Ramuthevar,Vadivel MuruganX wrote: > From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> > > The current arasan sdhci PHY configuration isn't compatible > with the PHY on Intel's LGM(Lightning Mountain) SoC devices. > > Therefore, add a new compatible, to adapt the Intel's LGM > SDXC PHY with arasan-sdhc controller to configure the PHY. > > Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > --- > drivers/mmc/host/sdhci-of-arasan.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c > index 7023cbec4017..55de839a8a5e 100644 > --- a/drivers/mmc/host/sdhci-of-arasan.c > +++ b/drivers/mmc/host/sdhci-of-arasan.c > @@ -120,6 +120,12 @@ static const struct sdhci_arasan_soc_ctl_map intel_lgm_emmc_soc_ctl_map = { > .hiword_update = false, > }; > > +static const struct sdhci_arasan_soc_ctl_map intel_lgm_sdxc_soc_ctl_map = { > + .baseclkfreq = { .reg = 0x80, .width = 8, .shift = 2 }, > + .clockmultiplier = { .reg = 0, .width = -1, .shift = -1 }, > + .hiword_update = false, > +}; > + > /** > * sdhci_arasan_syscon_write - Write to a field in soc_ctl registers > * > @@ -384,6 +390,11 @@ static struct sdhci_arasan_of_data intel_lgm_emmc_data = { > .pdata = &sdhci_arasan_cqe_pdata, > }; > > +static struct sdhci_arasan_of_data intel_lgm_sdxc_data = { > + .soc_ctl_map = &intel_lgm_sdxc_soc_ctl_map, > + .pdata = &sdhci_arasan_cqe_pdata, > +}; > + > #ifdef CONFIG_PM_SLEEP > /** > * sdhci_arasan_suspend - Suspend method for the driver > @@ -489,6 +500,10 @@ static const struct of_device_id sdhci_arasan_of_match[] = { > .compatible = "intel,lgm-sdhci-5.1-emmc", > .data = &intel_lgm_emmc_data, > }, > + { > + .compatible = "intel,lgm-sdhci-5.1-sdxc", > + .data = &intel_lgm_sdxc_data, > + }, > /* Generic compatible below here */ > { > .compatible = "arasan,sdhci-8.9a", >
On Wed, Oct 09, 2019 at 09:06:16AM +0800, Ramuthevar, Vadivel MuruganX wrote: > Hi Adrian, > > Thank you for the Acked-by, will add *Acked-by* in the next-patch. Please, stop top-posting. Besides that, there is no need for next version if the only comments you got are ACKs. Rb:s, etc.
Hi Andy, On 9/10/2019 5:40 PM, Andy Shevchenko wrote: > On Wed, Oct 09, 2019 at 09:06:16AM +0800, Ramuthevar, Vadivel MuruganX wrote: >> Hi Adrian, >> >> Thank you for the Acked-by, will add *Acked-by* in the next-patch. > Please, stop top-posting. > > Besides that, there is no need for next version if the only comments you got > are ACKs. Rb:s, etc. Sure, Thanks! --- Regards Vadivel
diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c index 7023cbec4017..55de839a8a5e 100644 --- a/drivers/mmc/host/sdhci-of-arasan.c +++ b/drivers/mmc/host/sdhci-of-arasan.c @@ -120,6 +120,12 @@ static const struct sdhci_arasan_soc_ctl_map intel_lgm_emmc_soc_ctl_map = { .hiword_update = false, }; +static const struct sdhci_arasan_soc_ctl_map intel_lgm_sdxc_soc_ctl_map = { + .baseclkfreq = { .reg = 0x80, .width = 8, .shift = 2 }, + .clockmultiplier = { .reg = 0, .width = -1, .shift = -1 }, + .hiword_update = false, +}; + /** * sdhci_arasan_syscon_write - Write to a field in soc_ctl registers * @@ -384,6 +390,11 @@ static struct sdhci_arasan_of_data intel_lgm_emmc_data = { .pdata = &sdhci_arasan_cqe_pdata, }; +static struct sdhci_arasan_of_data intel_lgm_sdxc_data = { + .soc_ctl_map = &intel_lgm_sdxc_soc_ctl_map, + .pdata = &sdhci_arasan_cqe_pdata, +}; + #ifdef CONFIG_PM_SLEEP /** * sdhci_arasan_suspend - Suspend method for the driver @@ -489,6 +500,10 @@ static const struct of_device_id sdhci_arasan_of_match[] = { .compatible = "intel,lgm-sdhci-5.1-emmc", .data = &intel_lgm_emmc_data, }, + { + .compatible = "intel,lgm-sdhci-5.1-sdxc", + .data = &intel_lgm_sdxc_data, + }, /* Generic compatible below here */ { .compatible = "arasan,sdhci-8.9a",