Message ID | 20200327043639.6564-1-tangbin@cmss.chinamobile.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | mmc:cavium-octeon: remove nonsense variable coercion | expand |
On Fri, 27 Mar 2020 at 05:36, Tang Bin <tangbin@cmss.chinamobile.com> wrote: > > In this function, the variable 'base' is already 'void __iomem *base', > and the return function 'devm_platform_ioremap_resource()' also returns > this type, so the mandatory definition here is redundant. > > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/cavium-octeon.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/cavium-octeon.c b/drivers/mmc/host/cavium-octeon.c > index 916746c6c..e299cdd1e 100644 > --- a/drivers/mmc/host/cavium-octeon.c > +++ b/drivers/mmc/host/cavium-octeon.c > @@ -207,13 +207,13 @@ static int octeon_mmc_probe(struct platform_device *pdev) > base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(base)) > return PTR_ERR(base); > - host->base = (void __iomem *)base; > + host->base = base; > host->reg_off = 0; > > base = devm_platform_ioremap_resource(pdev, 1); > if (IS_ERR(base)) > return PTR_ERR(base); > - host->dma_base = (void __iomem *)base; > + host->dma_base = base; > /* > * To keep the register addresses shared we intentionaly use > * a negative offset here, first register used on Octeon therefore > -- > 2.20.1.windows.1 > > >
diff --git a/drivers/mmc/host/cavium-octeon.c b/drivers/mmc/host/cavium-octeon.c index 916746c6c..e299cdd1e 100644 --- a/drivers/mmc/host/cavium-octeon.c +++ b/drivers/mmc/host/cavium-octeon.c @@ -207,13 +207,13 @@ static int octeon_mmc_probe(struct platform_device *pdev) base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(base)) return PTR_ERR(base); - host->base = (void __iomem *)base; + host->base = base; host->reg_off = 0; base = devm_platform_ioremap_resource(pdev, 1); if (IS_ERR(base)) return PTR_ERR(base); - host->dma_base = (void __iomem *)base; + host->dma_base = base; /* * To keep the register addresses shared we intentionaly use * a negative offset here, first register used on Octeon therefore
In this function, the variable 'base' is already 'void __iomem *base', and the return function 'devm_platform_ioremap_resource()' also returns this type, so the mandatory definition here is redundant. Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> --- drivers/mmc/host/cavium-octeon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)