| Message ID | 20200608162226.3259186-1-hslester96@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mmc: sdhci-of-arasan: Add missed checks for devm_clk_register() | expand |
Hi, On Mon, Jun 8, 2020 at 9:22 AM Chuhong Yuan <hslester96@gmail.com> wrote: > > These functions do not check the return value of devm_clk_register(): > - sdhci_arasan_register_sdcardclk() > - sdhci_arasan_register_sampleclk() > > Therefore, add the missed checks to fix them. > > Fixes: c390f2110adf1 ("mmc: sdhci-of-arasan: Add ability to export card clock") > Signed-off-by: Chuhong Yuan <hslester96@gmail.com> > --- > drivers/mmc/host/sdhci-of-arasan.c | 4 ++++ > 1 file changed, 4 insertions(+) Reviewed-by: Douglas Anderson <dianders@chromium.org>
On Mon, 8 Jun 2020 at 18:22, Chuhong Yuan <hslester96@gmail.com> wrote: > > These functions do not check the return value of devm_clk_register(): > - sdhci_arasan_register_sdcardclk() > - sdhci_arasan_register_sampleclk() > > Therefore, add the missed checks to fix them. > > Fixes: c390f2110adf1 ("mmc: sdhci-of-arasan: Add ability to export card clock") > Signed-off-by: Chuhong Yuan <hslester96@gmail.com> Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-of-arasan.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c > index db9b544465cd..fb26e743e1fd 100644 > --- a/drivers/mmc/host/sdhci-of-arasan.c > +++ b/drivers/mmc/host/sdhci-of-arasan.c > @@ -1299,6 +1299,8 @@ sdhci_arasan_register_sdcardclk(struct sdhci_arasan_data *sdhci_arasan, > clk_data->sdcardclk_hw.init = &sdcardclk_init; > clk_data->sdcardclk = > devm_clk_register(dev, &clk_data->sdcardclk_hw); > + if (IS_ERR(clk_data->sdcardclk)) > + return PTR_ERR(clk_data->sdcardclk); > clk_data->sdcardclk_hw.init = NULL; > > ret = of_clk_add_provider(np, of_clk_src_simple_get, > @@ -1349,6 +1351,8 @@ sdhci_arasan_register_sampleclk(struct sdhci_arasan_data *sdhci_arasan, > clk_data->sampleclk_hw.init = &sampleclk_init; > clk_data->sampleclk = > devm_clk_register(dev, &clk_data->sampleclk_hw); > + if (IS_ERR(clk_data->sampleclk)) > + return PTR_ERR(clk_data->sampleclk); > clk_data->sampleclk_hw.init = NULL; > > ret = of_clk_add_provider(np, of_clk_src_simple_get, > -- > 2.26.2 >
diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c index db9b544465cd..fb26e743e1fd 100644 --- a/drivers/mmc/host/sdhci-of-arasan.c +++ b/drivers/mmc/host/sdhci-of-arasan.c @@ -1299,6 +1299,8 @@ sdhci_arasan_register_sdcardclk(struct sdhci_arasan_data *sdhci_arasan, clk_data->sdcardclk_hw.init = &sdcardclk_init; clk_data->sdcardclk = devm_clk_register(dev, &clk_data->sdcardclk_hw); + if (IS_ERR(clk_data->sdcardclk)) + return PTR_ERR(clk_data->sdcardclk); clk_data->sdcardclk_hw.init = NULL; ret = of_clk_add_provider(np, of_clk_src_simple_get, @@ -1349,6 +1351,8 @@ sdhci_arasan_register_sampleclk(struct sdhci_arasan_data *sdhci_arasan, clk_data->sampleclk_hw.init = &sampleclk_init; clk_data->sampleclk = devm_clk_register(dev, &clk_data->sampleclk_hw); + if (IS_ERR(clk_data->sampleclk)) + return PTR_ERR(clk_data->sampleclk); clk_data->sampleclk_hw.init = NULL; ret = of_clk_add_provider(np, of_clk_src_simple_get,
These functions do not check the return value of devm_clk_register(): - sdhci_arasan_register_sdcardclk() - sdhci_arasan_register_sampleclk() Therefore, add the missed checks to fix them. Fixes: c390f2110adf1 ("mmc: sdhci-of-arasan: Add ability to export card clock") Signed-off-by: Chuhong Yuan <hslester96@gmail.com> --- drivers/mmc/host/sdhci-of-arasan.c | 4 ++++ 1 file changed, 4 insertions(+)