diff mbox series

[-next] mmc: sdhci-msm: Make function sdhci_msm_dump_vendor_regs() static

Message ID 20200702020347.77214-1-weiyongjun1@huawei.com (mailing list archive)
State New, archived
Headers show
Series [-next] mmc: sdhci-msm: Make function sdhci_msm_dump_vendor_regs() static | expand

Commit Message

weiyongjun (A) July 2, 2020, 2:03 a.m. UTC
From: Hulk Robot <hulkci@huawei.com>

Fix sparse build warning:

drivers/mmc/host/sdhci-msm.c:1888:6: warning:
 symbol 'sdhci_msm_dump_vendor_regs' was not declared. Should it be static?

Signed-off-by: Hulk Robot <hulkci@huawei.com>
---
 drivers/mmc/host/sdhci-msm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Adrian Hunter July 2, 2020, 6:45 a.m. UTC | #1
On 2/07/20 5:03 am, Wei Yongjun wrote:
> From: Hulk Robot <hulkci@huawei.com>
> 
> Fix sparse build warning:
> 
> drivers/mmc/host/sdhci-msm.c:1888:6: warning:
>  symbol 'sdhci_msm_dump_vendor_regs' was not declared. Should it be static?
> 
> Signed-off-by: Hulk Robot <hulkci@huawei.com>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
>  drivers/mmc/host/sdhci-msm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index 15c42b059240..66f755f94d2c 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -1885,7 +1885,7 @@ static void sdhci_msm_reset(struct sdhci_host *host, u8 mask)
>  #define SDHCI_MSM_DUMP(f, x...) \
>  	pr_err("%s: " DRIVER_NAME ": " f, mmc_hostname(host->mmc), ## x)
>  
> -void sdhci_msm_dump_vendor_regs(struct sdhci_host *host)
> +static void sdhci_msm_dump_vendor_regs(struct sdhci_host *host)
>  {
>  	struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
>  	struct sdhci_msm_host *msm_host = sdhci_pltfm_priv(pltfm_host);
>
Ulf Hansson July 6, 2020, 2:49 p.m. UTC | #2
On Thu, 2 Jul 2020 at 03:53, Wei Yongjun <weiyongjun1@huawei.com> wrote:
>
> From: Hulk Robot <hulkci@huawei.com>
>
> Fix sparse build warning:
>
> drivers/mmc/host/sdhci-msm.c:1888:6: warning:
>  symbol 'sdhci_msm_dump_vendor_regs' was not declared. Should it be static?
>
> Signed-off-by: Hulk Robot <hulkci@huawei.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci-msm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index 15c42b059240..66f755f94d2c 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -1885,7 +1885,7 @@ static void sdhci_msm_reset(struct sdhci_host *host, u8 mask)
>  #define SDHCI_MSM_DUMP(f, x...) \
>         pr_err("%s: " DRIVER_NAME ": " f, mmc_hostname(host->mmc), ## x)
>
> -void sdhci_msm_dump_vendor_regs(struct sdhci_host *host)
> +static void sdhci_msm_dump_vendor_regs(struct sdhci_host *host)
>  {
>         struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
>         struct sdhci_msm_host *msm_host = sdhci_pltfm_priv(pltfm_host);
>
diff mbox series

Patch

diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
index 15c42b059240..66f755f94d2c 100644
--- a/drivers/mmc/host/sdhci-msm.c
+++ b/drivers/mmc/host/sdhci-msm.c
@@ -1885,7 +1885,7 @@  static void sdhci_msm_reset(struct sdhci_host *host, u8 mask)
 #define SDHCI_MSM_DUMP(f, x...) \
 	pr_err("%s: " DRIVER_NAME ": " f, mmc_hostname(host->mmc), ## x)
 
-void sdhci_msm_dump_vendor_regs(struct sdhci_host *host)
+static void sdhci_msm_dump_vendor_regs(struct sdhci_host *host)
 {
 	struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
 	struct sdhci_msm_host *msm_host = sdhci_pltfm_priv(pltfm_host);