diff mbox series

[-next] mmc: mediatek: make function msdc_cqe_disable() static

Message ID 20200727171129.2945-1-weiyongjun1@huawei.com
State New
Headers show
Series [-next] mmc: mediatek: make function msdc_cqe_disable() static | expand

Commit Message

Wei Yongjun July 27, 2020, 5:11 p.m. UTC
The sparse tool complains as follows:

drivers/mmc/host/mtk-sd.c:2269:6: warning:
 symbol 'msdc_cqe_disable' was not declared. Should it be static?

This function is not used outside of mtk-sd.c, so this commit
marks it static.

Fixes: 88bd652b3c74 ("mmc: mediatek: command queue support")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/mmc/host/mtk-sd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chun-Hung Wu July 31, 2020, 6:54 a.m. UTC | #1
On Tue, 2020-07-28 at 01:11 +0800, Wei Yongjun wrote:
> The sparse tool complains as follows:
> 
> drivers/mmc/host/mtk-sd.c:2269:6: warning:
>  symbol 'msdc_cqe_disable' was not declared. Should it be static?
> 
> This function is not used outside of mtk-sd.c, so this commit
> marks it static.
> 
> Fixes: 88bd652b3c74 ("mmc: mediatek: command queue support")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/mmc/host/mtk-sd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 734e403a142e..4e2583f69a63 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -2266,7 +2266,7 @@ static void msdc_cqe_enable(struct mmc_host *mmc)
>  	msdc_set_timeout(host, 1000000000ULL, 0);
>  }
>  
> -void msdc_cqe_disable(struct mmc_host *mmc, bool recovery)
> +static void msdc_cqe_disable(struct mmc_host *mmc, bool recovery)
>  {
>  	struct msdc_host *host = mmc_priv(mmc);
>  
> 

Acked-by: Chun-Hung Wu <chun-hung.wu@mediatek.com>
Ulf Hansson Aug. 5, 2020, 6:29 a.m. UTC | #2
On Mon, 27 Jul 2020 at 19:11, Wei Yongjun <weiyongjun1@huawei.com> wrote:
>
> The sparse tool complains as follows:
>
> drivers/mmc/host/mtk-sd.c:2269:6: warning:
>  symbol 'msdc_cqe_disable' was not declared. Should it be static?
>
> This function is not used outside of mtk-sd.c, so this commit
> marks it static.
>
> Fixes: 88bd652b3c74 ("mmc: mediatek: command queue support")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/mtk-sd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 734e403a142e..4e2583f69a63 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -2266,7 +2266,7 @@ static void msdc_cqe_enable(struct mmc_host *mmc)
>         msdc_set_timeout(host, 1000000000ULL, 0);
>  }
>
> -void msdc_cqe_disable(struct mmc_host *mmc, bool recovery)
> +static void msdc_cqe_disable(struct mmc_host *mmc, bool recovery)
>  {
>         struct msdc_host *host = mmc_priv(mmc);
>
>
diff mbox series

Patch

diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 734e403a142e..4e2583f69a63 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -2266,7 +2266,7 @@  static void msdc_cqe_enable(struct mmc_host *mmc)
 	msdc_set_timeout(host, 1000000000ULL, 0);
 }
 
-void msdc_cqe_disable(struct mmc_host *mmc, bool recovery)
+static void msdc_cqe_disable(struct mmc_host *mmc, bool recovery)
 {
 	struct msdc_host *host = mmc_priv(mmc);