| Message ID | 20200817115838.2981-1-wsa@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mmc: test: remove ambiguity in test description | expand |
Hi Wolfram, Thanks for your work. On 2020-08-17 13:58:38 +0200, Wolfram Sang wrote: > From: Wolfram Sang <wsa+renesas@sang-engineering.com> > > When reading the test description, I thought a correction of the > xfer_size was tested, which is not the case. It is tested that the > xfer_size is correct. Use 'proper xfer_size' to remove this ambiguity. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> For what it's worth, Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > > This may be bike-shedding and I am not offended if you think it is > minor. However, I ended up looking at the source wondering where is what > automatically corrected. > > drivers/mmc/core/mmc_test.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c > index c21b3cb71775..152e7525ed33 100644 > --- a/drivers/mmc/core/mmc_test.c > +++ b/drivers/mmc/core/mmc_test.c > @@ -2669,22 +2669,22 @@ static const struct mmc_test_case mmc_test_cases[] = { > }, > > { > - .name = "Correct xfer_size at write (start failure)", > + .name = "Proper xfer_size at write (start failure)", > .run = mmc_test_xfersize_write, > }, > > { > - .name = "Correct xfer_size at read (start failure)", > + .name = "Proper xfer_size at read (start failure)", > .run = mmc_test_xfersize_read, > }, > > { > - .name = "Correct xfer_size at write (midway failure)", > + .name = "Proper xfer_size at write (midway failure)", > .run = mmc_test_multi_xfersize_write, > }, > > { > - .name = "Correct xfer_size at read (midway failure)", > + .name = "Proper xfer_size at read (midway failure)", > .run = mmc_test_multi_xfersize_read, > }, > > -- > 2.20.1 >
On Mon, 17 Aug 2020 at 13:58, Wolfram Sang <wsa@kernel.org> wrote: > > From: Wolfram Sang <wsa+renesas@sang-engineering.com> > > When reading the test description, I thought a correction of the > xfer_size was tested, which is not the case. It is tested that the > xfer_size is correct. Use 'proper xfer_size' to remove this ambiguity. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Applied for next, thanks! Kind regards Uffe > --- > > This may be bike-shedding and I am not offended if you think it is > minor. However, I ended up looking at the source wondering where is what > automatically corrected. > > drivers/mmc/core/mmc_test.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c > index c21b3cb71775..152e7525ed33 100644 > --- a/drivers/mmc/core/mmc_test.c > +++ b/drivers/mmc/core/mmc_test.c > @@ -2669,22 +2669,22 @@ static const struct mmc_test_case mmc_test_cases[] = { > }, > > { > - .name = "Correct xfer_size at write (start failure)", > + .name = "Proper xfer_size at write (start failure)", > .run = mmc_test_xfersize_write, > }, > > { > - .name = "Correct xfer_size at read (start failure)", > + .name = "Proper xfer_size at read (start failure)", > .run = mmc_test_xfersize_read, > }, > > { > - .name = "Correct xfer_size at write (midway failure)", > + .name = "Proper xfer_size at write (midway failure)", > .run = mmc_test_multi_xfersize_write, > }, > > { > - .name = "Correct xfer_size at read (midway failure)", > + .name = "Proper xfer_size at read (midway failure)", > .run = mmc_test_multi_xfersize_read, > }, > > -- > 2.20.1 >
diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c index c21b3cb71775..152e7525ed33 100644 --- a/drivers/mmc/core/mmc_test.c +++ b/drivers/mmc/core/mmc_test.c @@ -2669,22 +2669,22 @@ static const struct mmc_test_case mmc_test_cases[] = { }, { - .name = "Correct xfer_size at write (start failure)", + .name = "Proper xfer_size at write (start failure)", .run = mmc_test_xfersize_write, }, { - .name = "Correct xfer_size at read (start failure)", + .name = "Proper xfer_size at read (start failure)", .run = mmc_test_xfersize_read, }, { - .name = "Correct xfer_size at write (midway failure)", + .name = "Proper xfer_size at write (midway failure)", .run = mmc_test_multi_xfersize_write, }, { - .name = "Correct xfer_size at read (midway failure)", + .name = "Proper xfer_size at read (midway failure)", .run = mmc_test_multi_xfersize_read, },