diff mbox series

mmc: meson-gx: use wrapper to avoid accessing internal vars

Message ID 20200831102324.12566-1-wsa+renesas@sang-engineering.com
State New
Headers show
Series mmc: meson-gx: use wrapper to avoid accessing internal vars | expand

Commit Message

Wolfram Sang Aug. 31, 2020, 10:23 a.m. UTC
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---

Only buildtested. Found while analyzing retune-handling in the core.

 drivers/mmc/host/meson-gx-mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kevin Hilman Aug. 31, 2020, 6:35 p.m. UTC | #1
Wolfram Sang <wsa+renesas@sang-engineering.com> writes:

> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Kevin Hilman <khilman@baylibre.com>

> ---
>
> Only buildtested. Found while analyzing retune-handling in the core.
>
>  drivers/mmc/host/meson-gx-mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index 08a3b1c05acb..a1db8685e30e 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -521,7 +521,7 @@ static int meson_mmc_resampling_tuning(struct mmc_host *mmc, u32 opcode)
>  	val |= ADJUST_ADJ_EN;
>  	writel(val, host->regs + host->data->adjust);
>  
> -	if (mmc->doing_retune)
> +	if (mmc_doing_retune(mmc))
>  		dly = FIELD_GET(ADJUST_ADJ_DELAY_MASK, val) + 1;
>  	else
>  		dly = 0;
> -- 
> 2.20.1
Ulf Hansson Sept. 2, 2020, 9:03 a.m. UTC | #2
On Mon, 31 Aug 2020 at 12:23, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>
> Only buildtested. Found while analyzing retune-handling in the core.
>
>  drivers/mmc/host/meson-gx-mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index 08a3b1c05acb..a1db8685e30e 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -521,7 +521,7 @@ static int meson_mmc_resampling_tuning(struct mmc_host *mmc, u32 opcode)
>         val |= ADJUST_ADJ_EN;
>         writel(val, host->regs + host->data->adjust);
>
> -       if (mmc->doing_retune)
> +       if (mmc_doing_retune(mmc))
>                 dly = FIELD_GET(ADJUST_ADJ_DELAY_MASK, val) + 1;
>         else
>                 dly = 0;
> --
> 2.20.1
>
diff mbox series

Patch

diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index 08a3b1c05acb..a1db8685e30e 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -521,7 +521,7 @@  static int meson_mmc_resampling_tuning(struct mmc_host *mmc, u32 opcode)
 	val |= ADJUST_ADJ_EN;
 	writel(val, host->regs + host->data->adjust);
 
-	if (mmc->doing_retune)
+	if (mmc_doing_retune(mmc))
 		dly = FIELD_GET(ADJUST_ADJ_DELAY_MASK, val) + 1;
 	else
 		dly = 0;