diff mbox series

[2/2] dt-bindings: mmc: mmc-pwreq-simple: Accept more than one reset GPIO

Message ID 20200831161147.13515-2-krzk@kernel.org
State New
Headers show
Series [1/2] dt-bindings: mfd: google,cros-ec: Use unevaluatedProperties | expand

Commit Message

Krzysztof Kozlowski Aug. 31, 2020, 4:11 p.m. UTC
There might be multiple reset GPIOs but dtschema has trouble parsing it
if there are no maxItems:

  arch/arm/boot/dts/exynos5250-snow.dt.yaml: mmc3_pwrseq: reset-gpios: [[20, 2, 1], [20, 1, 1]] is too long
    From schema: Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Ulf Hansson Sept. 2, 2020, 9:03 a.m. UTC | #1
On Mon, 31 Aug 2020 at 18:11, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> There might be multiple reset GPIOs but dtschema has trouble parsing it
> if there are no maxItems:
>
>   arch/arm/boot/dts/exynos5250-snow.dt.yaml: mmc3_pwrseq: reset-gpios: [[20, 2, 1], [20, 1, 1]] is too long
>     From schema: Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml
> index 449215444723..8d625f903856 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml
> @@ -20,6 +20,8 @@ properties:
>
>    reset-gpios:
>      minItems: 1
> +    # Put some limit to avoid false warnings
> +    maxItems: 32

Not sure what number to pick. I guess two should be enough, but on the
other hand it doesn't really matter.

>      description:
>        contains a list of GPIO specifiers. The reset GPIOs are asserted
>        at initialization and prior we start the power up procedure of the card.
> --
> 2.17.1
>

Applied for next, thanks!

Kind regards
Uffe
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml
index 449215444723..8d625f903856 100644
--- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml
+++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml
@@ -20,6 +20,8 @@  properties:
 
   reset-gpios:
     minItems: 1
+    # Put some limit to avoid false warnings
+    maxItems: 32
     description:
       contains a list of GPIO specifiers. The reset GPIOs are asserted
       at initialization and prior we start the power up procedure of the card.