| Message ID | 20201129203116.11987-1-adrien.grassein@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] dt-bindings: mmc: add an option to disable HS400 for fsl | expand |
On Sun, 29 Nov 2020 at 21:31, Adrien Grassein <adrien.grassein@gmail.com> wrote: > > Add an option to disable the hs400 support in the fsl esdhc > driver. > > Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com> > --- > Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > index e71d13c2d109..070b40ae8c44 100644 > --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > @@ -101,6 +101,10 @@ properties: > If not use this property, driver default set the delay target to value 7. > Only eMMC HS400 mode need to take care of this property. > default: 0 > + fsl,no-mmc-hs400: > + description: | > + boolean, if present, indicate to disable mmc-hs400 support. > + type: boolean You need to disable hs400, because the sdhci capability register wrongly claims it to be supported, right? May I suggest using the DT property "sdhci-caps-mask" instead? Kind regards Uffe
Hello, Thanks, it's working with your suggestion. You can delete/abandon these patches. Thanks a lot, Regards, Adrien Le ven. 4 déc. 2020 à 14:18, Ulf Hansson <ulf.hansson@linaro.org> a écrit : > > On Sun, 29 Nov 2020 at 21:31, Adrien Grassein <adrien.grassein@gmail.com> wrote: > > > > Add an option to disable the hs400 support in the fsl esdhc > > driver. > > > > Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com> > > --- > > Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > index e71d13c2d109..070b40ae8c44 100644 > > --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > @@ -101,6 +101,10 @@ properties: > > If not use this property, driver default set the delay target to value 7. > > Only eMMC HS400 mode need to take care of this property. > > default: 0 > > + fsl,no-mmc-hs400: > > + description: | > > + boolean, if present, indicate to disable mmc-hs400 support. > > + type: boolean > > You need to disable hs400, because the sdhci capability register > wrongly claims it to be supported, right? > > May I suggest using the DT property "sdhci-caps-mask" instead? > > Kind regards > Uffe
diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml index e71d13c2d109..070b40ae8c44 100644 --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml @@ -101,6 +101,10 @@ properties: If not use this property, driver default set the delay target to value 7. Only eMMC HS400 mode need to take care of this property. default: 0 + fsl,no-mmc-hs400: + description: | + boolean, if present, indicate to disable mmc-hs400 support. + type: boolean required: - compatible
Add an option to disable the hs400 support in the fsl esdhc driver. Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com> --- Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 4 ++++ 1 file changed, 4 insertions(+)