| Message ID | 20210409015424.3277212-1-jiayang5@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] mmc: sdhci-msm: Remove unnecessary error log | expand |
On Fri, Apr 09, 2021 at 09:54:24AM +0800, Jia Yang wrote: > devm_ioremap_resource() has recorded error log, so it's > unnecessary to record log again. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Jia Yang <jiayang5@huawei.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Thanks, Mani > --- > drivers/mmc/host/sdhci-msm.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c > index d170c919e6e4..e44b7a66b73c 100644 > --- a/drivers/mmc/host/sdhci-msm.c > +++ b/drivers/mmc/host/sdhci-msm.c > @@ -1863,7 +1863,6 @@ static int sdhci_msm_ice_init(struct sdhci_msm_host *msm_host, > struct mmc_host *mmc = msm_host->mmc; > struct device *dev = mmc_dev(mmc); > struct resource *res; > - int err; > > if (!(cqhci_readl(cq_host, CQHCI_CAP) & CQHCI_CAP_CS)) > return 0; > @@ -1881,11 +1880,8 @@ static int sdhci_msm_ice_init(struct sdhci_msm_host *msm_host, > } > > msm_host->ice_mem = devm_ioremap_resource(dev, res); > - if (IS_ERR(msm_host->ice_mem)) { > - err = PTR_ERR(msm_host->ice_mem); > - dev_err(dev, "Failed to map ICE registers; err=%d\n", err); > - return err; > - } > + if (IS_ERR(msm_host->ice_mem)) > + return PTR_ERR(msm_host->ice_mem); > > if (!sdhci_msm_ice_supported(msm_host)) > goto disable; > -- > 2.25.1 >
On Fri, 9 Apr 2021 at 03:44, Jia Yang <jiayang5@huawei.com> wrote: > > devm_ioremap_resource() has recorded error log, so it's > unnecessary to record log again. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Jia Yang <jiayang5@huawei.com> Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-msm.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c > index d170c919e6e4..e44b7a66b73c 100644 > --- a/drivers/mmc/host/sdhci-msm.c > +++ b/drivers/mmc/host/sdhci-msm.c > @@ -1863,7 +1863,6 @@ static int sdhci_msm_ice_init(struct sdhci_msm_host *msm_host, > struct mmc_host *mmc = msm_host->mmc; > struct device *dev = mmc_dev(mmc); > struct resource *res; > - int err; > > if (!(cqhci_readl(cq_host, CQHCI_CAP) & CQHCI_CAP_CS)) > return 0; > @@ -1881,11 +1880,8 @@ static int sdhci_msm_ice_init(struct sdhci_msm_host *msm_host, > } > > msm_host->ice_mem = devm_ioremap_resource(dev, res); > - if (IS_ERR(msm_host->ice_mem)) { > - err = PTR_ERR(msm_host->ice_mem); > - dev_err(dev, "Failed to map ICE registers; err=%d\n", err); > - return err; > - } > + if (IS_ERR(msm_host->ice_mem)) > + return PTR_ERR(msm_host->ice_mem); > > if (!sdhci_msm_ice_supported(msm_host)) > goto disable; > -- > 2.25.1 >
diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index d170c919e6e4..e44b7a66b73c 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc/host/sdhci-msm.c @@ -1863,7 +1863,6 @@ static int sdhci_msm_ice_init(struct sdhci_msm_host *msm_host, struct mmc_host *mmc = msm_host->mmc; struct device *dev = mmc_dev(mmc); struct resource *res; - int err; if (!(cqhci_readl(cq_host, CQHCI_CAP) & CQHCI_CAP_CS)) return 0; @@ -1881,11 +1880,8 @@ static int sdhci_msm_ice_init(struct sdhci_msm_host *msm_host, } msm_host->ice_mem = devm_ioremap_resource(dev, res); - if (IS_ERR(msm_host->ice_mem)) { - err = PTR_ERR(msm_host->ice_mem); - dev_err(dev, "Failed to map ICE registers; err=%d\n", err); - return err; - } + if (IS_ERR(msm_host->ice_mem)) + return PTR_ERR(msm_host->ice_mem); if (!sdhci_msm_ice_supported(msm_host)) goto disable;
devm_ioremap_resource() has recorded error log, so it's unnecessary to record log again. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Jia Yang <jiayang5@huawei.com> --- drivers/mmc/host/sdhci-msm.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)