| Message ID | 20210409023349.3325907-1-qiulaibin@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] mmc: owl-mmc: Remove unnecessary error log | expand |
On Fri, Apr 09, 2021 at 10:33:49AM +0800, Laibin Qiu wrote: > devm_ioremap_resource() has recorded error log, so it's > unnecessary to record log again. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Laibin Qiu <qiulaibin@huawei.com> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org> Thanks, Mani > --- > drivers/mmc/host/owl-mmc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c > index 5490962dc8e5..3dc143b03939 100644 > --- a/drivers/mmc/host/owl-mmc.c > +++ b/drivers/mmc/host/owl-mmc.c > @@ -581,7 +581,6 @@ static int owl_mmc_probe(struct platform_device *pdev) > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > owl_host->base = devm_ioremap_resource(&pdev->dev, res); > if (IS_ERR(owl_host->base)) { > - dev_err(&pdev->dev, "Failed to remap registers\n"); > ret = PTR_ERR(owl_host->base); > goto err_free_host; > } > -- > 2.25.1 >
On Fri, 9 Apr 2021 at 04:24, Laibin Qiu <qiulaibin@huawei.com> wrote: > > devm_ioremap_resource() has recorded error log, so it's > unnecessary to record log again. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Laibin Qiu <qiulaibin@huawei.com> Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/owl-mmc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c > index 5490962dc8e5..3dc143b03939 100644 > --- a/drivers/mmc/host/owl-mmc.c > +++ b/drivers/mmc/host/owl-mmc.c > @@ -581,7 +581,6 @@ static int owl_mmc_probe(struct platform_device *pdev) > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > owl_host->base = devm_ioremap_resource(&pdev->dev, res); > if (IS_ERR(owl_host->base)) { > - dev_err(&pdev->dev, "Failed to remap registers\n"); > ret = PTR_ERR(owl_host->base); > goto err_free_host; > } > -- > 2.25.1 >
diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c index 5490962dc8e5..3dc143b03939 100644 --- a/drivers/mmc/host/owl-mmc.c +++ b/drivers/mmc/host/owl-mmc.c @@ -581,7 +581,6 @@ static int owl_mmc_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); owl_host->base = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(owl_host->base)) { - dev_err(&pdev->dev, "Failed to remap registers\n"); ret = PTR_ERR(owl_host->base); goto err_free_host; }
devm_ioremap_resource() has recorded error log, so it's unnecessary to record log again. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Laibin Qiu <qiulaibin@huawei.com> --- drivers/mmc/host/owl-mmc.c | 1 - 1 file changed, 1 deletion(-)