| Message ID | 20210920194633.814-1-mhei@heimpold.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3] mmc-utils: One further optimization of trimming routine | expand |
> The last change to the trimming routine made it more efficient, > however, we can even get rid of the memmove() as we leave the > function with strdup() anyway. > > Signed-off-by: Michael Heimpold <mhei@heimpold.de> > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Acked-by: Avri Altman <avri.altman@wdc.com> > --- > > While doing some house-keeping, I found this somewhat older > patch still hanging around (v2 was sent on 2018-12-08). > I'm just resending to check what's the current opinion > about it :-) > > lsmmc.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/lsmmc.c b/lsmmc.c > index 06cc0b8..05d59e8 100644 > --- a/lsmmc.c > +++ b/lsmmc.c > @@ -393,10 +393,9 @@ char *read_file(char *name) > start++; > len--; > } > - memmove(line, start, len); > - line[len] = '\0'; > > - return strdup(line); > + start[len] = '\0'; > + return strdup(start); > } > > /* Hexadecimal string parsing functions */ > -- > 2.17.1
On Mon, 20 Sept 2021 at 22:01, Michael Heimpold <mhei@heimpold.de> wrote: > > The last change to the trimming routine made it more efficient, > however, we can even get rid of the memmove() as we leave the > function with strdup() anyway. > > Signed-off-by: Michael Heimpold <mhei@heimpold.de> > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Applied to the master branch at https://git.kernel.org/pub/scm/utils/mmc/mmc-utils.git, thanks! Kind regards Uffe > --- > > While doing some house-keeping, I found this somewhat older > patch still hanging around (v2 was sent on 2018-12-08). > I'm just resending to check what's the current opinion > about it :-) > > lsmmc.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/lsmmc.c b/lsmmc.c > index 06cc0b8..05d59e8 100644 > --- a/lsmmc.c > +++ b/lsmmc.c > @@ -393,10 +393,9 @@ char *read_file(char *name) > start++; > len--; > } > - memmove(line, start, len); > - line[len] = '\0'; > > - return strdup(line); > + start[len] = '\0'; > + return strdup(start); > } > > /* Hexadecimal string parsing functions */ > -- > 2.17.1 >
diff --git a/lsmmc.c b/lsmmc.c index 06cc0b8..05d59e8 100644 --- a/lsmmc.c +++ b/lsmmc.c @@ -393,10 +393,9 @@ char *read_file(char *name) start++; len--; } - memmove(line, start, len); - line[len] = '\0'; - return strdup(line); + start[len] = '\0'; + return strdup(start); } /* Hexadecimal string parsing functions */