| Message ID | 20211217150348.GD16611@kili (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mmc: dw_mmc: clean up a debug message | expand |
On Fri, Dec 17, 2021 at 04:03:48PM +0100, Dan Carpenter wrote: > The "0x" prefix is redundant when # flag is used. It prints "0x0x". > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > drivers/mmc/host/dw_mmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index f2a14a434bef..bec4796283fe 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -1307,7 +1307,7 @@ static void dw_mci_set_data_timeout(struct dw_mci *host, > tmout |= (tmp & 0xFFFFFF) << 8; > > mci_writel(host, TMOUT, tmout); > - dev_dbg(host->dev, "timeout_ns: %u => TMOUT[31:8]: 0x%#08x", > + dev_dbg(host->dev, "timeout_ns: %u => TMOUT[31:8]: %#08x", > timeout_ns, tmout >> 8); > } > > -- > 2.20.1 > Reviewed-by: Mårten Lindahl <marten.lindahl@axis.com> Kind regards Mårten
On Fri, 17 Dec 2021 at 16:04, Dan Carpenter <dan.carpenter@oracle.com> wrote: > > The "0x" prefix is redundant when # flag is used. It prints "0x0x". > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/dw_mmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index f2a14a434bef..bec4796283fe 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -1307,7 +1307,7 @@ static void dw_mci_set_data_timeout(struct dw_mci *host, > tmout |= (tmp & 0xFFFFFF) << 8; > > mci_writel(host, TMOUT, tmout); > - dev_dbg(host->dev, "timeout_ns: %u => TMOUT[31:8]: 0x%#08x", > + dev_dbg(host->dev, "timeout_ns: %u => TMOUT[31:8]: %#08x", > timeout_ns, tmout >> 8); > } > > -- > 2.20.1 >
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index f2a14a434bef..bec4796283fe 100644 --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_mmc.c @@ -1307,7 +1307,7 @@ static void dw_mci_set_data_timeout(struct dw_mci *host, tmout |= (tmp & 0xFFFFFF) << 8; mci_writel(host, TMOUT, tmout); - dev_dbg(host->dev, "timeout_ns: %u => TMOUT[31:8]: 0x%#08x", + dev_dbg(host->dev, "timeout_ns: %u => TMOUT[31:8]: %#08x", timeout_ns, tmout >> 8); }
The "0x" prefix is redundant when # flag is used. It prints "0x0x". Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/mmc/host/dw_mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)