@@ -1068,7 +1068,6 @@ static void bcm2835_dma_complete_work(struct work_struct *work)
}
if (host->drain_words) {
- unsigned long flags;
void *page;
u32 *buf;
@@ -1076,7 +1075,6 @@ static void bcm2835_dma_complete_work(struct work_struct *work)
host->drain_page += host->drain_offset >> PAGE_SHIFT;
host->drain_offset &= ~PAGE_MASK;
}
- local_irq_save(flags);
page = kmap_atomic(host->drain_page);
buf = page + host->drain_offset;
@@ -1089,7 +1087,6 @@ static void bcm2835_dma_complete_work(struct work_struct *work)
}
kunmap_atomic(page);
- local_irq_restore(flags);
}
bcm2835_finish_data(host);
A long time ago the kmap_atomic API required a slot to be provided which risked the possibility that other code might use the same slot at the same time. Disabling interrupts prevented the possibility of an interrupt handler doing that. However, that went away with commit 3e4d3af501cc ("mm: stack based kmap_atomic()"). Unfortunately, that unnecessary pattern of code has been copied since and persists in bcm2385.c. Remove it. Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> --- drivers/mmc/host/bcm2835.c | 3 --- 1 file changed, 3 deletions(-)