diff mbox series

[V2] mmc: sdhci-sprd: Fix minimum clock limit

Message ID 20221011104935.10980-1-wenchao.chen666@gmail.com (mailing list archive)
State New, archived
Headers show
Series [V2] mmc: sdhci-sprd: Fix minimum clock limit | expand

Commit Message

Wenchao Chen Oct. 11, 2022, 10:49 a.m. UTC
From: Wenchao Chen <wenchao.chen@unisoc.com>

v1 -> v2:
 - Address Adrian's suggestions

Our controller supports 100K. During the test, it was found that mmc_rescan
failed to scan the card at 400K, and did not try 300K, 200K, and 100K. After
modifying the minimum clock limit to 100K, the card scan was successful

Signed-off-by: Wenchao Chen <wenchao.chen@unisoc.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Fixes: fb8bd90f83c4 ("mmc: sdhci-sprd: Add Spreadtrum's initial host controller")
---
 drivers/mmc/host/sdhci-sprd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ulf Hansson Oct. 11, 2022, 1:51 p.m. UTC | #1
On Tue, 11 Oct 2022 at 12:49, Wenchao Chen <wenchao.chen666@gmail.com> wrote:
>
> From: Wenchao Chen <wenchao.chen@unisoc.com>
>
> v1 -> v2:
>  - Address Adrian's suggestions
>
> Our controller supports 100K. During the test, it was found that mmc_rescan
> failed to scan the card at 400K, and did not try 300K, 200K, and 100K. After
> modifying the minimum clock limit to 100K, the card scan was successful
>
> Signed-off-by: Wenchao Chen <wenchao.chen@unisoc.com>
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> Fixes: fb8bd90f83c4 ("mmc: sdhci-sprd: Add Spreadtrum's initial host controller")

Applied for fixes, thanks!

Kind regards
Uffe

> ---
>  drivers/mmc/host/sdhci-sprd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
> index 46c55ab4884c..b92a408f138d 100644
> --- a/drivers/mmc/host/sdhci-sprd.c
> +++ b/drivers/mmc/host/sdhci-sprd.c
> @@ -309,7 +309,7 @@ static unsigned int sdhci_sprd_get_max_clock(struct sdhci_host *host)
>
>  static unsigned int sdhci_sprd_get_min_clock(struct sdhci_host *host)
>  {
> -       return 400000;
> +       return 100000;
>  }
>
>  static void sdhci_sprd_set_uhs_signaling(struct sdhci_host *host,
> --
> 2.17.1
>
diff mbox series

Patch

diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
index 46c55ab4884c..b92a408f138d 100644
--- a/drivers/mmc/host/sdhci-sprd.c
+++ b/drivers/mmc/host/sdhci-sprd.c
@@ -309,7 +309,7 @@  static unsigned int sdhci_sprd_get_max_clock(struct sdhci_host *host)
 
 static unsigned int sdhci_sprd_get_min_clock(struct sdhci_host *host)
 {
-	return 400000;
+	return 100000;
 }
 
 static void sdhci_sprd_set_uhs_signaling(struct sdhci_host *host,