diff mbox series

mmc: renesas_sdhi: use plain numbers for end_flags

Message ID 20221122080554.4468-1-wsa+renesas@sang-engineering.com (mailing list archive)
State New, archived
Headers show
Series mmc: renesas_sdhi: use plain numbers for end_flags | expand

Commit Message

Wolfram Sang Nov. 22, 2022, 8:05 a.m. UTC
Linux *_bit accessors take plain bit numbers, no need for BIT().

Fixes: 8d901e2ba566 ("mmc: renesas_sdhi: take DMA end interrupts into account")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/mmc/host/renesas_sdhi.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Ulf Hansson Nov. 22, 2022, 3:44 p.m. UTC | #1
On Tue, 22 Nov 2022 at 09:06, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> Linux *_bit accessors take plain bit numbers, no need for BIT().
>
> Fixes: 8d901e2ba566 ("mmc: renesas_sdhi: take DMA end interrupts into account")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/renesas_sdhi.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/renesas_sdhi.h b/drivers/mmc/host/renesas_sdhi.h
> index ea2a85174a09..68da3da9e2e5 100644
> --- a/drivers/mmc/host/renesas_sdhi.h
> +++ b/drivers/mmc/host/renesas_sdhi.h
> @@ -57,8 +57,8 @@ struct renesas_sdhi_of_data_with_quirks {
>  };
>
>  /* We want both end_flags to be set before we mark DMA as finished */
> -#define SDHI_DMA_END_FLAG_DMA          BIT(0)
> -#define SDHI_DMA_END_FLAG_ACCESS       BIT(1)
> +#define SDHI_DMA_END_FLAG_DMA          0
> +#define SDHI_DMA_END_FLAG_ACCESS       1
>
>  struct renesas_sdhi_dma {
>         unsigned long end_flags;
> --
> 2.30.2
>
diff mbox series

Patch

diff --git a/drivers/mmc/host/renesas_sdhi.h b/drivers/mmc/host/renesas_sdhi.h
index ea2a85174a09..68da3da9e2e5 100644
--- a/drivers/mmc/host/renesas_sdhi.h
+++ b/drivers/mmc/host/renesas_sdhi.h
@@ -57,8 +57,8 @@  struct renesas_sdhi_of_data_with_quirks {
 };
 
 /* We want both end_flags to be set before we mark DMA as finished */
-#define SDHI_DMA_END_FLAG_DMA		BIT(0)
-#define SDHI_DMA_END_FLAG_ACCESS	BIT(1)
+#define SDHI_DMA_END_FLAG_DMA		0
+#define SDHI_DMA_END_FLAG_ACCESS	1
 
 struct renesas_sdhi_dma {
 	unsigned long end_flags;