diff mbox series

mmc: sdhci: add static to !OF stub

Message ID 20230311111238.251000-1-krzysztof.kozlowski@linaro.org (mailing list archive)
State New, archived
Headers show
Series mmc: sdhci: add static to !OF stub | expand

Commit Message

Krzysztof Kozlowski March 11, 2023, 11:12 a.m. UTC
The sdhci_get_compatibility() is not used outside of the unit:

  drivers/mmc/host/sdhci-pltfm.c:76:6: error: no previous prototype for ‘sdhci_get_compatibility’ [-Werror=missing-prototypes]

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/mmc/host/sdhci-pltfm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ulf Hansson March 13, 2023, 12:49 p.m. UTC | #1
On Sat, 11 Mar 2023 at 12:12, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> The sdhci_get_compatibility() is not used outside of the unit:
>
>   drivers/mmc/host/sdhci-pltfm.c:76:6: error: no previous prototype for ‘sdhci_get_compatibility’ [-Werror=missing-prototypes]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  drivers/mmc/host/sdhci-pltfm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
> index 328b132bbe57..245e56324dff 100644
> --- a/drivers/mmc/host/sdhci-pltfm.c
> +++ b/drivers/mmc/host/sdhci-pltfm.c
> @@ -73,7 +73,7 @@ static void sdhci_get_compatibility(struct platform_device *pdev)
>                 host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
>  }
>  #else
> -void sdhci_get_compatibility(struct platform_device *pdev) {}
> +static void sdhci_get_compatibility(struct platform_device *pdev) {}
>  #endif /* CONFIG_OF */

sdhci_get_compatibility() is using OF functions with stubs for !OF.

Perhaps a cleaner option is to drop the #ifdef CONFIG_OF completely
around sdhci_get_compatibility(), thus we can drop the stub too.

>
>  void sdhci_get_property(struct platform_device *pdev)
> --
> 2.34.1
>

Kind regards
Uffe
Krzysztof Kozlowski March 14, 2023, 8:12 p.m. UTC | #2
On 13/03/2023 13:49, Ulf Hansson wrote:
> On Sat, 11 Mar 2023 at 12:12, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> The sdhci_get_compatibility() is not used outside of the unit:
>>
>>   drivers/mmc/host/sdhci-pltfm.c:76:6: error: no previous prototype for ‘sdhci_get_compatibility’ [-Werror=missing-prototypes]
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>  drivers/mmc/host/sdhci-pltfm.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
>> index 328b132bbe57..245e56324dff 100644
>> --- a/drivers/mmc/host/sdhci-pltfm.c
>> +++ b/drivers/mmc/host/sdhci-pltfm.c
>> @@ -73,7 +73,7 @@ static void sdhci_get_compatibility(struct platform_device *pdev)
>>                 host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
>>  }
>>  #else
>> -void sdhci_get_compatibility(struct platform_device *pdev) {}
>> +static void sdhci_get_compatibility(struct platform_device *pdev) {}
>>  #endif /* CONFIG_OF */
> 
> sdhci_get_compatibility() is using OF functions with stubs for !OF.
> 
> Perhaps a cleaner option is to drop the #ifdef CONFIG_OF completely
> around sdhci_get_compatibility(), thus we can drop the stub too.

Works, indeed, better idea. I'll send v2.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
index 328b132bbe57..245e56324dff 100644
--- a/drivers/mmc/host/sdhci-pltfm.c
+++ b/drivers/mmc/host/sdhci-pltfm.c
@@ -73,7 +73,7 @@  static void sdhci_get_compatibility(struct platform_device *pdev)
 		host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
 }
 #else
-void sdhci_get_compatibility(struct platform_device *pdev) {}
+static void sdhci_get_compatibility(struct platform_device *pdev) {}
 #endif /* CONFIG_OF */
 
 void sdhci_get_property(struct platform_device *pdev)