Message ID | 20230317092711.660897-1-b-kapoor@ti.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | [v2] mmc: sdhci_am654: Set HIGH_SPEED_ENA for SDR12 and SDR25 | expand |
On Fri, 17 Mar 2023 at 10:28, Bhavya Kapoor <b-kapoor@ti.com> wrote: > > Timing Information in Datasheet assumes that HIGH_SPEED_ENA=1 should be > set for SDR12 and SDR25 modes. But sdhci_am654 driver clears > HIGH_SPEED_ENA register. Thus, Modify sdhci_am654 to not clear > HIGH_SPEED_ENA (HOST_CONTROL[2]) bit for SDR12 and SDR25 speed modes. > > Fixes: e374e87538f4 ("mmc: sdhci_am654: Clear HISPD_ENA in some lower speed modes") > Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com> Applied for fixes and by adding a stable tag, thanks! Kind regards Uffe > --- > > Changelog v1->v2: > - Corrected Names of speed modes in commit message > > Link to v1: https://lore.kernel.org/all/20230316080451.475020-1-b-kapoor@ti.com/ > > drivers/mmc/host/sdhci_am654.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c > index 7ef828942df3..ac90e86bb0a0 100644 > --- a/drivers/mmc/host/sdhci_am654.c > +++ b/drivers/mmc/host/sdhci_am654.c > @@ -351,8 +351,6 @@ static void sdhci_am654_write_b(struct sdhci_host *host, u8 val, int reg) > */ > case MMC_TIMING_SD_HS: > case MMC_TIMING_MMC_HS: > - case MMC_TIMING_UHS_SDR12: > - case MMC_TIMING_UHS_SDR25: > val &= ~SDHCI_CTRL_HISPD; > } > } > -- > 2.34.1 >
diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c index 7ef828942df3..ac90e86bb0a0 100644 --- a/drivers/mmc/host/sdhci_am654.c +++ b/drivers/mmc/host/sdhci_am654.c @@ -351,8 +351,6 @@ static void sdhci_am654_write_b(struct sdhci_host *host, u8 val, int reg) */ case MMC_TIMING_SD_HS: case MMC_TIMING_MMC_HS: - case MMC_TIMING_UHS_SDR12: - case MMC_TIMING_UHS_SDR25: val &= ~SDHCI_CTRL_HISPD; } }
Timing Information in Datasheet assumes that HIGH_SPEED_ENA=1 should be set for SDR12 and SDR25 modes. But sdhci_am654 driver clears HIGH_SPEED_ENA register. Thus, Modify sdhci_am654 to not clear HIGH_SPEED_ENA (HOST_CONTROL[2]) bit for SDR12 and SDR25 speed modes. Fixes: e374e87538f4 ("mmc: sdhci_am654: Clear HISPD_ENA in some lower speed modes") Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com> --- Changelog v1->v2: - Corrected Names of speed modes in commit message Link to v1: https://lore.kernel.org/all/20230316080451.475020-1-b-kapoor@ti.com/ drivers/mmc/host/sdhci_am654.c | 2 -- 1 file changed, 2 deletions(-)